drm/imx: hide an unused label
Subsystems (3)
PATCH 1/1 drm/imx: hide an unused label
The imx_drm_bind function causes a warning in linux-next when CONFIG_DRM_FBDEV_EMULATION is not set:
drivers/gpu/drm/imx/imx-drm-core.c: In function 'imx_drm_bind':drivers/gpu/drm/imx/imx-drm-core.c:441:1: error: label 'err_unbind' defined but not used [-Werror=unused-label]
I don't understand why the warning only showed up now, as the code has not been modified recently, but there is an obvious fix in adding another #if for the symbol.
--- drivers/gpu/drm/imx/imx-drm-core.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/gpu/drm/imx/imx-drm-core.c +2 -0
@@ -436,9 +436,11 @@ static int imx_drm_bind(struct device *dev) err_fbhelper:drm_kms_helper_poll_fini (drm); +#if IS_ENABLED (CONFIG_DRM_FBDEV_EMULATION )if (imxdrm->fbhelper)drm_fbdev_cma_fini (imxdrm->fbhelper); err_unbind: +#endif component_unbind_all (drm->dev, drm); err_vblank:drm_vblank_cleanup (drm);
Signature · 1 line
2.9.0
Philipp Zabel
AppliedAm Donnerstag, den 22.09.2016, 11:50 +0200 schrieb Arnd Bergmann:
Quoted 6 lines
The
imx_drm_bindfunction causes a warning in linux-next whenCONFIG_DRM_FBDEV_EMULATIONis not set:
drivers/gpu/drm/imx/imx-drm-core.c: In function 'imx_drm_bind':drivers/gpu/drm/imx/imx-drm-core.c:441:1: error: label 'err_unbind' defined but not used [-Werror=unused-label]
Quoted 6 lines
I don't understand why the warning only showed up now, as the code has not been modified recently, but there is an obvious fix in adding another #if for the symbol.
Signed-off-by Arnd Bergmann <[email protected]>Fixes c1ff5a7aa3c3 ("drm/imx: Remove local fbdev emulation Kconfig option")
Applied, thank you.
regards
Philipp
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel