drivers: wlan-ng: fixed a coding style issue
PATCH 1/1 drivers: wlan-ng: fixed a coding style issue
removed a space after a cast to obtain the coding style.
--- drivers/staging/wlan-ng/p80211req.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/wlan-ng/p80211req.c +1 -1
@@ -110,7 +110,7 @@ static void p80211req_handle_action(struct wlandevice *wlandev, u32 *data,----------------------------------------------------------------*/ int p80211req_dorequest (struct wlandevice *wlandev,u8 *msgbuf) { -struct p80211msg *msg = (struct p80211msg *) msgbuf; +struct p80211msg *msg = (struct p80211msg *)msgbuf;/* Check to make sure the MSD is running */ if (!((wlandev->msdstate == WLAN_MSD_HWPRESENT &&
Signature · 1 line
2.10.0
Quoted 12 lines · Jannik Becher
removed a space after a cast to obtain the coding style.
Signed-off-by Jannik Becher <[email protected]>--- drivers/staging/wlan-ng/p80211req.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/wlan-ng/p80211req.c +0
-0
drivers/staging/wlan-ng/p80211req.c static void p80211req_handle_action(struct wlandevice *wlandev, u32 *data, · line 116
Quoted 8 lines
drivers/staging/wlan-ng/p80211req.c +1
-1@@ -110,7 +110,7 @@ static void p80211req_handle_action(struct wlandevice *wlandev, u32 *data,----------------------------------------------------------------*/ int p80211req_dorequest (struct wlandevice *wlandev,u8 *msgbuf) { -struct p80211msg *msg = (struct p80211msg *) msgbuf; +struct p80211msg *msg = (struct p80211msg *)msgbuf;/* Check to make sure the MSD is running */ if (!((wlandev->msdstate == WLAN_MSD_HWPRESENT &&
checkpatch.pl shows that in this file there are other occurances of style deviations - of same or other kinds. Could you please present work on wider scope, e.g. on whole wlan-ng/, or at last making this one file to pass checkpatch.pl --strict cleanly?
Not that I don't appreciate this small achievement, but I believe maintainers won't merge this one, exactly because there is more work of same kind in the same file.
Quoted 27 lines · Andrey Utkin
Quoted 12 lines · Jannik Becher
removed a space after a cast to obtain the coding style.
Signed-off-by Jannik Becher <[email protected]>--- drivers/staging/wlan-ng/p80211req.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/wlan-ng/p80211req.c +0
-0drivers/staging/wlan-ng/p80211req.c static void p80211req_handle_action(struct wlandevice *wlandev, u32 *data, · line 116
Quoted 8 lines
drivers/staging/wlan-ng/p80211req.c +1
-1@@ -110,7 +110,7 @@ static void p80211req_handle_action(struct wlandevice *wlandev, u32 *data,----------------------------------------------------------------*/ int p80211req_dorequest (struct wlandevice *wlandev,u8 *msgbuf) { -struct p80211msg *msg = (struct p80211msg *) msgbuf; +struct p80211msg *msg = (struct p80211msg *)msgbuf;/* Check to make sure the MSD is running */ if (!((wlandev->msdstate == WLAN_MSD_HWPRESENT &&checkpatch.pl shows that in this file there are other occurances of style deviations - of same or other kinds. Could you please present work on wider scope, e.g. on whole wlan-ng/, or at last making this one file to pass checkpatch.pl --strict cleanly?
Quoted 3 lines
Not that I don't appreciate this small achievement, but I believe maintainers won't merge this one, exactly because there is more work of same kind in the same file.
I always wondered why I shouldn't make more than one change in a patch, but in all talks I watched they said that it's easier for them to merge small patches.
So you think I should make one "big" patch and resend it? Thank you for taking your time.
Quoted 5 lines · On Thu, 2016-09-22 at 22:52 +0200, [email protected] wrote:
I always wondered why I shouldn't make more than one change in a patch, but in all talks I watched they said that it's easier for them to merge small patches.
So you think I should make one "big" patch and resend it?
Make separate patches for each "type" of change.
Here it would be removing unnecessary space before all casts in the same file or for all specific driver files.
Quoted 5 lines · On Thu, Sep 22, 2016 at 10:52:18PM +0200, [email protected] wrote:
I always wondered why I shouldn't make more than one change in a patch, but in all talks I watched they said that it's easier for them to merge small patches.
So you think I should make one "big" patch and resend it? Thank you for taking your time.
There is "big" and then there is "big".
Walking through entire driver fixing all occurances of _same_ issues really should be done at once. Trivial style fixes don't usually go in huge series of commits (but BTW if you send several related patches, please send them as series at once). And leave granularity to conceptually different changes.