Skip to contentSkip to conversation

greybus: manifest: style fix missing space before '('

PATCH Superseded Quentin Lambert 3 participants 6 messages Sep 27, 2016

Subsystems (3)
Staging Kernel janitors Greybus
lore
Share & tools
lore

Quentin Lambert

author
#0 lore raw

PATCH 1/1 greybus: manifest: style fix missing space before '('

Checkpatch printed a style ERROR concerning a missing space befire '('. This patch fix this issue.

Signed-off-by Quentin Lambert <[email protected]>
---
 drivers/staging/greybus/manifest.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/greybus/manifest.c +1 -1
@@ -11,7 +11,7 @@
 
 static const char *get_descriptor_type_string(u8 type)
 {
-	switch(type) {
+	switch (type) {
 	case GREYBUS_TYPE_INVALID:
 		return "invalid";
 	case GREYBUS_TYPE_STRING:
Acked-by on v1 1/1
#1 lore raw
Quoted 11 lines · Quentin Lambert

Checkpatch printed a style ERROR concerning a missing space befire '('. This patch fix this issue.

Signed-off-by Quentin Lambert <[email protected]>
---
 drivers/staging/greybus/manifest.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/staging/greybus/manifest.c line 17

Quoted 8 lines
drivers/staging/greybus/manifest.c +1 -1
@@ -11,7 +11,7 @@
 
 static const char *get_descriptor_type_string(u8 type)
 {
-       switch(type) {
+       switch (type) {
        case GREYBUS_TYPE_INVALID:
                return "invalid";
        case GREYBUS_TYPE_STRING:
Acked-by Viresh Kumar <[email protected]>
author
#2 lore raw
Quoted 14 lines · Viresh Kumar
Quoted 12 lines · Quentin Lambert

Checkpatch printed a style ERROR concerning a missing space befire '('. This patch fix this issue.

Signed-off-by Quentin Lambert <[email protected]>
---
  drivers/staging/greybus/manifest.c |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/greybus/manifest.c +0 -0
@@ -11,7 +11,7 @@
Quoted 8 lines

drivers/staging/greybus/manifest.c line 17

Quoted 7 lines
drivers/staging/greybus/manifest.c +1 -1
  static const char *get_descriptor_type_string(u8 type)
  {
-       switch(type) {
+       switch (type) {
         case GREYBUS_TYPE_INVALID:
                 return "invalid";
         case GREYBUS_TYPE_STRING:
Acked-by Viresh Kumar <[email protected]>

Wow I just noticed the typo: "befire" do you want me to resend ?

Quentin

#3 lore raw
Quoted 29 lines · Quentin Lambert
Quoted 16 lines · Viresh Kumar
Quoted 13 lines · Quentin Lambert

Checkpatch printed a style ERROR concerning a missing space befire '('. This patch fix this issue.

Signed-off-by Quentin Lambert <[email protected]>
---
  drivers/staging/greybus/manifest.c |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/greybus/manifest.c +0 -0
@@ -11,7 +11,7 @@
Quoted 9 lines

drivers/staging/greybus/manifest.c line 17

Quoted 7 lines
drivers/staging/greybus/manifest.c +1 -1
  static const char *get_descriptor_type_string(u8 type)
  {
-       switch(type) {
+       switch (type) {
         case GREYBUS_TYPE_INVALID:
                 return "invalid";
         case GREYBUS_TYPE_STRING:
Acked-by Viresh Kumar <[email protected]>
Quoted 1 line

Wow I just noticed the typo: "befire" do you want me to resend ?

Oops, sorry for missing that.

Yes, please resend the patch as V2 and feel free to add my Ack to it.

--
viresh

#4 lore raw
In reply to Quentin Lambert
Quoted 25 lines · Quentin Lambert
Quoted 14 lines · Viresh Kumar
Quoted 12 lines · Quentin Lambert

Checkpatch printed a style ERROR concerning a missing space befire '('. This patch fix this issue.

Signed-off-by Quentin Lambert <[email protected]>
---
 drivers/staging/greybus/manifest.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/greybus/manifest.c +0 -0
@@ -11,7 +11,7 @@
Quoted 8 lines

drivers/staging/greybus/manifest.c line 17

Quoted 7 lines
drivers/staging/greybus/manifest.c +1 -1
 static const char *get_descriptor_type_string(u8 type)
 {
-       switch(type) {
+       switch (type) {
        case GREYBUS_TYPE_INVALID:
                return "invalid";
        case GREYBUS_TYPE_STRING:
Acked-by Viresh Kumar <[email protected]>
Quoted 1 line

Wow I just noticed the typo: "befire" do you want me to resend ?

No one cares about tiny typos in the patch description, but resend if you want.

regards,
dan carpenter

author
#5 lore raw

PATCH v2 1/1 greybus: manifest: style fix missing space before '('

In reply to Quentin Lambert

Checkpatch printed a style ERROR concerning a missing space before '('. This patch fixes this issue.

Signed-off-by Quentin Lambert <[email protected]>
Acked-by Viresh Kumar <[email protected]>

---
v2: fixes typos in commit message

 drivers/staging/greybus/manifest.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/greybus/manifest.c +1 -1
@@ -11,7 +11,7 @@
 
 static const char *get_descriptor_type_string(u8 type)
 {
-	switch(type) {
+	switch (type) {
 	case GREYBUS_TYPE_INVALID:
 		return "invalid";
 	case GREYBUS_TYPE_STRING: