Skip to contentSkip to conversation

No speculated stores

PATCH In review Paul E. McKenney 1 participant 1 message Sep 29, 2016

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 2/2 No speculated stores

This commit reworks an erroneous example that claims that dependency barriers are needed to prevent speculation of dependent stores.

---
 Documentation/memory-barriers.txt | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)
Documentation/memory-barriers.txt +6 -4
index a57679ec9441..b6307139b81a 100644
@@ -598,7 +598,9 @@ between the address load and the data load:
 This enforces the occurrence of one of the two implications, and prevents the
 third possibility from arising.
 
-A data-dependency barrier must also order against dependent writes:
+However, writes are never speculated, so it is not necessary (but is
+good documentation practice) to use data-dependency barrier to order
+against dependent writes:
 
 	CPU 1		      CPU 2
 	===============	      ===============
@@ -607,11 +609,11 @@ A data-dependency barrier must also order against dependent writes:
 	<write barrier>
 	WRITE_ONCE(P, &B);
 			      Q = READ_ONCE(P);
-			      <data dependency barrier>
 			      *Q = 5;
 
-The data-dependency barrier must order the read into Q with the store
-into *Q.  This prohibits this outcome:
+The prohibition against speculating writes means that even without a
+data-dependency barrier, the system must order the read into Q with the
+store into *Q.  This prohibits this outcome:
 
 	(Q == &B) && (B == 4)
 
Signature · 1 line
2.5.2