Skip to contentSkip to conversation

Staging:dgnc:dgnc_neo: fixed 80 character line limit coding style issue

PATCH In review Nadim Almas 2 participants 6 messages Sep 30, 2016 – Oct 2, 2016 2 messages not in the archive Staging

lore
Share & tools
lore

Nadim Almas

author
#0 lore raw

PATCH 1/1 Staging:dgnc:dgnc_neo: fixed 80 character line limit coding style issue

Fixed coding style issue.

Signed-off-by Nadim Almas <[email protected]>
---
 drivers/staging/dgnc/dgnc_neo.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/dgnc/dgnc_neo.c +2 -1
index e794056..bc15584 100644
@@ -554,7 +554,8 @@ static inline void neo_parse_lsr(struct dgnc_board *brd, uint port)
 		 * Rx Oruns. Exar says that an orun will NOT corrupt
 		 * the FIFO. It will just replace the holding register
 		 * with this new data byte. So basically just ignore this.
-		 * Probably we should eventually have an orun stat in our driver...
+		 * Probably we should eventually have an orun stat in our
+		 * driver...
 		 */
 		ch->ch_err_overrun++;
 	}
Signature · 1 line
2.7.4
maintainer
#1 lore raw
Quoted 12 lines · Nadim Almas

Fixed coding style issue.

Signed-off-by Nadim Almas <[email protected]>
---
 drivers/staging/dgnc/dgnc_neo.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/dgnc/dgnc_neo.c +0 -0
index e794056..bc15584 100644

drivers/staging/dgnc/dgnc_neo.c static inline void neo_parse_lsr(struct dgnc_board *brd, uint port) · line 561

Quoted 9 lines
drivers/staging/dgnc/dgnc_neo.c +2 -1
@@ -554,7 +554,8 @@ static inline void neo_parse_lsr(struct dgnc_board *brd, uint port)
 		 * Rx Oruns. Exar says that an orun will NOT corrupt
 		 * the FIFO. It will just replace the holding register
 		 * with this new data byte. So basically just ignore this.
-		 * Probably we should eventually have an orun stat in our driver...
+		 * Probably we should eventually have an orun stat in our
+		 * driver...
 		 */
 		ch->ch_err_overrun++;
 	}

Why did you just fix only one of these warnings in the file? You aren't going to send one patch per instance of this warning in this file, are you? Please group it all into one.

thanks,

greg k-h

author
#4 lore raw

PATCH 1/1 Staging:dgnc:dgnc_neo: fixed 80 character line limit coding style issue

In reply to a message not in the archive

sir i am new in linux kernel hacking so I just want to start with something very simple ,so for sake of simplicity and learning I fixed only one of these warning

maintainer
#5 lore raw
Quoted 3 lines · Nadim Almas

sir i am new in linux kernel hacking so I just want to start with something very simple ,so for sake of simplicity and learning I fixed only one of these warning

That's great, but next time try to do a little bit more, just fixing a single warning like that isn't all that useful overall, right?

thanks,

greg k-h

author
#6 lore raw

So my first patch is correct?

Quoted 11 lines · Greg KH
Quoted 3 lines · Nadim Almas

sir i am new in linux kernel hacking so I just want to start with something very simple ,so for sake of simplicity and learning I fixed only one of these warning

That's great, but next time try to do a little bit more, just fixing a single warning like that isn't all that useful overall, right?

thanks,

greg k-h

maintainer
#7 lore raw

A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

Quoted 1 line · Nadim Almas

So my first patch is correct?

I don't remember, I think someone else already did the same work as you, but as I deal with hundreds of patches a day, I can't recall. Resync on my staging-testing branch of staging.git and rebase your patch and do more cleanup than just one tiny one and then resend.

thanks,

greg k-h