Skip to contentSkip to conversation

systemtap: add dependency on boost

PATCH In review Martin Jansa 2 participants 4 messages Oct 3, 2016 – Oct 4, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 systemtap: add dependency on boost

* otherwise the build may fail with:

| ERROR: oe_runmake failed
| In file included from ../../git/staprun/../util.h:44:0,
|                  from ../../git/staprun/../util.cxx:17:
| ../../git/staprun/../stringtable.h:17:29: fatal error: boost/version.hpp: No such file or directory
|  #include <boost/version.hpp>
|                              ^
| compilation terminated.
| In file included from ../../git/staprun/../util.h:44:0,
|                  from ../../git/staprun/../privilege.cxx:23:
| ../../git/staprun/../stringtable.h:17:29: fatal error: boost/version.hpp: No such file or directory
|  #include <boost/version.hpp>
|                              ^
| compilation terminated.
| rm -f libstrfloctime.a
---
 meta/recipes-kernel/systemtap/systemtap_git.bb | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
meta/recipes-kernel/systemtap/systemtap_git.bb +3 -3
index da30fa5..15f0d4e 100644
@@ -2,9 +2,9 @@ SUMMARY = "Script-directed dynamic tracing and performance analysis tool for Lin
 
 require systemtap_git.inc
 
-DEPENDS = "elfutils sqlite3 systemtap-native ncurses json-c"
-DEPENDS_class-native = "elfutils-native sqlite3-native gettext-native"
-DEPENDS_class-nativesdk = "nativesdk-elfutils nativesdk-sqlite3 nativesdk-gettext"
+DEPENDS = "elfutils sqlite3 systemtap-native ncurses json-c boost"
+DEPENDS_class-native = "elfutils-native sqlite3-native gettext-native boost-native"
+DEPENDS_class-nativesdk = "nativesdk-elfutils nativesdk-sqlite3 nativesdk-gettext nativesdk-boost"
 
 RDEPENDS_${PN} += "python3-core bash"
 
Signature · 1 line
2.10.0
#1 lore raw
Quoted 6 lines · Martin Jansa
(quoted diff) +2 -0
+DEPENDS = "elfutils sqlite3 systemtap-native ncurses json-c boost"
+DEPENDS_class-native = "elfutils-native sqlite3-native gettext-native

boost-native"
+DEPENDS_class-nativesdk = "nativesdk-elfutils nativesdk-sqlite3 nativesdk-gettext nativesdk-boost"

So why does systemtap appear to have floating dependencies for ncurses and json-c? Should we be expressing this as a single DEPENDS line with something like different PACKAGECONFIG for target/native?

Ross

#2 lore raw

PACKAGECONFIG would be nice

I don't use systemtap, I've just noticed it failing in one of my world builds after recent boost which probably remove native boost from sysroot between systemtap's do_configure and do_compile and caused this failure.

Quoted 16 lines · Ross
Quoted 6 lines · Martin Jansa
(quoted diff) +2 -0
+DEPENDS = "elfutils sqlite3 systemtap-native ncurses json-c boost"
+DEPENDS_class-native = "elfutils-native sqlite3-native gettext-native

boost-native"
+DEPENDS_class-nativesdk = "nativesdk-elfutils nativesdk-sqlite3 nativesdk-gettext nativesdk-boost"

So why does systemtap appear to have floating dependencies for ncurses and json-c? Should we be expressing this as a single DEPENDS line with something like different PACKAGECONFIG for target/native?

Ross

#3 lore raw
Quoted 6 lines · Martin Jansa

PACKAGECONFIG would be nice

I don't use systemtap, I've just noticed it failing in one of my world builds after recent boost which probably remove native boost from sysroot between systemtap's do_configure and do_compile and caused this failure.

Patch incoming that incorporates this.

Ross