Skip to contentSkip to conversation

staging: iio: cdc: ad7152: Add blank line after function to increase readability

PATCH In review Anchal Jain 2 participants 2 messages Oct 4, 2016 – Oct 9, 2016

Subsystems (4)
Staging IIO Analog Devices IIO drivers Staging - industrial io
lore
Share & tools
lore

Anchal Jain

author
#0 lore raw

PATCH v4 1/2 staging: iio: cdc: ad7152: Add blank line after function to increase readability

Add a blank line after the function to increase the readability of the code.

Signed-off-by Anchal Jain <[email protected]>

---
changes in v4-
-modify patch title

 drivers/staging/iio/cdc/ad7152.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/staging/iio/cdc/ad7152.c +4 -0
index 1962052..f9767e9 100644
@@ -134,6 +134,7 @@ static inline ssize_t ad7152_start_calib(struct device *dev,
 	mutex_unlock(&indio_dev->mlock);
 	return len;
 }
+
 static ssize_t ad7152_start_offset_calib(struct device *dev,
 					 struct device_attribute *attr,
 					 const char *buf,

@@ -142,6 +143,7 @@ static ssize_t ad7152_start_offset_calib(struct device *dev,
 	return ad7152_start_calib(dev, attr, buf, len,
 				  AD7152_CONF_MODE_OFFS_CAL);
 }
+
 static ssize_t ad7152_start_gain_calib(struct device *dev,
 				       struct device_attribute *attr,
 				       const char *buf,

@@ -317,6 +319,7 @@ out:
 	mutex_unlock(&indio_dev->mlock);
 	return ret;
 }
+
 static int ad7152_read_raw(struct iio_dev *indio_dev,
 			   struct iio_chan_spec const *chan,
 			   int *val, int *val2,

@@ -470,6 +473,7 @@ static const struct iio_chan_spec ad7152_channels[] = {
 		BIT(IIO_CHAN_INFO_SCALE),
 	}
 };
+
 /*
  * device probe and remove
  */
Signature · 1 line
1.9.1
maintainer
#1 lore raw
Quoted 3 lines · Anchal Jain

Add a blank line after the function to increase the readability of the code.

Signed-off-by Anchal Jain <[email protected]>

Hi Anchal,

I applied V3. Good to clean up patches, but once they've gone in just remember to get the little details right for the next one!

(this confused me when I tried to apply V4 today :) Too early on a Sunday and no coffee yet.

Jonathan

Quoted 43 lines

---
changes in v4-
-modify patch title

 drivers/staging/iio/cdc/ad7152.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/staging/iio/cdc/ad7152.c +4 -0
index 1962052..f9767e9 100644
@@ -134,6 +134,7 @@ static inline ssize_t ad7152_start_calib(struct device *dev,
 	mutex_unlock(&indio_dev->mlock);
 	return len;
 }
+
 static ssize_t ad7152_start_offset_calib(struct device *dev,
 					 struct device_attribute *attr,
 					 const char *buf,

@@ -142,6 +143,7 @@ static ssize_t ad7152_start_offset_calib(struct device *dev,
 	return ad7152_start_calib(dev, attr, buf, len,
 				  AD7152_CONF_MODE_OFFS_CAL);
 }
+
 static ssize_t ad7152_start_gain_calib(struct device *dev,
 				       struct device_attribute *attr,
 				       const char *buf,

@@ -317,6 +319,7 @@ out:
 	mutex_unlock(&indio_dev->mlock);
 	return ret;
 }
+
 static int ad7152_read_raw(struct iio_dev *indio_dev,
 			   struct iio_chan_spec const *chan,
 			   int *val, int *val2,

@@ -470,6 +473,7 @@ static const struct iio_chan_spec ad7152_channels[] = {
 		BIT(IIO_CHAN_INFO_SCALE),
 	}
 };
+
 /*
  * device probe and remove
  */