Skip to contentSkip to conversation

xrandr fails after resume from hibernation in kernels 4.7.4 and 4.8.0

DISCUSSION Gaston Gonzalez 5 participants 10 messages Oct 4, 2016 – Nov 9, 2016 Stable branch

lore
Share & tools
lore

Gaston Gonzalez

author
#0 lore raw

Hi,

After hibernation I get the following error when I tried to connect to monitor through hdmi:

$ xrandr --output LVDS1 --off  --output  HDMI1 --auto
xrandr: Configure crtc 1 failed

This does not happen in kernel in kernel v4.6.7 but do happen in kernels v4.7.4 and v4.8.0

I don't see anything related to this in the kernel log.

This happens after hibernation but not after suspend to ram.

I use a Thinkpad T430

$ lspci | grep -i vga
00:02.0 VGA compatible controller: Intel Corporation 3rd Gen Core processor
Graphics Controller (rev 09)

regards,

Gaston

maintainer
#1 lore raw
Quoted 10 lines · Gaston Gonzalez

Hi,

After hibernation I get the following error when I tried to connect to monitor through hdmi:

$ xrandr --output LVDS1 --off  --output  HDMI1 --auto
xrandr: Configure crtc 1 failed

This does not happen in kernel in kernel v4.6.7 but do happen in kernels v4.7.4 and v4.8.0

Ah, can you use 'git bisect' to track down the offending patch?

Also, if you let the graphics driver authors know, they are probably the best ones to help out with this, not the "generic" stable mailing list.

thanks,

greg k-h

author
#2 lore raw
Quoted 12 lines · Greg KH
Quoted 10 lines · Gaston Gonzalez

Hi,

After hibernation I get the following error when I tried to connect to monitor through hdmi:

$ xrandr --output LVDS1 --off  --output  HDMI1 --auto
xrandr: Configure crtc 1 failed

This does not happen in kernel in kernel v4.6.7 but do happen in kernels v4.7.4 and v4.8.0

Quoted 8 lines

Ah, can you use 'git bisect' to track down the offending patch?

Also, if you let the graphics driver authors know, they are probably the best ones to help out with this, not the "generic" stable mailing list.

thanks,

greg k-h

Ok, I'll bisect this between v4.6.7 and v4.7.4

Added [email protected] in CC.

regards,

Gaston

author
#3 lore raw
In reply to Greg KH
Quoted 12 lines · Greg KH
Quoted 10 lines · Gaston Gonzalez

Hi,

After hibernation I get the following error when I tried to connect to monitor through hdmi:

$ xrandr --output LVDS1 --off  --output  HDMI1 --auto
xrandr: Configure crtc 1 failed

This does not happen in kernel in kernel v4.6.7 but do happen in kernels v4.7.4 and v4.8.0

Quoted 8 lines

Ah, can you use 'git bisect' to track down the offending patch?

Also, if you let the graphics driver authors know, they are probably the best ones to help out with this, not the "generic" stable mailing list.

thanks,

greg k-h

Hello,

The culprit commit seems to be:

commit: ed4a6a7
drm/i915: Add two-stage ILK-style watermark programming

Attached the bisection log.

Let me know if additional test or bisect is needed.

Best regards,

Gaston

git bisect start '--' 'drivers/gpu/drm/'
# good: [096998b11906dd79df5af4d688c9974342dd09f2] Linux 4.6.7
git bisect good 096998b11906dd79df5af4d688c9974342dd09f2
# bad: [c8d2bc9bc39ebea8437fd974fdbc21847bb897a3] Linux 4.8
git bisect bad c8d2bc9bc39ebea8437fd974fdbc21847bb897a3
# good: [2dcd0af568b0cf583645c8a317dd12e344b1c72a] Linux 4.6
git bisect good 2dcd0af568b0cf583645c8a317dd12e344b1c72a
# bad: [3c85f20a289d044f303f473ee6ab7502303fc3b0] Merge tag 'omapdrm-4.8' of git://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux into drm-next git bisect bad 3c85f20a289d044f303f473ee6ab7502303fc3b0
# bad: [a64424d722504926f3375bc4887976e3bfe3a01d] Merge branch 'drm-next-4.7' of git://people.freedesktop.org/~agd5f/linux into drm-next git bisect bad a64424d722504926f3375bc4887976e3bfe3a01d
# bad: [b5bf0f1ea3658254bd72ef64abc97786e8a32255] drm/exynos: clean up register definions for fimd and decon
git bisect bad b5bf0f1ea3658254bd72ef64abc97786e8a32255
# bad: [27878ede4fec7b929c3010710ba4d55c617c621d] drm/i915: Throw out BUGs from DPLL/PCH functions
git bisect bad 27878ede4fec7b929c3010710ba4d55c617c621d
# bad: [72341af4285ae1337c0dfdfa3e68318b52b8757c] drm/i915: hide away VBT private data in a separate header
git bisect bad 72341af4285ae1337c0dfdfa3e68318b52b8757c
# bad: [71f0a626143368b8aead361ffaff7e36d043fd8e] drm/i915: Only use sanitized values for ILK watermarks
git bisect bad 71f0a626143368b8aead361ffaff7e36d043fd8e
# bad: [66e2c4c39cc37beaccc24c9d14c75d627fce9cf4] drm/i915/gen9: Disable DC states if power well support is disabled
git bisect bad 66e2c4c39cc37beaccc24c9d14c75d627fce9cf4
# bad: [4f2d9934bd6ac73950832c96b385822846670668] drm/i915: Pass drm_frambuffer to intel_compute_page_offset()
git bisect bad 4f2d9934bd6ac73950832c96b385822846670668
# bad: [1d5bf5d9d9ef0c1e639d36178a224d83888c5a29] drm/i915: Add missing NULL check before calling initial_watermarks
git bisect bad 1d5bf5d9d9ef0c1e639d36178a224d83888c5a29
# bad: [d9f8e52b22454a30aaaf26b7ef029598b30abf8e] drm/i915: remove dead code
git bisect bad d9f8e52b22454a30aaaf26b7ef029598b30abf8e
# bad: [c3454d575da162cd310d9b83696baefb29d10a70] drm/i915: remove left over dead code
git bisect bad c3454d575da162cd310d9b83696baefb29d10a70
# bad: [ed4a6a7ca853253f9b86f3005d76345482a71283] drm/i915: Add two-stage ILK-style watermark programming (v11)
git bisect bad ed4a6a7ca853253f9b86f3005d76345482a71283

# first bad commit: [ed4a6a7ca853253f9b86f3005d76345482a71283] drm/i915: Add two-stage ILK-style watermark programming (v11)
maintainer
#4 lore raw
Quoted 68 lines · Gaston Gonzalez
Quoted 12 lines · Greg KH
Quoted 10 lines · Gaston Gonzalez

Hi,

After hibernation I get the following error when I tried to connect to monitor through hdmi:

$ xrandr --output LVDS1 --off  --output  HDMI1 --auto
xrandr: Configure crtc 1 failed

This does not happen in kernel in kernel v4.6.7 but do happen in kernels v4.7.4 and v4.8.0

Quoted 8 lines

Ah, can you use 'git bisect' to track down the offending patch?

Also, if you let the graphics driver authors know, they are probably the best ones to help out with this, not the "generic" stable mailing list.

thanks,

greg k-h

Hello,

The culprit commit seems to be:

commit: ed4a6a7
drm/i915: Add two-stage ILK-style watermark programming

Attached the bisection log.

Let me know if additional test or bisect is needed.

Best regards,

Gaston

git bisect start '--' 'drivers/gpu/drm/'
# good: [096998b11906dd79df5af4d688c9974342dd09f2] Linux 4.6.7
git bisect good 096998b11906dd79df5af4d688c9974342dd09f2
# bad: [c8d2bc9bc39ebea8437fd974fdbc21847bb897a3] Linux 4.8
git bisect bad c8d2bc9bc39ebea8437fd974fdbc21847bb897a3
# good: [2dcd0af568b0cf583645c8a317dd12e344b1c72a] Linux 4.6
git bisect good 2dcd0af568b0cf583645c8a317dd12e344b1c72a
# bad: [3c85f20a289d044f303f473ee6ab7502303fc3b0] Merge tag 'omapdrm-4.8' of git://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux into drm-next git bisect bad 3c85f20a289d044f303f473ee6ab7502303fc3b0
# bad: [a64424d722504926f3375bc4887976e3bfe3a01d] Merge branch 'drm-next-4.7' of git://people.freedesktop.org/~agd5f/linux into drm-next git bisect bad a64424d722504926f3375bc4887976e3bfe3a01d
# bad: [b5bf0f1ea3658254bd72ef64abc97786e8a32255] drm/exynos: clean up register definions for fimd and decon
git bisect bad b5bf0f1ea3658254bd72ef64abc97786e8a32255
# bad: [27878ede4fec7b929c3010710ba4d55c617c621d] drm/i915: Throw out BUGs from DPLL/PCH functions
git bisect bad 27878ede4fec7b929c3010710ba4d55c617c621d
# bad: [72341af4285ae1337c0dfdfa3e68318b52b8757c] drm/i915: hide away VBT private data in a separate header
git bisect bad 72341af4285ae1337c0dfdfa3e68318b52b8757c
# bad: [71f0a626143368b8aead361ffaff7e36d043fd8e] drm/i915: Only use sanitized values for ILK watermarks
git bisect bad 71f0a626143368b8aead361ffaff7e36d043fd8e
# bad: [66e2c4c39cc37beaccc24c9d14c75d627fce9cf4] drm/i915/gen9: Disable DC states if power well support is disabled
git bisect bad 66e2c4c39cc37beaccc24c9d14c75d627fce9cf4
# bad: [4f2d9934bd6ac73950832c96b385822846670668] drm/i915: Pass drm_frambuffer to intel_compute_page_offset()
git bisect bad 4f2d9934bd6ac73950832c96b385822846670668
# bad: [1d5bf5d9d9ef0c1e639d36178a224d83888c5a29] drm/i915: Add missing NULL check before calling initial_watermarks
git bisect bad 1d5bf5d9d9ef0c1e639d36178a224d83888c5a29
# bad: [d9f8e52b22454a30aaaf26b7ef029598b30abf8e] drm/i915: remove dead code
git bisect bad d9f8e52b22454a30aaaf26b7ef029598b30abf8e
# bad: [c3454d575da162cd310d9b83696baefb29d10a70] drm/i915: remove left over dead code
git bisect bad c3454d575da162cd310d9b83696baefb29d10a70
# bad: [ed4a6a7ca853253f9b86f3005d76345482a71283] drm/i915: Add two-stage ILK-style watermark programming (v11)
git bisect bad ed4a6a7ca853253f9b86f3005d76345482a71283

Quoted 1 line
# first bad commit: [ed4a6a7ca853253f9b86f3005d76345482a71283] drm/i915: Add two-stage ILK-style watermark programming (v11)

Nothing from the graphics developers? Come on, here is someone who found a specific patch that causes a problem, and no one responds?

Why isn't this fixed by reverting the above mentioned patch in Linus's tree already? Or, is there something else that needs to be done?

thanks,

greg k-h
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#5 lore raw
Quoted 72 lines · Greg KH
Quoted 68 lines · Gaston Gonzalez
Quoted 12 lines · Greg KH
Quoted 10 lines · Gaston Gonzalez

Hi,

After hibernation I get the following error when I tried to connect to monitor through hdmi:

$ xrandr --output LVDS1 --off  --output  HDMI1 --auto
xrandr: Configure crtc 1 failed

This does not happen in kernel in kernel v4.6.7 but do happen in kernels v4.7.4 and v4.8.0

Quoted 8 lines

Ah, can you use 'git bisect' to track down the offending patch?

Also, if you let the graphics driver authors know, they are probably the best ones to help out with this, not the "generic" stable mailing list.

thanks,

greg k-h

Hello,

The culprit commit seems to be:

commit: ed4a6a7
drm/i915: Add two-stage ILK-style watermark programming

Attached the bisection log.

Let me know if additional test or bisect is needed.

Best regards,

Gaston

git bisect start '--' 'drivers/gpu/drm/'
# good: [096998b11906dd79df5af4d688c9974342dd09f2] Linux 4.6.7
git bisect good 096998b11906dd79df5af4d688c9974342dd09f2
# bad: [c8d2bc9bc39ebea8437fd974fdbc21847bb897a3] Linux 4.8
git bisect bad c8d2bc9bc39ebea8437fd974fdbc21847bb897a3
# good: [2dcd0af568b0cf583645c8a317dd12e344b1c72a] Linux 4.6
git bisect good 2dcd0af568b0cf583645c8a317dd12e344b1c72a
# bad: [3c85f20a289d044f303f473ee6ab7502303fc3b0] Merge tag 'omapdrm-4.8' of git://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux into drm-next git bisect bad 3c85f20a289d044f303f473ee6ab7502303fc3b0
# bad: [a64424d722504926f3375bc4887976e3bfe3a01d] Merge branch 'drm-next-4.7' of git://people.freedesktop.org/~agd5f/linux into drm-next git bisect bad a64424d722504926f3375bc4887976e3bfe3a01d
# bad: [b5bf0f1ea3658254bd72ef64abc97786e8a32255] drm/exynos: clean up register definions for fimd and decon
git bisect bad b5bf0f1ea3658254bd72ef64abc97786e8a32255
# bad: [27878ede4fec7b929c3010710ba4d55c617c621d] drm/i915: Throw out BUGs from DPLL/PCH functions
git bisect bad 27878ede4fec7b929c3010710ba4d55c617c621d
# bad: [72341af4285ae1337c0dfdfa3e68318b52b8757c] drm/i915: hide away VBT private data in a separate header
git bisect bad 72341af4285ae1337c0dfdfa3e68318b52b8757c
# bad: [71f0a626143368b8aead361ffaff7e36d043fd8e] drm/i915: Only use sanitized values for ILK watermarks
git bisect bad 71f0a626143368b8aead361ffaff7e36d043fd8e
# bad: [66e2c4c39cc37beaccc24c9d14c75d627fce9cf4] drm/i915/gen9: Disable DC states if power well support is disabled
git bisect bad 66e2c4c39cc37beaccc24c9d14c75d627fce9cf4
# bad: [4f2d9934bd6ac73950832c96b385822846670668] drm/i915: Pass drm_frambuffer to intel_compute_page_offset()
git bisect bad 4f2d9934bd6ac73950832c96b385822846670668
# bad: [1d5bf5d9d9ef0c1e639d36178a224d83888c5a29] drm/i915: Add missing NULL check before calling initial_watermarks
git bisect bad 1d5bf5d9d9ef0c1e639d36178a224d83888c5a29
# bad: [d9f8e52b22454a30aaaf26b7ef029598b30abf8e] drm/i915: remove dead code
git bisect bad d9f8e52b22454a30aaaf26b7ef029598b30abf8e
# bad: [c3454d575da162cd310d9b83696baefb29d10a70] drm/i915: remove left over dead code
git bisect bad c3454d575da162cd310d9b83696baefb29d10a70
# bad: [ed4a6a7ca853253f9b86f3005d76345482a71283] drm/i915: Add two-stage ILK-style watermark programming (v11)
git bisect bad ed4a6a7ca853253f9b86f3005d76345482a71283

Quoted 1 line
# first bad commit: [ed4a6a7ca853253f9b86f3005d76345482a71283] drm/i915: Add two-stage ILK-style watermark programming (v11)
Quoted 2 lines

Nothing from the graphics developers? Come on, here is someone who found a specific patch that causes a problem, and no one responds?

Probably no one noticed the mail on account of the relevant lists not getting Cc:d from the get go. Sorry.

Quoted 3 lines

Why isn't this fixed by reverting the above mentioned patch in Linus's tree already? Or, is there something else that needs to be done?

IIRC the problems caused by that watermark stuff should have been fixed by some combination of these
9bd18728a3f2 ("drm/i915: Ignore stale wm register values on resume on ilk-bdw (v2)") 7045c3689f14 ("drm/i915: Don't leave old junk in ilk active watermarks on readout") d890565c4444 ("drm/i915: Use the active wm config for merging on ILK-BDW") f1ecaf8f9c99 ("drm/i915: Start WM computation from scratch on ILK-BDW")

so it's not quite clear if the bisect landed at the right spot, or if we have more than one overlapping regression around.

Please file a bug at
https://bugs.freedesktop.org/enter_bug.cgi?product=DRI&component=DRM/Intel
and attach the full dmesg from boot up to when you reproduced the problem. And pass drm.debug=0xe to kernel so that we'll get (hopefully) enough debug information into the log.

Trying the latest nightly tree from
git://anongit.freedesktop.org/drm-intel drm-intel-nightly would also be a good idea, in case we already fixed the problem.

Signature · 2 lines
Ville Syrjälä
Intel OTC
author
#6 lore raw
Quoted 99 lines · Ville Syrjälä
Quoted 72 lines · Greg KH
Quoted 68 lines · Gaston Gonzalez
Quoted 12 lines · Greg KH
Quoted 10 lines · Gaston Gonzalez

Hi,

After hibernation I get the following error when I tried to connect to monitor through hdmi:

$ xrandr --output LVDS1 --off  --output  HDMI1 --auto
xrandr: Configure crtc 1 failed

This does not happen in kernel in kernel v4.6.7 but do happen in kernels v4.7.4 and v4.8.0

Quoted 8 lines

Ah, can you use 'git bisect' to track down the offending patch?

Also, if you let the graphics driver authors know, they are probably the best ones to help out with this, not the "generic" stable mailing list.

thanks,

greg k-h

Hello,

The culprit commit seems to be:

commit: ed4a6a7
drm/i915: Add two-stage ILK-style watermark programming

Attached the bisection log.

Let me know if additional test or bisect is needed.

Best regards,

Gaston

git bisect start '--' 'drivers/gpu/drm/'
# good: [096998b11906dd79df5af4d688c9974342dd09f2] Linux 4.6.7
git bisect good 096998b11906dd79df5af4d688c9974342dd09f2
# bad: [c8d2bc9bc39ebea8437fd974fdbc21847bb897a3] Linux 4.8
git bisect bad c8d2bc9bc39ebea8437fd974fdbc21847bb897a3
# good: [2dcd0af568b0cf583645c8a317dd12e344b1c72a] Linux 4.6
git bisect good 2dcd0af568b0cf583645c8a317dd12e344b1c72a
# bad: [3c85f20a289d044f303f473ee6ab7502303fc3b0] Merge tag 'omapdrm-4.8' of git://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux into drm-next git bisect bad 3c85f20a289d044f303f473ee6ab7502303fc3b0
# bad: [a64424d722504926f3375bc4887976e3bfe3a01d] Merge branch 'drm-next-4.7' of git://people.freedesktop.org/~agd5f/linux into drm-next git bisect bad a64424d722504926f3375bc4887976e3bfe3a01d
# bad: [b5bf0f1ea3658254bd72ef64abc97786e8a32255] drm/exynos: clean up register definions for fimd and decon
git bisect bad b5bf0f1ea3658254bd72ef64abc97786e8a32255
# bad: [27878ede4fec7b929c3010710ba4d55c617c621d] drm/i915: Throw out BUGs from DPLL/PCH functions
git bisect bad 27878ede4fec7b929c3010710ba4d55c617c621d
# bad: [72341af4285ae1337c0dfdfa3e68318b52b8757c] drm/i915: hide away VBT private data in a separate header
git bisect bad 72341af4285ae1337c0dfdfa3e68318b52b8757c
# bad: [71f0a626143368b8aead361ffaff7e36d043fd8e] drm/i915: Only use sanitized values for ILK watermarks
git bisect bad 71f0a626143368b8aead361ffaff7e36d043fd8e
# bad: [66e2c4c39cc37beaccc24c9d14c75d627fce9cf4] drm/i915/gen9: Disable DC states if power well support is disabled
git bisect bad 66e2c4c39cc37beaccc24c9d14c75d627fce9cf4
# bad: [4f2d9934bd6ac73950832c96b385822846670668] drm/i915: Pass drm_frambuffer to intel_compute_page_offset()
git bisect bad 4f2d9934bd6ac73950832c96b385822846670668
# bad: [1d5bf5d9d9ef0c1e639d36178a224d83888c5a29] drm/i915: Add missing NULL check before calling initial_watermarks
git bisect bad 1d5bf5d9d9ef0c1e639d36178a224d83888c5a29
# bad: [d9f8e52b22454a30aaaf26b7ef029598b30abf8e] drm/i915: remove dead code
git bisect bad d9f8e52b22454a30aaaf26b7ef029598b30abf8e
# bad: [c3454d575da162cd310d9b83696baefb29d10a70] drm/i915: remove left over dead code
git bisect bad c3454d575da162cd310d9b83696baefb29d10a70
# bad: [ed4a6a7ca853253f9b86f3005d76345482a71283] drm/i915: Add two-stage ILK-style watermark programming (v11)
git bisect bad ed4a6a7ca853253f9b86f3005d76345482a71283

Quoted 1 line
# first bad commit: [ed4a6a7ca853253f9b86f3005d76345482a71283] drm/i915: Add two-stage ILK-style watermark programming (v11)
Quoted 2 lines

Nothing from the graphics developers? Come on, here is someone who found a specific patch that causes a problem, and no one responds?

Probably no one noticed the mail on account of the relevant lists not getting Cc:d from the get go. Sorry.

Quoted 3 lines

Why isn't this fixed by reverting the above mentioned patch in Linus's tree already? Or, is there something else that needs to be done?

IIRC the problems caused by that watermark stuff should have been fixed by some combination of these
9bd18728a3f2 ("drm/i915: Ignore stale wm register values on resume on ilk-bdw (v2)") 7045c3689f14 ("drm/i915: Don't leave old junk in ilk active watermarks on readout") d890565c4444 ("drm/i915: Use the active wm config for merging on ILK-BDW") f1ecaf8f9c99 ("drm/i915: Start WM computation from scratch on ILK-BDW")

so it's not quite clear if the bisect landed at the right spot, or if we have more than one overlapping regression around.

Please file a bug at
https://bugs.freedesktop.org/enter_bug.cgi?product=DRI&component=DRM/Intel
and attach the full dmesg from boot up to when you reproduced the problem. And pass drm.debug=0xe to kernel so that we'll get (hopefully) enough debug information into the log.

Quoted 7 lines

Trying the latest nightly tree from
git://anongit.freedesktop.org/drm-intel drm-intel-nightly would also be a good idea, in case we already fixed the problem.

Signature · 2 lines
Ville Syrjälä
Intel OTC

Hi,

Now I'm running a 4.8.4 kernel and the problem seems to be solved. So no need to file a bug report, right?

I have no problem in running further tests/bisect if needed, though.

Best regards,

Gaston
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

maintainer
#7 lore raw
Quoted 104 lines · Gaston Gonzalez
Quoted 103 lines · Ville Syrjälä
Quoted 72 lines · Greg KH
Quoted 68 lines · Gaston Gonzalez
Quoted 12 lines · Greg KH
Quoted 10 lines · Gaston Gonzalez

Hi,

After hibernation I get the following error when I tried to connect to monitor through hdmi:

$ xrandr --output LVDS1 --off  --output  HDMI1 --auto
xrandr: Configure crtc 1 failed

This does not happen in kernel in kernel v4.6.7 but do happen in kernels v4.7.4 and v4.8.0

Quoted 8 lines

Ah, can you use 'git bisect' to track down the offending patch?

Also, if you let the graphics driver authors know, they are probably the best ones to help out with this, not the "generic" stable mailing list.

thanks,

greg k-h

Hello,

The culprit commit seems to be:

commit: ed4a6a7
drm/i915: Add two-stage ILK-style watermark programming

Attached the bisection log.

Let me know if additional test or bisect is needed.

Best regards,

Gaston

git bisect start '--' 'drivers/gpu/drm/'
# good: [096998b11906dd79df5af4d688c9974342dd09f2] Linux 4.6.7
git bisect good 096998b11906dd79df5af4d688c9974342dd09f2
# bad: [c8d2bc9bc39ebea8437fd974fdbc21847bb897a3] Linux 4.8
git bisect bad c8d2bc9bc39ebea8437fd974fdbc21847bb897a3
# good: [2dcd0af568b0cf583645c8a317dd12e344b1c72a] Linux 4.6
git bisect good 2dcd0af568b0cf583645c8a317dd12e344b1c72a
# bad: [3c85f20a289d044f303f473ee6ab7502303fc3b0] Merge tag 'omapdrm-4.8' of git://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux into drm-next git bisect bad 3c85f20a289d044f303f473ee6ab7502303fc3b0
# bad: [a64424d722504926f3375bc4887976e3bfe3a01d] Merge branch 'drm-next-4.7' of git://people.freedesktop.org/~agd5f/linux into drm-next git bisect bad a64424d722504926f3375bc4887976e3bfe3a01d
# bad: [b5bf0f1ea3658254bd72ef64abc97786e8a32255] drm/exynos: clean up register definions for fimd and decon
git bisect bad b5bf0f1ea3658254bd72ef64abc97786e8a32255
# bad: [27878ede4fec7b929c3010710ba4d55c617c621d] drm/i915: Throw out BUGs from DPLL/PCH functions
git bisect bad 27878ede4fec7b929c3010710ba4d55c617c621d
# bad: [72341af4285ae1337c0dfdfa3e68318b52b8757c] drm/i915: hide away VBT private data in a separate header
git bisect bad 72341af4285ae1337c0dfdfa3e68318b52b8757c
# bad: [71f0a626143368b8aead361ffaff7e36d043fd8e] drm/i915: Only use sanitized values for ILK watermarks
git bisect bad 71f0a626143368b8aead361ffaff7e36d043fd8e
# bad: [66e2c4c39cc37beaccc24c9d14c75d627fce9cf4] drm/i915/gen9: Disable DC states if power well support is disabled
git bisect bad 66e2c4c39cc37beaccc24c9d14c75d627fce9cf4
# bad: [4f2d9934bd6ac73950832c96b385822846670668] drm/i915: Pass drm_frambuffer to intel_compute_page_offset()
git bisect bad 4f2d9934bd6ac73950832c96b385822846670668
# bad: [1d5bf5d9d9ef0c1e639d36178a224d83888c5a29] drm/i915: Add missing NULL check before calling initial_watermarks
git bisect bad 1d5bf5d9d9ef0c1e639d36178a224d83888c5a29
# bad: [d9f8e52b22454a30aaaf26b7ef029598b30abf8e] drm/i915: remove dead code
git bisect bad d9f8e52b22454a30aaaf26b7ef029598b30abf8e
# bad: [c3454d575da162cd310d9b83696baefb29d10a70] drm/i915: remove left over dead code
git bisect bad c3454d575da162cd310d9b83696baefb29d10a70
# bad: [ed4a6a7ca853253f9b86f3005d76345482a71283] drm/i915: Add two-stage ILK-style watermark programming (v11)
git bisect bad ed4a6a7ca853253f9b86f3005d76345482a71283

Quoted 1 line
# first bad commit: [ed4a6a7ca853253f9b86f3005d76345482a71283] drm/i915: Add two-stage ILK-style watermark programming (v11)
Quoted 2 lines

Nothing from the graphics developers? Come on, here is someone who found a specific patch that causes a problem, and no one responds?

Probably no one noticed the mail on account of the relevant lists not getting Cc:d from the get go. Sorry.

Quoted 3 lines

Why isn't this fixed by reverting the above mentioned patch in Linus's tree already? Or, is there something else that needs to be done?

IIRC the problems caused by that watermark stuff should have been fixed by some combination of these
9bd18728a3f2 ("drm/i915: Ignore stale wm register values on resume on ilk-bdw (v2)") 7045c3689f14 ("drm/i915: Don't leave old junk in ilk active watermarks on readout") d890565c4444 ("drm/i915: Use the active wm config for merging on ILK-BDW") f1ecaf8f9c99 ("drm/i915: Start WM computation from scratch on ILK-BDW")

so it's not quite clear if the bisect landed at the right spot, or if we have more than one overlapping regression around.

Please file a bug at
https://bugs.freedesktop.org/enter_bug.cgi?product=DRI&component=DRM/Intel
and attach the full dmesg from boot up to when you reproduced the problem. And pass drm.debug=0xe to kernel so that we'll get (hopefully) enough debug information into the log.

Trying the latest nightly tree from
git://anongit.freedesktop.org/drm-intel drm-intel-nightly would also be a good idea, in case we already fixed the problem.

Quoted 8 lines
Quoted 3 lines
Signature · 2 lines
Ville Syrjälä
Intel OTC

Hi,

Now I'm running a 4.8.4 kernel and the problem seems to be solved. So no need to file a bug report, right?

Ah, that's great, no need!

Quoted 1 line

I have no problem in running further tests/bisect if needed, though.

Nope, all should be good now, thanks for letting us know.

greg k-h
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#8 lore raw
Quoted 109 lines · Greg KH
Quoted 108 lines · Gaston Gonzalez
Quoted 106 lines · Ville Syrjälä
Quoted 72 lines · Greg KH
Quoted 68 lines · Gaston Gonzalez
Quoted 12 lines · Greg KH
Quoted 10 lines · Gaston Gonzalez

Hi,

After hibernation I get the following error when I tried to connect to monitor through hdmi:

$ xrandr --output LVDS1 --off  --output  HDMI1 --auto
xrandr: Configure crtc 1 failed

This does not happen in kernel in kernel v4.6.7 but do happen in kernels v4.7.4 and v4.8.0

Quoted 8 lines

Ah, can you use 'git bisect' to track down the offending patch?

Also, if you let the graphics driver authors know, they are probably the best ones to help out with this, not the "generic" stable mailing list.

thanks,

greg k-h

Hello,

The culprit commit seems to be:

commit: ed4a6a7
drm/i915: Add two-stage ILK-style watermark programming

Attached the bisection log.

Let me know if additional test or bisect is needed.

Best regards,

Gaston

git bisect start '--' 'drivers/gpu/drm/'
# good: [096998b11906dd79df5af4d688c9974342dd09f2] Linux 4.6.7
git bisect good 096998b11906dd79df5af4d688c9974342dd09f2
# bad: [c8d2bc9bc39ebea8437fd974fdbc21847bb897a3] Linux 4.8
git bisect bad c8d2bc9bc39ebea8437fd974fdbc21847bb897a3
# good: [2dcd0af568b0cf583645c8a317dd12e344b1c72a] Linux 4.6
git bisect good 2dcd0af568b0cf583645c8a317dd12e344b1c72a
# bad: [3c85f20a289d044f303f473ee6ab7502303fc3b0] Merge tag 'omapdrm-4.8' of git://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux into drm-next git bisect bad 3c85f20a289d044f303f473ee6ab7502303fc3b0
# bad: [a64424d722504926f3375bc4887976e3bfe3a01d] Merge branch 'drm-next-4.7' of git://people.freedesktop.org/~agd5f/linux into drm-next git bisect bad a64424d722504926f3375bc4887976e3bfe3a01d
# bad: [b5bf0f1ea3658254bd72ef64abc97786e8a32255] drm/exynos: clean up register definions for fimd and decon
git bisect bad b5bf0f1ea3658254bd72ef64abc97786e8a32255
# bad: [27878ede4fec7b929c3010710ba4d55c617c621d] drm/i915: Throw out BUGs from DPLL/PCH functions
git bisect bad 27878ede4fec7b929c3010710ba4d55c617c621d
# bad: [72341af4285ae1337c0dfdfa3e68318b52b8757c] drm/i915: hide away VBT private data in a separate header
git bisect bad 72341af4285ae1337c0dfdfa3e68318b52b8757c
# bad: [71f0a626143368b8aead361ffaff7e36d043fd8e] drm/i915: Only use sanitized values for ILK watermarks
git bisect bad 71f0a626143368b8aead361ffaff7e36d043fd8e
# bad: [66e2c4c39cc37beaccc24c9d14c75d627fce9cf4] drm/i915/gen9: Disable DC states if power well support is disabled
git bisect bad 66e2c4c39cc37beaccc24c9d14c75d627fce9cf4
# bad: [4f2d9934bd6ac73950832c96b385822846670668] drm/i915: Pass drm_frambuffer to intel_compute_page_offset()
git bisect bad 4f2d9934bd6ac73950832c96b385822846670668
# bad: [1d5bf5d9d9ef0c1e639d36178a224d83888c5a29] drm/i915: Add missing NULL check before calling initial_watermarks
git bisect bad 1d5bf5d9d9ef0c1e639d36178a224d83888c5a29
# bad: [d9f8e52b22454a30aaaf26b7ef029598b30abf8e] drm/i915: remove dead code
git bisect bad d9f8e52b22454a30aaaf26b7ef029598b30abf8e
# bad: [c3454d575da162cd310d9b83696baefb29d10a70] drm/i915: remove left over dead code
git bisect bad c3454d575da162cd310d9b83696baefb29d10a70
# bad: [ed4a6a7ca853253f9b86f3005d76345482a71283] drm/i915: Add two-stage ILK-style watermark programming (v11)
git bisect bad ed4a6a7ca853253f9b86f3005d76345482a71283

Quoted 1 line
# first bad commit: [ed4a6a7ca853253f9b86f3005d76345482a71283] drm/i915: Add two-stage ILK-style watermark programming (v11)
Quoted 2 lines

Nothing from the graphics developers? Come on, here is someone who found a specific patch that causes a problem, and no one responds?

Probably no one noticed the mail on account of the relevant lists not getting Cc:d from the get go. Sorry.

Quoted 3 lines

Why isn't this fixed by reverting the above mentioned patch in Linus's tree already? Or, is there something else that needs to be done?

IIRC the problems caused by that watermark stuff should have been fixed by some combination of these
9bd18728a3f2 ("drm/i915: Ignore stale wm register values on resume on ilk-bdw (v2)") 7045c3689f14 ("drm/i915: Don't leave old junk in ilk active watermarks on readout") d890565c4444 ("drm/i915: Use the active wm config for merging on ILK-BDW") f1ecaf8f9c99 ("drm/i915: Start WM computation from scratch on ILK-BDW")

so it's not quite clear if the bisect landed at the right spot, or if we have more than one overlapping regression around.

Please file a bug at
https://bugs.freedesktop.org/enter_bug.cgi?product=DRI&component=DRM/Intel
and attach the full dmesg from boot up to when you reproduced the problem. And pass drm.debug=0xe to kernel so that we'll get (hopefully) enough debug information into the log.

Trying the latest nightly tree from
git://anongit.freedesktop.org/drm-intel drm-intel-nightly would also be a good idea, in case we already fixed the problem.

Signature · 2 lines
Ville Syrjälä
Intel OTC
Quoted 6 lines
Quoted 4 lines

Hi,

Now I'm running a 4.8.4 kernel and the problem seems to be solved. So no need to file a bug report, right?

Ah, that's great, no need!

Yeah, 4.8 had a bunch of wm fallout because we're reworking that code and the freeze for the 4.8 merge window seemed to have hit a bad time. Bugfixes are slowly percolating through the system. I think the regression from Ted also has a big chance to be a similar issue.
-Daniel

Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#9 lore raw
In reply to Greg KH
Quoted 75 lines · Greg KH
Quoted 68 lines · Gaston Gonzalez
Quoted 12 lines · Greg KH
Quoted 10 lines · Gaston Gonzalez

Hi,

After hibernation I get the following error when I tried to connect to monitor through hdmi:

$ xrandr --output LVDS1 --off  --output  HDMI1 --auto
xrandr: Configure crtc 1 failed

This does not happen in kernel in kernel v4.6.7 but do happen in kernels v4.7.4 and v4.8.0

Quoted 8 lines

Ah, can you use 'git bisect' to track down the offending patch?

Also, if you let the graphics driver authors know, they are probably the best ones to help out with this, not the "generic" stable mailing list.

thanks,

greg k-h

Hello,

The culprit commit seems to be:

commit: ed4a6a7
drm/i915: Add two-stage ILK-style watermark programming

Attached the bisection log.

Let me know if additional test or bisect is needed.

Best regards,

Gaston

git bisect start '--' 'drivers/gpu/drm/'
# good: [096998b11906dd79df5af4d688c9974342dd09f2] Linux 4.6.7
git bisect good 096998b11906dd79df5af4d688c9974342dd09f2
# bad: [c8d2bc9bc39ebea8437fd974fdbc21847bb897a3] Linux 4.8
git bisect bad c8d2bc9bc39ebea8437fd974fdbc21847bb897a3
# good: [2dcd0af568b0cf583645c8a317dd12e344b1c72a] Linux 4.6
git bisect good 2dcd0af568b0cf583645c8a317dd12e344b1c72a
# bad: [3c85f20a289d044f303f473ee6ab7502303fc3b0] Merge tag 'omapdrm-4.8' of git://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux into drm-next git bisect bad 3c85f20a289d044f303f473ee6ab7502303fc3b0
# bad: [a64424d722504926f3375bc4887976e3bfe3a01d] Merge branch 'drm-next-4.7' of git://people.freedesktop.org/~agd5f/linux into drm-next git bisect bad a64424d722504926f3375bc4887976e3bfe3a01d
# bad: [b5bf0f1ea3658254bd72ef64abc97786e8a32255] drm/exynos: clean up register definions for fimd and decon
git bisect bad b5bf0f1ea3658254bd72ef64abc97786e8a32255
# bad: [27878ede4fec7b929c3010710ba4d55c617c621d] drm/i915: Throw out BUGs from DPLL/PCH functions
git bisect bad 27878ede4fec7b929c3010710ba4d55c617c621d
# bad: [72341af4285ae1337c0dfdfa3e68318b52b8757c] drm/i915: hide away VBT private data in a separate header
git bisect bad 72341af4285ae1337c0dfdfa3e68318b52b8757c
# bad: [71f0a626143368b8aead361ffaff7e36d043fd8e] drm/i915: Only use sanitized values for ILK watermarks
git bisect bad 71f0a626143368b8aead361ffaff7e36d043fd8e
# bad: [66e2c4c39cc37beaccc24c9d14c75d627fce9cf4] drm/i915/gen9: Disable DC states if power well support is disabled
git bisect bad 66e2c4c39cc37beaccc24c9d14c75d627fce9cf4
# bad: [4f2d9934bd6ac73950832c96b385822846670668] drm/i915: Pass drm_frambuffer to intel_compute_page_offset()
git bisect bad 4f2d9934bd6ac73950832c96b385822846670668
# bad: [1d5bf5d9d9ef0c1e639d36178a224d83888c5a29] drm/i915: Add missing NULL check before calling initial_watermarks
git bisect bad 1d5bf5d9d9ef0c1e639d36178a224d83888c5a29
# bad: [d9f8e52b22454a30aaaf26b7ef029598b30abf8e] drm/i915: remove dead code
git bisect bad d9f8e52b22454a30aaaf26b7ef029598b30abf8e
# bad: [c3454d575da162cd310d9b83696baefb29d10a70] drm/i915: remove left over dead code
git bisect bad c3454d575da162cd310d9b83696baefb29d10a70
# bad: [ed4a6a7ca853253f9b86f3005d76345482a71283] drm/i915: Add two-stage ILK-style watermark programming (v11)
git bisect bad ed4a6a7ca853253f9b86f3005d76345482a71283

Quoted 1 line
# first bad commit: [ed4a6a7ca853253f9b86f3005d76345482a71283] drm/i915: Add two-stage ILK-style watermark programming (v11)

Nothing from the graphics developers? Come on, here is someone who found a specific patch that causes a problem, and no one responds?

Quoted 6 lines

Why isn't this fixed by reverting the above mentioned patch in Linus's tree already? Or, is there something else that needs to be done?

thanks,

greg k-h

I was away for a couple months so I think I missed this thread when going through my backlog of emails, sorry. Is there a bugzilla filed for this already with logs and more details? If not, please add one at
[1] to help make sure this doesn't slip through the cracks. If you boot with "drm.debug=0xf" on the kernel command line, the output of your dmesg log would also help us identify what's happening here.

Thanks.

Matt

[1] https://bugs.freedesktop.org/enter_bug.cgi?product=DRI&component=DRM/Intel

Signature · 5 lines
Matt Roper
Graphics Software Engineer
IoTG Platform Enabling & Development
Intel Corporation
(916) 356-2795