Skip to contentSkip to conversation

ASoC: rl6347a: Use dev_err_once for I2C communication error prints

PATCH Mark Brown 2 participants 2 messages Oct 6, 2016 – Oct 7, 2016 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Mark Brown

author
#1 lore raw
Quoted 4 lines · Jarkko Nikula

It's difficult to guess from bunch of "ret=-121" errors what driver and device actually caused them. Since struct i2c_client has the dev pointer use that for dev_err_once() in order to see the device and not spam the log needlessly.

dev_err() is obviously an improvement (as would a better message be) but dev_err_once() seems like a big jump that we don't normally do for our I/O errors - transient errors do happen from time to time (especially when people get their power up sequences wrong) and it can be useful to know if something is just dead, failed gradually over time or just had a single transient error. It's also helpful since a lot of the errors that do occur result in long timeouts so it's not always clear that we're grinding through lots of I/Os if we don't say anything. Am I missing something about this case?

#2 lore raw
Quoted 7 lines · Mark Brown
Quoted 4 lines · Jarkko Nikula

It's difficult to guess from bunch of "ret=-121" errors what driver and device actually caused them. Since struct i2c_client has the dev pointer use that for dev_err_once() in order to see the device and not spam the log needlessly.

Quoted 10 lines

dev_err() is obviously an improvement (as would a better message be) but dev_err_once() seems like a big jump that we don't normally do for our I/O errors - transient errors do happen from time to time (especially when people get their power up sequences wrong) and it can be useful to know if something is just dead, failed gradually over time or just had a single transient error. It's also helpful since a lot of the errors that do occur result in long timeouts so it's not always clear that we're grinding through lots of I/Os if we don't say anything. Am I missing something about this case?

You are right. This looks like it is either due HW issue or pincontrol misconfiguration after resume and device starts making interrupt storm and acknowledging them fails before I2C is resumed. I switch it to dev_err().

Signature · 1 line
Jarkko