perf top: Fix refreshing hierarchy entries on TUI
Namhyung Kim
maintainerPATCH 1/1 perf top: Fix refreshing hierarchy entries on TUI
Markus reported that 'perf top --hierarchy' cannot scroll down after refresh. This was because the number of entries are not updated when hierarchy is enabled.
Unlike normal report view, hierarchy mode needs to keep its own entry count since it can have non-leaf entries which can expand/collapse.
Reported-and-tested-by Markus Trippelsdorf <[email protected]>
Fixes f5b763feebe9 ("perf hists browser: Count number of hierarchy entries")
Signed-off-by Namhyung Kim <[email protected]>
--- tools/perf/ui/browsers/hists.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
tools/perf/ui/browsers/hists.c +2 -1
@@ -601,7 +601,8 @@ int hist_browser__run(struct hist_browser *browser, const char *help)u64 nr_entries; hbt->timer (hbt->arg); -if (hist_browser__has_filter (browser)) +if (hist_browser__has_filter (browser) || + symbol_conf.report_hierarchy)hist_browser__update_nr_entries (browser); nr_entries =hist_browser__nr_entries (browser);
Signature · 1 line
2.9.3
tip-bot for Namhyung Kim
merge botperf top: Fix refreshing hierarchy entries on TUI
Commit-ID: c611152373e84a7677cd7d496e849de4debdab66 Gitweb: http://git.kernel.org/tip/c611152373e84a7677cd7d496e849de4debdab66 Author: Namhyung Kim <[email protected]> AuthorDate: Fri, 7 Oct 2016 14:04:12 +0900 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Thu, 13 Oct 2016 11:10:14 -0300
perf top: Fix refreshing hierarchy entries on TUI
Markus reported that 'perf top --hierarchy' cannot scroll down after refresh. This was because the number of entries are not updated when hierarchy is enabled.
Unlike normal report view, hierarchy mode needs to keep its own entry count since it can have non-leaf entries which can expand/collapse.
Reported-and-Tested-by Markus Trippelsdorf <[email protected]>
Signed-off-by Namhyung Kim <[email protected]>
Cc Andi Kleen <[email protected]>
Cc Jiri Olsa <[email protected]>
Cc Peter Zijlstra <[email protected]>
Fixes f5b763feebe9 ("perf hists browser: Count number of hierarchy entries")
Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
--- tools/perf/ui/browsers/hists.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
tools/perf/ui/browsers/hists.c +2 -1
@@ -601,7 +601,8 @@ int hist_browser__run(struct hist_browser *browser, const char *help)u64 nr_entries; hbt->timer (hbt->arg); -if (hist_browser__has_filter (browser)) +if (hist_browser__has_filter (browser) || + symbol_conf.report_hierarchy)hist_browser__update_nr_entries (browser); nr_entries =hist_browser__nr_entries (browser);