V2 /staging/dgnc/dgnc_neo.h. Lines less than 80 characters
PATCH 1/1 V2 /staging/dgnc/dgnc_neo.h. Lines less than 80 characters
Signed-off-by Keila Novo <[email protected]>
Version 2. Fix checkpatch "more than 80 characters per line"
Signed-off-by Keila Novo <[email protected]>
--- drivers/staging/dgnc/dgnc_neo.h | 35 +++++++++++++++++++---------------- 1 file changed, 19 insertions(+), 16 deletions(-)
drivers/staging/dgnc/dgnc_neo.h +19 -16
@@ -28,27 +28,27 @@************************************************************************/ struct neo_uart_struct { -u8 txrx;/* WR RHR/THR - Holding Reg */ +u8 txrx;/* WR RHR/THR - Holding Reg */ u8 ier;/* WR IER - Interrupt Enable Reg */ -u8 isr_fcr;/* WR ISR/FCR - Interrupt Status Reg/Fifo Control Reg */ +u8 isr_fcr;/* WR ISR/FCR - Interrupt Status Reg/Fifo Control Reg */ u8 lcr;/* WR LCR - Line Control Reg */ u8 mcr;/* WR MCR - Modem Control Reg */ u8 lsr;/* WR LSR - Line Status Reg */ u8 msr;/* WR MSR - Modem Status Reg */ u8 spr;/* WR SPR - Scratch Pad Reg */ -u8 fctr;/* WR FCTR - Feature Control Reg */ +u8 fctr;/* WR FCTR - Feature Control Reg */ u8 efr;/* WR EFR - Enhanced Function Reg */ -u8 tfifo;/* WR TXCNT/TXTRG - Transmit FIFO Reg */ -u8 rfifo;/* WR RXCNT/RXTRG - Receive FIFO Reg */ +u8 tfifo;/* WR TXCNT/TXTRG - Transmit FIFO Reg */ +u8 rfifo;/* WR RXCNT/RXTRG - Receive FIFO Reg */ u8 xoffchar1;/* WR XOFF 1 - XOff Character 1 Reg */ u8 xoffchar2;/* WR XOFF 2 - XOff Character 2 Reg */ u8 xonchar1;/* WR XON 1 - Xon Character 1 Reg */ u8 xonchar2;/* WR XON 2 - XOn Character 2 Reg */ u8 reserved1[0x2ff -0x200 ];/* U Reserved by Exar */ -u8 txrxburst[64 ];/* RW 64 bytes of RX/TX FIFO Data */ +u8 txrxburst[64 ];/* RW 64 bytes of RX/TX FIFO Data */ u8 reserved2[0x37f -0x340 ];/* U Reserved by Exar */ -u8 rxburst_with_errors[64 ];/* R 64 bytes of RX FIFO Data + LSR */ +u8 rxburst_with_errors[64 ];/* R 64 bytes of RX FIFO Data + LSR */ };/* Where to read the extended interrupt register (32bits instead of 8bits) */
@@ -108,19 +108,21 @@ struct neo_uart_struct {/* 17158 Extended IIR's */ #define UART_17158_IIR_RDI_TIMEOUT 0x0C/* Receiver data TIMEOUT */ #define UART_17158_IIR_XONXOFF 0x10/* Received an XON/XOFF char */ -#define UART_17158_IIR_HWFLOW_STATE_CHANGE 0x20/* CTS/DSR or RTS/DTR state change */ +#define UART_17158_IIR_HWFLOW_STATE_CHANGE 0x20 +/* CTS/DSR or RTS/DTR state change */ #define UART_17158_IIR_FIFO_ENABLED 0xC0/* 16550 FIFOs are Enabled */ /* * These are the extended interrupts that get sent * back to us from the UART's 32bit interrupt register */ -#define UART_17158_RX_LINE_STATUS 0x1/* RX Ready */ -#define UART_17158_RXRDY_TIMEOUT 0x2/* RX Ready Timeout */ -#define UART_17158_TXRDY 0x3/* TX Ready */ -#define UART_17158_MSR 0x4/* Modem State Change */ -#define UART_17158_TX_AND_FIFO_CLR 0x40/* Transmitter Holding Reg Empty */ -#define UART_17158_RX_FIFO_DATA_ERROR 0x80/* UART detected an RX FIFO Data error */ +#define UART_17158_RX_LINE_STATUS 0x1/* RX Ready */ +#define UART_17158_RXRDY_TIMEOUT 0x2/* RX Ready Timeout */ +#define UART_17158_TXRDY 0x3/* TX Ready */ +#define UART_17158_MSR 0x4/* Modem State Change */ +#define UART_17158_TX_AND_FIFO_CLR 0x40/* Transmitter Holding Reg Empty */ +#define UART_17158_RX_FIFO_DATA_ERROR 0x80 +/* UART detected an RX FIFO Data error */ /* * These are the EXTENDED definitions for the 17C158's Interrupt
@@ -132,8 +134,9 @@ struct neo_uart_struct {#define UART_17158_EFR_RTSDTR 0x40/* Auto RTS/DTR Flow Control Enable */ #define UART_17158_EFR_CTSDSR 0x80/* Auto CTS/DSR Flow COntrol Enable */ -#define UART_17158_XOFF_DETECT 0x1/* Indicates whether chip saw an incoming XOFF char */ -#define UART_17158_XON_DETECT 0x2/* Indicates whether chip saw an incoming XON char */ +#define UART_17158_XOFF_DETECT 0x1 +/*Indicates if chip saw incoming XOFF char */ +#define UART_17158_XON_DETECT 0x2/*Indicates if chip saw incoming XON char */ #define UART_17158_IER_RSVD1 0x10/* Reserved by Exar */ #define UART_17158_IER_XOFF 0x20/* Xoff Interrupt Enable */
Signature · 1 line
2.7.4
Greg Kroah-Hartman
maintainerQuoted 1 line · Keila
Signed-off-by Keila Novo <[email protected]>
Why did you put this as the first line?
Quoted 3 lines
Version 2. Fix checkpatch "more than 80 characters per line"
Why is "Version 2" in the changelog text here?
And look at your Subject:, it doesn't match other subjects for this driver, does it?
Quoted 11 lines
Signed-off-by Keila Novo <[email protected]>--- drivers/staging/dgnc/dgnc_neo.h | 35 +++++++++++++++++++---------------- 1 file changed, 19 insertions(+), 16 deletions(-)drivers/staging/dgnc/dgnc_neo.h +0
-0
drivers/staging/dgnc/dgnc_neo.h line 33
Quoted 8 lines
drivers/staging/dgnc/dgnc_neo.h +2
-2@@ -28,27 +28,27 @@************************************************************************/ struct neo_uart_struct { -u8 txrx;/* WR RHR/THR - Holding Reg */ +u8 txrx;/* WR RHR/THR - Holding Reg */ u8 ier;/* WR IER - Interrupt Enable Reg */ -u8 isr_fcr;/* WR ISR/FCR - Interrupt Status Reg/Fifo Control Reg */ +u8 isr_fcr;/* WR ISR/FCR - Interrupt Status Reg/Fifo Control Reg */
Why did you switch to using spaces? Things are now not lined up neatly :(
thanks,
greg k-h