Skip to contentSkip to conversation

Staging: vt6655: Replace byVT3253InitTab_RFMD with BYVT3253INITTAB_RFMD

PATCH In review Varsha Rao 2 participants 3 messages Oct 8, 2016 Staging

lore
Share & tools
lore

Varsha Rao

author
#0 lore raw

PATCH 1/1 Staging: vt6655: Replace byVT3253InitTab_RFMD with BYVT3253INITTAB_RFMD

This patch fixes the checkpatch issue of CamelCase by replacing byVT3253InitTab_RFMD with BYVT3253INITTAB_RFMD.

Avoid CamelCase: <byVT3253InitTab_RFMD>

Signed-off-by Varsha Rao <[email protected]>
---
 drivers/staging/vt6655/baseband.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/vt6655/baseband.c +3 -3
index aa57cfa..b66b854 100644
@@ -68,7 +68,7 @@
 /*---------------------  Static Variables  --------------------------*/
 
 #define CB_VT3253_INIT_FOR_RFMD 446
-static const unsigned char byVT3253InitTab_RFMD[CB_VT3253_INIT_FOR_RFMD][2] = {
+static const unsigned char BYVT3253INITTAB_RFMD[CB_VT3253_INIT_FOR_RFMD][2] = {
 	{0x00, 0x30},
 	{0x01, 0x00},
 	{0x02, 0x00},

@@ -2022,8 +2022,8 @@ bool BBbVT3253Init(struct vnt_private *priv)
 		if (byLocalID <= REV_ID_VT3253_A1) {
 			for (ii = 0; ii < CB_VT3253_INIT_FOR_RFMD; ii++)
 				bResult &= BBbWriteEmbedded(priv,
-					byVT3253InitTab_RFMD[ii][0],
-					byVT3253InitTab_RFMD[ii][1]);
+					BYVT3253INITTAB_RFMD[ii][0],
+					BYVT3253INITTAB_RFMD[ii][1]);
 
 		} else {
 			for (ii = 0; ii < CB_VT3253B0_INIT_FOR_RFMD; ii++)
Signature · 1 line
2.7.4
maintainer
#1 lore raw
Quoted 1 line · Varsha Rao

This patch fixes the checkpatch issue of CamelCase by replacing byVT3253InitTab_RFMD with BYVT3253INITTAB_RFMD.

Please wrap your changelog comments at 72 columns.

And why uppercase this variable? That's horrid to read now, right? Please read Documentation/CodingStyle for how to properly name variables (hint, upper-case-only is for #defines, not variables.

Quoted 2 lines

Avoid CamelCase: <byVT3253InitTab_RFMD>

What does that mean?

thanks,

greg k-h

author
#2 lore raw
Quoted 11 lines · gregkh
Quoted 1 line · Varsha Rao

This patch fixes the checkpatch issue of CamelCase by replacing

byVT3253InitTab_RFMD with BYVT3253INITTAB_RFMD.

Please wrap your changelog comments at 72 columns.

And why uppercase this variable? That's horrid to read now, right? Please read Documentation/CodingStyle for how to properly name variables (hint, upper-case-only is for #defines, not variables.

Yeah, it is.Sorry I will rectify it.

Quoted 6 lines
Quoted 3 lines

Avoid CamelCase: <byVT3253InitTab_RFMD>

What does that mean?

This tells about the checkpatch check which is fixed by this patch.

Quoted 5 lines

thanks,

greg k-h