pci_alloc_irq_vectors use in 8250_lpss.c
Hi Andy,
two comment on your ぱatch to add MSI support to the above driver.
First pci_alloc_irq_vectors gained a mandatory flags argument, so for MSI suport you now need to pass PCI_IRQ_MSI in flags for the code to work.
Second please make sure to always pair pci_alloc_irq_vectors with pci_free_irq_vectors on the remove path.
Thanks,
Christoph
Quoted 7 lines · Christoph Hellwig
Hi Andy,
two comment on your ぱatch to add MSI support to the above driver.
First
pci_alloc_irq_vectorsgained a mandatory flags argument, so for MSI suport you now need to passPCI_IRQ_MSIin flags for the code to work.
I will check this. Thanks for pointing to it.
Quoted 3 lines
Second please make sure to always pair
pci_alloc_irq_vectorswithpci_free_irq_vectorson the remove path.
For my opinion it should be done in PCI code since I'm using manageable resources. It's already done for all PCI API usually used at ->probe().
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 10 lines · Andy Shevchenko
Quoted 7 lines · Christoph Hellwig
Hi Andy,
two comment on your ぱatch to add MSI support to the above driver.
First
pci_alloc_irq_vectorsgained a mandatory flags argument, so for MSI suport you now need to passPCI_IRQ_MSIin flags for the code to work.I will check this. Thanks for pointing to it.
Yeah, this has to be amended.
Quoted 8 lines
Quoted 4 lines
Second please make sure to always pair
pci_alloc_irq_vectorswithpci_free_irq_vectorson the remove path.For my opinion it should be done in PCI code since I'm using manageable resources. It's already done for all PCI API usually used at ->probe().
Nothing is required to do until you don't use some specific code. If you plan extend *_free_*() function in the future, please, consider manageable resources and automatic releasing.
Signature · 2 lines
With Best Regards, Andy Shevchenko