dmaengine: mmp_tdma: select GENERIC_ALLOCATOR
PATCH 1/1 dmaengine: mmp_tdma: select GENERIC_ALLOCATOR
build testing on x86 revealed a missing dependency that leads to a link error:
drivers/dma/built-in.o: In function `mmp_tdma_prep_dma_cyclic':
mmp_tdma.c:(.text+0x9564): undefined reference to gen_pool_dma_alloc' drivers/dma/built-in.o: In function mmp_tdma_free_chan_resources':
mmp_tdma.c:(.text+0x9675): undefined reference to gen_pool_free' drivers/dma/built-in.o: In function mmp_tdma_probe':
mmp_tdma.c:(.text+0x9854): undefined reference to `of_gen_pool_get'
This adds a 'select' statement to the driver to get it to build cleanly.
--- drivers/dma/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/dma/Kconfig +1 -0
@@ -305,6 +305,7 @@ config MMP_TDMA bool "MMP Two-Channel DMA support" depends on ARCH_MMP || COMPILE_TEST select DMA_ENGINE + select GENERIC_ALLOCATOR select MMP_SRAM if ARCH_MMP help Support the MMP Two-Channel DMA engine.
Signature · 1 line
2.9.0
Quoted 10 lines · Arnd Bergmann
build testing on x86 revealed a missing dependency that leads to a link error:
drivers/dma/built-in.o: In function `mmp_tdma_prep_dma_cyclic':
mmp_tdma.c:(.text+0x9564): undefined reference togen_pool_dma_alloc' drivers/dma/built-in.o: In functionmmp_tdma_free_chan_resources':
mmp_tdma.c:(.text+0x9675): undefined reference togen_pool_free' drivers/dma/built-in.o: In functionmmp_tdma_probe':
mmp_tdma.c:(.text+0x9854): undefined reference to `of_gen_pool_get'This adds a 'select' statement to the driver to get it to build cleanly.
Hi Arnd,
I have already applied same change from Jérémy.
Quoted 21 lines
Signed-off-by Arnd Bergmann <[email protected]>--- drivers/dma/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/dma/Kconfig +1
-0@@ -305,6 +305,7 @@ config MMP_TDMA bool "MMP Two-Channel DMA support" depends on ARCH_MMP || COMPILE_TEST select DMA_ENGINE + select GENERIC_ALLOCATOR select MMP_SRAM if ARCH_MMP help Support the MMP Two-Channel DMA engine.Signature · 1 line
2.9.0
Signature · 1 line
~Vinod