Skip to contentSkip to conversation

typo in commit message

LTP Cyril Hrubis 3 participants 4 messages Oct 10, 2016

lore
Share & tools
lore
#1 lore raw
Quoted 7 lines · Cyril Hrubis

Hi!
I've did a confusing typo in commit:
https://github.com/linux-test-project/ltp/commit/ebfb34503c7928368043182a2ac7750e805c4911

There is no such thing as ppc32le of course, it should have been ppc64le. Is everyone OK with me force pushing with the simple change in the commit message?

I would strongly recommend against it. Once a commit has gone public to master, doing a force-push that rewrites history will break things for people.

thanks
-- PMM

#2 lore raw
In reply to Cyril Hrubis

----- Original Message -----

Quoted 5 lines

From: "Cyril Hrubis" <[email protected]>
To: [email protected]
Sent: Monday, 10 October, 2016 2:30:34 PM
Subject: [LTP] typo in commit message

Quoted 7 lines

Hi!
I've did a confusing typo in commit:
https://github.com/linux-test-project/ltp/commit/ebfb34503c7928368043182a2ac7750e805c4911

There is no such thing as ppc32le of course, it should have been ppc64le. Is everyone OK with me force pushing with the simple change in the commit message?

I would prefer to avoid force push, specially when we don't know how many people already cloned it.

How about we do a revert and apply fixed patch instead?

Regards,
Jan

Quoted 8 lines

--
Cyril Hrubis
[email protected]

--
Mailing list info: https://lists.linux.it/listinfo/ltp

#3 lore raw

Hi!

Quoted 1 line

How about we do a revert and apply fixed patch instead?

Sounds better, I will do that.

Signature · 2 lines
Cyril Hrubis
[email protected]