Skip to contentSkip to conversation

MAINTAINERS entry for ARM/CLKDEV SUPPORT

DISCUSSION Dan Carpenter 3 participants 5 messages Oct 10, 2016 – Oct 31, 2016

lore
Share & tools
lore
#0 lore raw

Hello Stephen Boyd,

The MAINTAINERS entry looks like this:

ARM/CLKDEV SUPPORT

M:      Russell King <[email protected]>
L:      linux-arm-kernel at lists.infradead.org (moderated for non-subscribers)
S:      Maintained
F:      arch/arm/include/asm/clkdev.h
F:      drivers/clk/clkdev.c

We removed arch/arm/include/asm/clkdev.h in 34d2f4d3a4d6a6b ('ARM: Use generic clkdev.h header'). Do you still need to be CC'd on the clkdev.c changes?

regards,
dan carpenter

#1 lore raw
Quoted 1 line · Dan Carpenter

Hello Stephen Boyd,

Okay, that's really not nice.

This is _not_ a question for Stephen. Stephen does _not_ co-maintain clkdev or the clk API, but co-maintains CCF. I've no idea why you are addressing this to Stephen when this is clearly a question for me to answer.

Quoted 10 lines

The MAINTAINERS entry looks like this:

ARM/CLKDEV SUPPORT

M:      Russell King <[email protected]>
L:      linux-arm-kernel at lists.infradead.org (moderated for non-subscribers)
S:      Maintained
F:      arch/arm/include/asm/clkdev.h
F:      drivers/clk/clkdev.c
Quoted 3 lines

We removed arch/arm/include/asm/clkdev.h in 34d2f4d3a4d6a6b ('ARM: Use generic clkdev.h header'). Do you still need to be CC'd on the clkdev.c changes?

Technically, it is redundant anyway, as I'm listed for all arch/arm changes. However, the maintainership of arch/arm and the maintainership of clkdev are separate, the explicit entry is quite right.

It's also right that it's retained, because if we stop using the generic clkdev.h header, I want to be copied on such a change, and this entry will allow checkpatch to list me as clkdev maintainer.

Signature · 3 lines
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
#2 lore raw
Quoted 10 lines · Russell King - ARM Linux
Quoted 1 line · Dan Carpenter

Hello Stephen Boyd,

Okay, that's really not nice.

This is _not_ a question for Stephen. Stephen does _not_ co-maintain clkdev or the clk API, but co-maintains CCF. I've no idea why you are addressing this to Stephen when this is clearly a question for me to answer.

Sorry, I didn't mean to offend. He's the one who deleted the clkdev.h file though so I thought he might know if it should still be listed or if it was gone for good.

The clkdev.c question was a throw away thing that occured to me before I hit send.

regards,
dan carpenter

#3 lore raw
Quoted 5 lines · Dan Carpenter
Quoted 4 lines · Russell King - ARM Linux
Quoted 1 line · Dan Carpenter

Hello Stephen Boyd,

Okay, that's really not nice.

Quoted 9 lines
Quoted 5 lines

This is _not_ a question for Stephen. Stephen does _not_ co-maintain clkdev or the clk API, but co-maintains CCF. I've no idea why you are addressing this to Stephen when this is clearly a question for me to answer.

Sorry, I didn't mean to offend. He's the one who deleted the clkdev.h file though so I thought he might know if it should still be listed or if it was gone for good.

Yes, the arm version isn't coming back. We should delete arch/arm/include/asm/clkdev.h from the maintainers file and perhaps replace it with the asm-generic one. But we can delete the generic file too once blackfin removes their clkdev.h header. That patch is still outstanding.

Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
#4 lore raw
Quoted 11 lines · Stephen Boyd
Quoted 10 lines · Dan Carpenter
Quoted 9 lines · Russell King - ARM Linux
Quoted 1 line · Dan Carpenter

Hello Stephen Boyd,

Okay, that's really not nice.

This is _not_ a question for Stephen. Stephen does _not_ co-maintain clkdev or the clk API, but co-maintains CCF. I've no idea why you are addressing this to Stephen when this is clearly a question for me to answer.

Quoted 8 lines
Quoted 4 lines

Sorry, I didn't mean to offend. He's the one who deleted the clkdev.h file though so I thought he might know if it should still be listed or if it was gone for good.

Yes, the arm version isn't coming back. We should delete arch/arm/include/asm/clkdev.h from the maintainers file and perhaps replace it with the asm-generic one.

I disagree. See my reply to the original mail for the reasons.

Signature · 3 lines
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.