Skip to contentSkip to conversation

Staging:greybus:arche-apb-ctrl: fixed some coding style issue

PATCH In review Nadim Almas 3 participants 6 messages Oct 11, 2016 – Oct 13, 2016

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging:greybus:arche-apb-ctrl: fixed some coding style issue

fixed trailing */ Block comments and 80 character line limit coding style issue

---

 drivers/staging/greybus/arche-apb-ctrl.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)
drivers/staging/greybus/arche-apb-ctrl.c +7 -3
index 70323aa..eeba912 100644
@@ -168,7 +168,10 @@ static int standby_boot_seq(struct platform_device *pdev)
 	if (apb->init_disabled)
 		return 0;
 
-	/* Even if it is in OFF state, then we do not want to change the state */
+	/*
+	 * Even if it is in OFF state,
+	 * then we do not want to change the state
+	 */
 	if (apb->state == ARCHE_PLATFORM_STATE_STANDBY ||
 			apb->state == ARCHE_PLATFORM_STATE_OFF)
 		return 0;
@@ -183,7 +186,7 @@ static int standby_boot_seq(struct platform_device *pdev)
 	 * Pasted from WDM spec,
 	 *  - A falling edge on POWEROFF_L is detected (a)
 	 *  - WDM enters standby mode, but no output signals are changed
-	 * */
+	 */
 
 	/* TODO: POWEROFF_L is input to WDM module  */
 	apb->state = ARCHE_PLATFORM_STATE_STANDBY;
@@ -286,7 +289,8 @@ static ssize_t state_store(struct device *dev,
 			return count;
 
 		/* First we want to make sure we power off everything
-		 * and then enter FW flashing state */
+		 * and then enter FW flashing state
+		 */
 		poweroff_seq(pdev);
 		ret = fw_flashing_seq(pdev);
 	} else {
Signature · 1 line
2.7.4
#1 lore raw
Quoted 4 lines · Nadim Almas

fixed trailing */ Block comments and 80 character line limit coding style issue

---

Someone else already sent this same patch in before you, sorry :(

#2 lore raw
Quoted 1 line

Someone else already sent this same patch in before you, sorry

But sir how can i come to know that Someone else already sent
particular patch before sending that particular patch

Quoted 7 lines · Greg KH
Quoted 4 lines · Nadim Almas

fixed trailing */ Block comments and 80 character line limit coding style issue

---

Someone else already sent this same patch in before you, sorry :(

#3 lore raw
Quoted 3 lines · Nadim Almas
Quoted 1 line

Someone else already sent this same patch in before you, sorry

But sir how can i come to know that Someone else already sent
particular patch before sending that particular patch

You can subscribe to the driverdev mailing list to see what othes are working on, and you can follow my staging-testing kernel branch in the staging.git tree. But sometimes you just get unlucky, lots of people are working on cleaning up staging drivers, people do the same work at the same time quite often, it's just part of the process.

Pick something else to work on, we have lots of things to do :)

thanks,

greg k-h

#4 lore raw
Quoted 7 lines · Greg KH

You can subscribe to the driverdev mailing list to see what othes are working on, and you can follow my staging-testing kernel branch in the staging.git tree. But sometimes you just get unlucky, lots of people are working on cleaning up staging drivers, people do the same work at the same time quite often, it's just part of the process.

Is this
(http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel)
the right page for subscribing?

Thanks.

#5 lore raw
Quoted 9 lines · Alexander Alemayhu
Quoted 7 lines · Greg KH

You can subscribe to the driverdev mailing list to see what othes are working on, and you can follow my staging-testing kernel branch in the staging.git tree. But sometimes you just get unlucky, lots of people are working on cleaning up staging drivers, people do the same work at the same time quite often, it's just part of the process.

Quoted 3 lines

Is this
(http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel)
the right page for subscribing?

Yes.

greg k-h