Skip to contentSkip to conversation

netfilter: nft_exthdr: fix error handling in nft_exthdr_init()

PATCH Applied Dan Carpenter 2 participants 2 messages Oct 12, 2016 – Oct 17, 2016

Subsystems (4)
Networking Network drivers Kernel janitors netfilter
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 netfilter: nft_exthdr: fix error handling in nft_exthdr_init()

"err" needs to be signed for the error handling to work.

Fixes 36b701fae12a ('netfilter: nf_tables: validate maximum value of u32 netlink attributes')
Signed-off-by Dan Carpenter <[email protected]>
net/netfilter/nft_exthdr.c +2 -1
index a84cf3d..47beb3a 100644
@@ -59,7 +59,8 @@ static int nft_exthdr_init(const struct nft_ctx *ctx,
 			   const struct nlattr * const tb[])
 {
 	struct nft_exthdr *priv = nft_expr_priv(expr);
-	u32 offset, len, err;
+	u32 offset, len;
+	int err;
 
 	if (tb[NFTA_EXTHDR_DREG] = NULL ||
 	    tb[NFTA_EXTHDR_TYPE] = NULL ||
maintainer Applied
#1 lore raw
Quoted 1 line · Dan Carpenter

"err" needs to be signed for the error handling to work.

Applied, thanks Dan.