rxrpc: Add IPv6 support
Hello David Howells,
The patch 75b54cb57ca3: "rxrpc: Add IPv6 support" from Sep 13, 2016, leads to the following static checker warning:
net/rxrpc/peer_object.c:196 rxrpc_assess_MTU_size() warn: 'dst' isn't an ERR_PTR
net/rxrpc/peer_object.c
193 fl6->fl6_dport = htons(7001);
194 fl6->fl6_sport = htons(7000);
195 dst = ip6_route_output(&init_net, NULL, fl6);
196 if (IS_ERR(dst)) {
^^^^^^^^^^^Maybe you want to check dst->error?
197 _leave(" [route err %ld]", PTR_ERR(dst));
198 return;
199 }
200 break;regards,
dan carpenter
Quoted 3 lines · Dan Carpenter
196 if (IS_ERR(dst)) { ^^^^^^^^^^^Maybe you want to check
dst->error?
Hmmm... Why don't I see this when I run checker, I wonder?
David
Quoted 8 lines · David Howells
Quoted 3 lines · Dan Carpenter
196 if (IS_ERR(dst)) { ^^^^^^^^^^^Maybe you want to check
dst->error?Hmmm... Why don't I see this when I run checker, I wonder?
I haven't released this one because people do all kinds of nonsense checks for IS_ERR() out of paranoia.
regards,
dan carpenter