tipc: info leak in __tipc_nl_add_udp_addr()

PATCH Applied Dan Carpenter 2 participants 2 messages Oct 13, 2016

Subsystems (4)

Networking Network drivers Kernel janitors TIPC network layer

lore

Share & tools

lore

Dan Carpenter

author

2016-10-13 08:06 UTC #0 lore raw

PATCH 1/1 tipc: info leak in __tipc_nl_add_udp_addr()

We should clear out the padding and unused struct members so that we don't expose stack information to userspace.

Fixes fdb3accc2c15 ('tipc: add the ability to get UDP options via netlink')

Signed-off-by Dan Carpenter <[email protected]>

---
This goes into the net tree.

net/tipc/udp_media.c +2 -0

index d80cd3f..78cab9c 100644
@@ -407,6 +407,7 @@ static int __tipc_nl_add_udp_addr(struct sk_buff *skb,
 	if (ntohs(addr->proto) = ETH_P_IP) {
 		struct sockaddr_in ip4;
 
+		memset(&ip4, 0, sizeof(ip4));
 		ip4.sin_family = AF_INET;
 		ip4.sin_port = addr->port;
 		ip4.sin_addr.s_addr = addr->ipv4.s_addr;

@@ -417,6 +418,7 @@ static int __tipc_nl_add_udp_addr(struct sk_buff *skb,
 	} else if (ntohs(addr->proto) = ETH_P_IPV6) {
 		struct sockaddr_in6 ip6;
 
+		memset(&ip6, 0, sizeof(ip6));
 		ip6.sin6_family = AF_INET6;
 		ip6.sin6_port  = addr->port;
 		memcpy(&ip6.sin6_addr, &addr->ipv6, sizeof(struct in6_addr));

David Miller

maintainer Applied

2016-10-13 16:10 UTC #1 lore raw

From: Dan Carpenter <[email protected]>
Date: Thu, 13 Oct 2016 11:06:06 +0300

Quoted 5 lines

We should clear out the padding and unused struct members so that we don't expose stack information to userspace.
Fixes fdb3accc2c15 ('tipc: add the ability to get UDP options via netlink')
Signed-off-by Dan Carpenter <[email protected]>

Applied, thanks.