Skip to contentSkip to conversation

Staging:ks7010:eap_packet: fixed 80 character line limit coding style issue

PATCH In review Nadim Almas 2 participants 3 messages Oct 13, 2016 – Oct 15, 2016 1 message not in the archive Staging

lore
Share & tools
lore

Nadim Almas

author
#0 lore raw

PATCH v2 1/1 Staging:ks7010:eap_packet: fixed 80 character line limit coding style issue

Fixed coding style issue

Signed-off-by Nadim Almas <[email protected]>

---
Changes in v2:
-Comment is taken from below line.

 drivers/staging/ks7010/eap_packet.h | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/staging/ks7010/eap_packet.h +4 -2
index df7f760..90432ff 100644
@@ -58,11 +58,13 @@ struct ieee802_1x_eapol_key {
 	 * encrypt the Key field; 64-bit NTP timestamp MAY be used here
 	 */
 	unsigned char replay_counter[IEEE8021X_REPLAY_COUNTER_LEN];
-	unsigned char key_iv[IEEE8021X_KEY_IV_LEN];	/* cryptographically random number */
+	unsigned char key_iv[IEEE8021X_KEY_IV_LEN];
+			/* cryptographically random number */
 	unsigned char key_index;	/*
 					 * key flag in the most significant bit:
 					 * 0 = broadcast (default key),
-					 * 1 = unicast (key mapping key); key index is in the
+					 * 1 = unicast (key mapping key); key
+					 * index is in the
 					 * 7 least significant bits
 					 */
 	/*

--
2.7.4

maintainer
#1 lore raw
Quoted 1 line · Nadim Almas

Fixed coding style issue

Why the indentation?

Quoted 5 lines
Signed-off-by Nadim Almas <[email protected]>

---
Changes in v2:
-Comment is taken from below line.

Huh?

Quoted 9 lines
 drivers/staging/ks7010/eap_packet.h | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/staging/ks7010/eap_packet.h +0 -0
index df7f760..90432ff 100644

drivers/staging/ks7010/eap_packet.h struct ieee802_1x_eapol_key { · line 62

Quoted 6 lines
drivers/staging/ks7010/eap_packet.h +2 -1
@@ -58,11 +58,13 @@ struct ieee802_1x_eapol_key {
 	 * encrypt the Key field; 64-bit NTP timestamp MAY be used here
 	 */
 	unsigned char replay_counter[IEEE8021X_REPLAY_COUNTER_LEN];
-	unsigned char key_iv[IEEE8021X_KEY_IV_LEN];	/* cryptographically random number */
+	unsigned char key_iv[IEEE8021X_KEY_IV_LEN];
+			/* cryptographically random number */

Again, you put this below the line, which is not ok at all. Does this seem to be the way you would normally read code?

greg k-h

maintainer
#3 lore raw
In reply to a message not in the archive
Quoted 1 line · Nadim Almas

So please tall me how to do?

I have already done so, but you seem to be ignoring my suggestions for some reason.

Also please do not post with html, the mailing lists reject it.

I recommend going and learning C better and getting experience on other projects before working on kernel code.

best of luck!

greg k-h