Skip to contentSkip to conversation

net: add bbr to config DEFAULT_TCP_CONG

PATCH In review Markus Trippelsdorf 3 participants 4 messages Oct 14, 2016

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Markus Trippelsdorf

author
#0 lore raw

PATCH 1/1 net: add bbr to config DEFAULT_TCP_CONG

While playing with BBR I noticed that it was missing in the list of possible config DEFAULT_TCP_CONG choices. Fixed thusly.

Signed-off-by Markus Trippelsdorf <[email protected]>
net/ipv4/Kconfig +1 -0
index 300b06888fdf..b54b3ca939db 100644
@@ -715,6 +715,7 @@ config DEFAULT_TCP_CONG
 	default "reno" if DEFAULT_RENO
 	default "dctcp" if DEFAULT_DCTCP
 	default "cdg" if DEFAULT_CDG
+	default "bbr" if DEFAULT_BBR
 	default "cubic"
 
 config TCP_MD5SIG
Signature · 1 line
Markus
#1 lore raw
Quoted 10 lines · Markus Trippelsdorf

While playing with BBR I noticed that it was missing in the list of possible config DEFAULT_TCP_CONG choices. Fixed thusly.

Signed-off-by Markus Trippelsdorf <[email protected]>
net/ipv4/Kconfig +0 -0
index 300b06888fdf..b54b3ca939db 100644

net/ipv4/Kconfig config DEFAULT_TCP_CONG · line 719

Quoted 5 lines
net/ipv4/Kconfig +1 -0
@@ -715,6 +715,7 @@ config DEFAULT_TCP_CONG
 	default "reno" if DEFAULT_RENO
 	default "dctcp" if DEFAULT_DCTCP
 	default "cdg" if DEFAULT_CDG
+	default "bbr" if DEFAULT_BBR
 	default "cubic"

Not sure if we want this at this moment.

BBR needs FQ packet scheduler, and this is not exactly trivial to achieve.

author
#2 lore raw
Quoted 19 lines · Eric Dumazet
Quoted 10 lines · Markus Trippelsdorf

While playing with BBR I noticed that it was missing in the list of possible config DEFAULT_TCP_CONG choices. Fixed thusly.

Signed-off-by Markus Trippelsdorf <[email protected]>
net/ipv4/Kconfig +0 -0
index 300b06888fdf..b54b3ca939db 100644

net/ipv4/Kconfig config DEFAULT_TCP_CONG · line 719

Quoted 5 lines
net/ipv4/Kconfig +1 -0
@@ -715,6 +715,7 @@ config DEFAULT_TCP_CONG
 	default "reno" if DEFAULT_RENO
 	default "dctcp" if DEFAULT_DCTCP
 	default "cdg" if DEFAULT_CDG
+	default "bbr" if DEFAULT_BBR
 	default "cubic"

Not sure if we want this at this moment.

Quoted 2 lines

BBR needs FQ packet scheduler, and this is not exactly trivial to achieve.

For a start, it could be automatically selected:

net/ipv4/Kconfig +2 -0
index 300b06888fdf..845d8d3e9e27 100644
@@ -642,6 +642,8 @@ config TCP_CONG_CDG
 
 config TCP_CONG_BBR
 	tristate "BBR TCP"
+	select NET_SCHED
+	select NET_SCH_FQ
 	default n
 	---help---
Signature · 1 line
Markus
maintainer
#3 lore raw

From: Markus Trippelsdorf <[email protected]>
Date: Fri, 14 Oct 2016 10:07:16 +0200

Quoted 20 lines · Eric Dumazet
Quoted 19 lines · Markus Trippelsdorf
Quoted 10 lines

While playing with BBR I noticed that it was missing in the list of possible config DEFAULT_TCP_CONG choices. Fixed thusly.

Signed-off-by Markus Trippelsdorf <[email protected]>
net/ipv4/Kconfig +0 -0
index 300b06888fdf..b54b3ca939db 100644

net/ipv4/Kconfig config DEFAULT_TCP_CONG · line 719

Quoted 5 lines
net/ipv4/Kconfig +1 -0
@@ -715,6 +715,7 @@ config DEFAULT_TCP_CONG
 	default "reno" if DEFAULT_RENO
 	default "dctcp" if DEFAULT_DCTCP
 	default "cdg" if DEFAULT_CDG
+	default "bbr" if DEFAULT_BBR
 	default "cubic"

Not sure if we want this at this moment.

Quoted 4 lines
Quoted 2 lines

BBR needs FQ packet scheduler, and this is not exactly trivial to achieve.

For a start, it could be automatically selected:

Right but FQ has to be properly enabled and configured as well.