Skip to contentSkip to conversation

staging: wilc1000: Remove unnecessary extern variables.

PATCH Superseded Elise Lennion 2 participants 3 messages Oct 15, 2016 Staging

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: wilc1000: Remove unnecessary extern variables.

The externs were removed because there are already declarations in wilc_wlan.h for them.

---
 drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c +0 -3
index fca96d3..a5e2d96 100644
@@ -90,9 +90,6 @@ static const struct wiphy_wowlan_support wowlan_support = {
 #define IS_MGMT_STATUS_SUCCES			0x040
 #define GET_PKT_OFFSET(a) (((a) >> 22) & 0x1ff)
 
-extern int wilc_mac_open(struct net_device *ndev);
-extern int wilc_mac_close(struct net_device *ndev);
-
 static struct network_info last_scanned_shadow[MAX_NUM_SCANNED_NETWORKS_SHADOW];
 static u32 last_scanned_cnt;
 struct timer_list wilc_during_ip_timer;
Signature · 1 line
2.7.4
#1 lore raw
Quoted 2 lines · Elise Lennion

The externs were removed because there are already declarations in wilc_wlan.h for them.

Are these functions actually used in more than one file?

julia

Quoted 30 lines
---
 drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c +0 -4
index fca96d3..a5e2d96 100644
@@ -90,9 +90,6 @@ static const struct wiphy_wowlan_support wowlan_support = {
 #define IS_MGMT_STATUS_SUCCES			0x040
 #define GET_PKT_OFFSET(a) (((a) >> 22) & 0x1ff)
 
-extern int wilc_mac_open(struct net_device *ndev);
-extern int wilc_mac_close(struct net_device *ndev);
-
 static struct network_info last_scanned_shadow[MAX_NUM_SCANNED_NETWORKS_SHADOW];
 static u32 last_scanned_cnt;
 struct timer_list wilc_during_ip_timer;
--

2.7.4

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20161015184643.GA2580%40lennorien.com.
For more options, visit https://groups.google.com/d/optout.

#2 lore raw
Quoted 8 lines · Julia Lawall
Quoted 2 lines · Elise Lennion

The externs were removed because there are already declarations in wilc_wlan.h for them.

Are these functions actually used in more than one file?

Actually not, I see that in this driver there are many extern variables that could be declared in a .c file as static.

elise

Quoted 3 lines

julia