Skip to contentSkip to conversation

Sayōnara, AM_MAINTAINER_MODE!

PATCH In review Michel Dänzer 2 participants 2 messages Oct 20, 2016 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Sayōnara, AM_MAINTAINER_MODE!

From: Michel Dänzer <[email protected]>

If --enable-maintainer-mode got lost from config.status for any reason, builds would fail in mysterious ways after changing between different Git commits.

There are more reasons for dropping it in the automake manual:

https://www.gnu.org/software/automake/manual/html_node/maintainer_002dmode.html

I'm not aware of any reason why --disable-maintainer-mode would ever be useful with this project.

---
 autogen.sh   | 2 +-
 configure.ac | 2 --
 2 files changed, 1 insertion(+), 3 deletions(-)
autogen.sh +1 -1
index b47abdc..fc34bd5 100755
@@ -10,5 +10,5 @@ autoreconf -v --install || exit 1
 cd $ORIGDIR || exit $?
 
 if test -z "$NOCONFIGURE"; then
-    $srcdir/configure --enable-maintainer-mode "$@"
+    $srcdir/configure "$@"
 fi
configure.ac +0 -2
index 8dc55d8..3fc967e 100644
@@ -36,8 +36,6 @@ AC_CONFIG_AUX_DIR(.)
 AM_INIT_AUTOMAKE([foreign dist-bzip2])
 AC_SYS_LARGEFILE
 
-AM_MAINTAINER_MODE
-
 # Require X.Org macros 1.8 or later for MAN_SUBSTS set by XORG_MANPAGE_SECTIONS
 m4_ifndef([XORG_MACROS_VERSION],
           [m4_fatal([must install xorg-macros 1.8 or later before running autoconf/autogen])])
Signature · 6 lines
2.9.3

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 20161020063737.23366-1-michel-otUistvHUpPR7s880joybQ@public.gmane.org

Reviewed-by Alex Deucher
#2 lore raw
Quoted 15 lines

-----Original Message-----
From: amd-gfx [mailto:[email protected]] On Behalf Of Michel Dänzer
Sent: Thursday, October 20, 2016 2:38 AM
To: [email protected]
Subject: [PATCH xf86-video-ati] Sayōnara, AM_MAINTAINER_MODE!

From: Michel Dänzer <[email protected]>

If --enable-maintainer-mode got lost from config.status for any reason, builds would fail in mysterious ways after changing between different Git commits.

There are more reasons for dropping it in the automake manual:

Quoted 7 lines

https://www.gnu.org/software/automake/manual/html_node/maintainer_
002dmode.html

I'm not aware of any reason why --disable-maintainer-mode would ever be useful with this project.

Glad to see it go.

Quoted 34 lines
---
 autogen.sh   | 2 +-
 configure.ac | 2 --
 2 files changed, 1 insertion(+), 3 deletions(-)
autogen.sh +1 -1
index b47abdc..fc34bd5 100755
@@ -10,5 +10,5 @@ autoreconf -v --install || exit 1
 cd $ORIGDIR || exit $?
 
 if test -z "$NOCONFIGURE"; then
-    $srcdir/configure --enable-maintainer-mode "$@"
+    $srcdir/configure "$@"
 fi
configure.ac +0 -2
index 8dc55d8..3fc967e 100644
@@ -36,8 +36,6 @@ AC_CONFIG_AUX_DIR(.)
 AM_INIT_AUTOMAKE([foreign dist-bzip2])
 AC_SYS_LARGEFILE
 
-AM_MAINTAINER_MODE
-
 # Require X.Org macros 1.8 or later for MAN_SUBSTS set by

XORG_MANPAGE_SECTIONS
m4_ifndef([XORG_MACROS_VERSION],
[m4_fatal([must install xorg-macros 1.8 or later before running
autoconf/autogen])])
--
2.9.3

Quoted 4 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx