Staging:wlan-ng:hfa384x: fixed 80 character line limit coding style issue

PATCH In review Nadim Almas 2 participants 2 messages Oct 21, 2016 – Oct 25, 2016 Staging

lore

Share & tools

lore

Nadim Almas

author

2016-10-21 12:42 UTC #0 lore raw

PATCH 1/1 Staging:wlan-ng:hfa384x: fixed 80 character line limit coding style issue

Fixed coding style issue

Signed-off-by Nadim Almas <[email protected]>

---
 drivers/staging/wlan-ng/hfa384x.h | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

drivers/staging/wlan-ng/hfa384x.h +6 -2

index 6337b1d..cca2652 100644
@@ -1349,7 +1349,9 @@ struct hfa384x {
 						  * interface
 						  */
 
-	struct hfa384x_caplevel cap_act_sta_mfi; /* sta f/w to modem interface */
+	struct hfa384x_caplevel cap_act_sta_mfi; /*
+						  * sta f/w to modem interface
+						  */
 
 	struct hfa384x_caplevel cap_act_ap_cfi;	/*
 						 * ap f/w to controller

@@ -1371,7 +1373,9 @@ struct hfa384x {
 
 	struct hfa384x_inf_frame *scanresults;
 
-	struct prism2sta_authlist authlist;	/* Authenticated station list. */
+	struct prism2sta_authlist authlist;	/*
+						 * Authenticated station list
+						 */
 	unsigned int accessmode;		/* Access mode. */
 	struct prism2sta_accesslist allow;	/* Allowed station list. */
 	struct prism2sta_accesslist deny;	/* Denied station list. */

Signature · 1 line

2.7.4

Greg KH

maintainer

2016-10-25 08:48 UTC #1 lore raw

Quoted 23 lines · Nadim Almas

Fixed coding style issue

Signed-off-by Nadim Almas <[email protected]>

---
 drivers/staging/wlan-ng/hfa384x.h | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

drivers/staging/wlan-ng/hfa384x.h +3 -1

index 6337b1d..cca2652 100644
@@ -1349,7 +1349,9 @@ struct hfa384x {
 						  * interface
 						  */
 
-	struct hfa384x_caplevel cap_act_sta_mfi; /* sta f/w to modem interface */
+	struct hfa384x_caplevel cap_act_sta_mfi; /*
+						  * sta f/w to modem interface
+						  */
 
 	struct hfa384x_caplevel cap_act_ap_cfi;	/*
 						 * ap f/w to controller

drivers/staging/wlan-ng/hfa384x.h struct hfa384x { · line 1378

Quoted 7 lines

drivers/staging/wlan-ng/hfa384x.h +3 -1

@@ -1371,7 +1373,9 @@ struct hfa384x {
 
 	struct hfa384x_inf_frame *scanresults;
 
-	struct prism2sta_authlist authlist;	/* Authenticated station list. */
+	struct prism2sta_authlist authlist;	/*
+						 * Authenticated station list
+						 */

These changes really don't make things more readable, do they? Put the comment above the variable if you really care, or just don't worry about the 1 or 2 characters over the line-length limit here.

thanks,

greg k-h