Skip to contentSkip to conversation

ARM: dts: witherspoon: add Epson RX8900CE RTC module

PATCH Superseded Chris Smart 2 participants 4 messages Oct 26, 2016 – Oct 27, 2016

Subsystems (2)
Device tree bindings Arm/Aspeed machine support
lore
Share & tools
lore

Chris Smart

author
#0 lore raw

PATCH v2 1/1 ARM: dts: witherspoon: add Epson RX8900CE RTC module

This commit adds the relevant device tree entry for the Epson RX8900CE RTC module on the I2C bus.

Note that there are two options that we may need to set.

If there is no connected battery:
epson,vdet-disable;

If there is no trickle charge diode:
epson,vdet-disable;

These are currently left commented out in the commit.

Signed-off-by Chris Smart <[email protected]>

---

Changes since v1:
- fixed up the entry for rtc@32

arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts | 12 ++++++++++++

1 file changed, 12 insertions(+)
arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts +0 -0
index 328a9c4e189e..19a91a207530 100644
@@ -148,7 +148,19 @@
 

	/* TPM */
	/* 9552 */
+
	/* RTC */

+ rtc@32 {
+ compatible = "epson,rx8900"
+ reg = <0x32>;
+ /*
+ * If no battery, set this:
+ * epson,vdet-disable;
+ * If no trickle charge diode, set this:
+ * epson,vdet-disable;
+ */
+ };
+

	/* EEPROM */

	eeprom@51 {
Signature · 1 line
2.9.3
maintainer
#1 lore raw

Hey Chris,

Review

Quoted 4 lines · Chris Smart
        /* RTC */
(quoted diff) +3 -0
+       rtc@32 {
+               compatible = "epson,rx8900"
+               reg = <0x32>;

Did you try building this?

Cheers,

Joel

author
#2 lore raw
Quoted 10 lines · Joel Stanley

Hey Chris,

Review

Quoted 4 lines · Chris Smart
        /* RTC */
(quoted diff) +3 -0
+       rtc@32 {
+               compatible = "epson,rx8900"
+               reg = <0x32>;

Did you try building this?

My bad, v3 incoming.

-c

author
#3 lore raw

PATCH v3 1/1 ARM: dts: witherspoon: add Epson RX8900CE RTC module

In reply to Chris Smart

This commit adds the relevant device tree entry for the Epson RX8900CE RTC module on the I2C bus.

Note that there are two options that we may need to set.

If there is no connected battery:
epson,vdet-disable;

If there is no trickle charge diode:
epson,vdet-disable;

These are currently left commented out in the commit.

Signed-off-by Chris Smart <[email protected]>

---

Changes since v1:
- fixed up the entry for rtc@32

Changes since v2:
- fix up code formatting

Tested with kernel config from openbmc meta-ast2500 yocto, compiled with:

ARCH=arm CROSS_COMPILE=arm-linux-gnu- make -j$(nproc) dtbs

arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts | 12 ++++++++++++

1 file changed, 12 insertions(+)
arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts +0 -0
index 328a9c4e189e..2972c6279183 100644
@@ -148,7 +148,19 @@
 

	/* TPM */
	/* 9552 */
+
	/* RTC */

+ rtc@32 {
+ compatible = "epson,rx8900";
+ reg = <0x32>;
+ /*
+ * If no battery, set this:
+ * epson,vdet-disable;
+ * If no trickle charge diode, set this:
+ * epson,vdet-disable;
+ */
+ };
+

	/* EEPROM */

	eeprom@51 {
Signature · 1 line
2.9.3