Skip to contentSkip to conversation

stk1160: Check whether to use AC97 codec or internal ADC.

PATCH New Marcel Hasler 1 participant 1 message Oct 27, 2016

Subsystems (2)
Media (V4L/DVB) STK1160 USB video capture driver
lore
Share & tools
lore

Marcel Hasler

author
#0 lore raw

PATCH 2/2 stk1160: Check whether to use AC97 codec or internal ADC.

Some STK1160-based devices use the chip's internal 8-bit ADC. This is configured through a strap pin. The value of this and other pins can be read through the POSVA register. If the internal ADC is used, there's no point trying to setup the unavailable AC97 codec.

Signed-off-by Marcel Hasler <[email protected]>
---
 drivers/media/usb/stk1160/stk1160-ac97.c | 15 +++++++++++++++
 drivers/media/usb/stk1160/stk1160-core.c |  3 +--
 drivers/media/usb/stk1160/stk1160-reg.h  |  3 +++
 3 files changed, 19 insertions(+), 2 deletions(-)
drivers/media/usb/stk1160/stk1160-ac97.c +15 -0
index d3665ce..0199fad 100644
@@ -90,8 +90,23 @@ void stk1160_ac97_dump_regs(struct stk1160 *dev)
 }
 #endif
 
+int stk1160_has_ac97(struct stk1160 *dev)
+{
+	u8 value;
+
+	stk1160_read_reg(dev, STK1160_POSVA, &value);
+
+	/* Bit 2 high means internal ADC */
+	return !(value & 0x04);
+}
+
 void stk1160_ac97_setup(struct stk1160 *dev)
 {
+	if (!stk1160_has_ac97(dev)) {
+		stk1160_dbg("Device uses internal ADC, skipping AC97 setup.");
+		return;
+	}
+
 	/* Two-step reset AC97 interface and hardware codec */
 	stk1160_write_reg(dev, STK1160_AC97CTL_0, 0x94);
 	stk1160_write_reg(dev, STK1160_AC97CTL_0, 0x8c);
drivers/media/usb/stk1160/stk1160-core.c +1 -2
index f3c9b8a..c86eb61 100644
@@ -20,8 +20,7 @@
  *
  * TODO:
  *
- * 1. (Try to) detect if we must register ac97 mixer
- * 2. Support stream at lower speed: lower frame rate or lower frame size.
+ * 1. Support stream at lower speed: lower frame rate or lower frame size.
  *
  */
drivers/media/usb/stk1160/stk1160-reg.h +3 -0
index 81ff3a1..a4ab586 100644
@@ -26,6 +26,9 @@
 /* Remote Wakup Control */
 #define STK1160_RMCTL			0x00c
 
+/* Power-on Strapping Data */
+#define STK1160_POSVA			0x010
+
 /*
  * Decoder Control Register:
  * This byte controls capture start/stop
Signature · 1 line
2.10.1