Skip to contentSkip to conversation

cmake.bbclass: Exclude native sysroot from CMAKE_FIND_ROOT_PATH

PATCH In review Khem Raj 3 participants 11 messages Oct 29, 2016 – Nov 5, 2016

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/1 cmake.bbclass: Exclude native sysroot from CMAKE_FIND_ROOT_PATH

This has been cause of issue where we were getting both usr/include dirs ( from target as well as native sysroot) added to compiler flags.

CXX_INCLUDES in final flags.cmake would include -I<target-sysroot>/usr/include -I<native-sysroot>/usr/include most of the time it would work since headers are mostly common but netflix package failed to compile since one of the headers was including curl headers which it could not find in target sysroot and it went to next include path and found it in native sysroot which is not what we want when doing cross compile.

As per https://cmake.org/Wiki/CMake_Cross_Compiling
never search for programs in target sysroot but search for packages,libs,includes only.

---
 meta/classes/cmake.bbclass | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta/classes/cmake.bbclass +2 -1
index 3e762de..3e8df37 100644
@@ -25,6 +25,7 @@ OECMAKE_PERLNATIVE_DIR ??= ""
 OECMAKE_EXTRA_ROOT_PATH ?= ""
 
 OECMAKE_FIND_ROOT_PATH_MODE_PROGRAM = "ONLY"
+OECMAKE_FIND_ROOT_PATH_MODE_PROGRAM_class-target = "NEVER"
 OECMAKE_FIND_ROOT_PATH_MODE_PROGRAM_class-native = "BOTH"
 
 EXTRA_OECMAKE_append = " ${PACKAGECONFIG_CONFARGS}"
@@ -60,7 +61,7 @@ set( CMAKE_CXX_LINK_FLAGS "${OECMAKE_CXX_LINK_FLAGS}" CACHE STRING "LDFLAGS" )
 
 # only search in the paths provided so cmake doesnt pick
 # up libraries and tools from the native build machine
-set( CMAKE_FIND_ROOT_PATH ${STAGING_DIR_HOST} ${STAGING_DIR_NATIVE} ${CROSS_DIR} ${OECMAKE_PERLNATIVE_DIR} ${OECMAKE_EXTRA_ROOT_PATH} ${EXTERNAL_TOOLCHAIN})
+set( CMAKE_FIND_ROOT_PATH ${STAGING_DIR_HOST} ${CROSS_DIR} ${OECMAKE_PERLNATIVE_DIR} ${OECMAKE_EXTRA_ROOT_PATH} ${EXTERNAL_TOOLCHAIN})
 set( CMAKE_FIND_ROOT_PATH_MODE_PACKAGE ONLY )
 set( CMAKE_FIND_ROOT_PATH_MODE_PROGRAM ${OECMAKE_FIND_ROOT_PATH_MODE_PROGRAM} )
 set( CMAKE_FIND_ROOT_PATH_MODE_LIBRARY ONLY )
Signature · 1 line
2.10.1
#1 lore raw
Quoted 27 lines · Khem Raj

This has been cause of issue where we were getting both usr/include dirs ( from target as well as native sysroot) added to compiler flags.

CXX_INCLUDES in final flags.cmake would include -I<target-sysroot>/usr/include -I<native-sysroot>/usr/include most of the time it would work since headers are mostly common but netflix package failed to compile since one of the headers was including curl headers which it could not find in target sysroot and it went to next include path and found it in native sysroot which is not what we want when doing cross compile.

As per https://cmake.org/Wiki/CMake_Cross_Compiling
never search for programs in target sysroot but search for packages,libs,includes only.

---
 meta/classes/cmake.bbclass | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta/classes/cmake.bbclass +0 -0
index 3e762de..3e8df37 100644

meta/classes/cmake.bbclass OECMAKE_PERLNATIVE_DIR ??= "" · line 28

Quoted 4 lines
meta/classes/cmake.bbclass +1 -0
@@ -25,6 +25,7 @@ OECMAKE_PERLNATIVE_DIR ??= ""
 OECMAKE_EXTRA_ROOT_PATH ?= ""
 
 OECMAKE_FIND_ROOT_PATH_MODE_PROGRAM = "ONLY"
+OECMAKE_FIND_ROOT_PATH_MODE_PROGRAM_class-target = "NEVER"

^ Split this into a second patch please you are changing two more or less unrelated settings in one patch.

meta/classes/cmake.bbclass set( CMAKE_CXX_LINK_FLAGS "${OECMAKE_CXX_LINK_FLAGS}" CACHE STRING "LDFLAGS" ) · line 64

Quoted 9 lines
meta/classes/cmake.bbclass +1 -1
 OECMAKE_FIND_ROOT_PATH_MODE_PROGRAM_class-native = "BOTH"
 
 EXTRA_OECMAKE_append = " ${PACKAGECONFIG_CONFARGS}"
@@ -60,7 +61,7 @@ set( CMAKE_CXX_LINK_FLAGS "${OECMAKE_CXX_LINK_FLAGS}" CACHE STRING "LDFLAGS" )
 
 # only search in the paths provided so cmake doesnt pick
 # up libraries and tools from the native build machine
-set( CMAKE_FIND_ROOT_PATH ${STAGING_DIR_HOST} ${STAGING_DIR_NATIVE} ${CROSS_DIR} ${OECMAKE_PERLNATIVE_DIR} ${OECMAKE_EXTRA_ROOT_PATH} ${EXTERNAL_TOOLCHAIN})
+set( CMAKE_FIND_ROOT_PATH ${STAGING_DIR_HOST} ${CROSS_DIR} ${OECMAKE_PERLNATIVE_DIR} ${OECMAKE_EXTRA_ROOT_PATH} ${EXTERNAL_TOOLCHAIN})

^ Are you sure this doesn't break native builds? I am a bit scared: In meta-qt5-extra I have lot's of native builds for build-helpers. KDE guys seem to prefer this over shell scripts...

Andreas

author
#2 lore raw
Quoted 30 lines · Andreas Müller
Quoted 29 lines · Khem Raj

This has been cause of issue where we were getting both usr/include dirs ( from target as well as native sysroot) added to compiler flags.

CXX_INCLUDES in final flags.cmake would include -I<target-sysroot>/usr/include -I<native-sysroot>/usr/include most of the time it would work since headers are mostly common but netflix package failed to compile since one of the headers was including curl headers which it could not find in target sysroot and it went to next include path and found it in native sysroot which is not what we want when doing cross compile.

As per https://cmake.org/Wiki/CMake_Cross_Compiling
never search for programs in target sysroot but search for packages,libs,includes only.

---
 meta/classes/cmake.bbclass | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta/classes/cmake.bbclass +0 -0
index 3e762de..3e8df37 100644
@@ -25,6 +25,7 @@ OECMAKE_PERLNATIVE_DIR ??= ""
 OECMAKE_EXTRA_ROOT_PATH ?= ""
 
Quoted 4 lines

meta/classes/cmake.bbclass OECMAKE_PERLNATIVE_DIR ??= "" · line 28

Quoted 2 lines
meta/classes/cmake.bbclass +1 -0
 OECMAKE_FIND_ROOT_PATH_MODE_PROGRAM = "ONLY"
+OECMAKE_FIND_ROOT_PATH_MODE_PROGRAM_class-target = "NEVER"

^ Split this into a second patch please you are changing two more or less unrelated settings in one patch.

These changes are related and should stay together in same patch otherwise it will break.

Quoted 5 lines
Quoted 5 lines
meta/classes/cmake.bbclass +0 -0
 OECMAKE_FIND_ROOT_PATH_MODE_PROGRAM_class-native = "BOTH"
 
 EXTRA_OECMAKE_append = " ${PACKAGECONFIG_CONFARGS}"
@@ -60,7 +61,7 @@ set( CMAKE_CXX_LINK_FLAGS "${OECMAKE_CXX_LINK_FLAGS}" CACHE STRING "LDFLAGS" )
 
Quoted 7 lines

meta/classes/cmake.bbclass set( CMAKE_CXX_LINK_FLAGS "${OECMAKE_CXX_LINK_FLAGS}" CACHE STRING "LDFLAGS" ) · line 64

Quoted 4 lines
meta/classes/cmake.bbclass +1 -1
 # only search in the paths provided so cmake doesnt pick
 # up libraries and tools from the native build machine
-set( CMAKE_FIND_ROOT_PATH ${STAGING_DIR_HOST} ${STAGING_DIR_NATIVE} ${CROSS_DIR} ${OECMAKE_PERLNATIVE_DIR} ${OECMAKE_EXTRA_ROOT_PATH} ${EXTERNAL_TOOLCHAIN})
+set( CMAKE_FIND_ROOT_PATH ${STAGING_DIR_HOST} ${CROSS_DIR} ${OECMAKE_PERLNATIVE_DIR} ${OECMAKE_EXTRA_ROOT_PATH} ${EXTERNAL_TOOLCHAIN})

^ Are you sure this doesn't break native builds? I am a bit scared: In meta-qt5-extra I have lot's of native builds for build-helpers. KDE guys seem to prefer this over shell scripts...

It hasnt broken anything for my world builds thus far. I dont use meta-qt5-extras though. So testing help is welcome.

#3 lore raw
Quoted 53 lines · Khem Raj
Quoted 30 lines · Andreas Müller
Quoted 29 lines · Khem Raj

This has been cause of issue where we were getting both usr/include dirs ( from target as well as native sysroot) added to compiler flags.

CXX_INCLUDES in final flags.cmake would include -I<target-sysroot>/usr/include -I<native-sysroot>/usr/include most of the time it would work since headers are mostly common but netflix package failed to compile since one of the headers was including curl headers which it could not find in target sysroot and it went to next include path and found it in native sysroot which is not what we want when doing cross compile.

As per https://cmake.org/Wiki/CMake_Cross_Compiling
never search for programs in target sysroot but search for packages,libs,includes only.

---
 meta/classes/cmake.bbclass | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta/classes/cmake.bbclass +0 -0
index 3e762de..3e8df37 100644
@@ -25,6 +25,7 @@ OECMAKE_PERLNATIVE_DIR ??= ""
 OECMAKE_EXTRA_ROOT_PATH ?= ""
 
Quoted 4 lines

meta/classes/cmake.bbclass OECMAKE_PERLNATIVE_DIR ??= "" · line 28

Quoted 2 lines
meta/classes/cmake.bbclass +1 -0
 OECMAKE_FIND_ROOT_PATH_MODE_PROGRAM = "ONLY"
+OECMAKE_FIND_ROOT_PATH_MODE_PROGRAM_class-target = "NEVER"

^ Split this into a second patch please you are changing two more or less unrelated settings in one patch.

These changes are related and should stay together in same patch otherwise it will break.

Quoted 5 lines
Quoted 5 lines
meta/classes/cmake.bbclass +0 -0
 OECMAKE_FIND_ROOT_PATH_MODE_PROGRAM_class-native = "BOTH"
 
 EXTRA_OECMAKE_append = " ${PACKAGECONFIG_CONFARGS}"
@@ -60,7 +61,7 @@ set( CMAKE_CXX_LINK_FLAGS "${OECMAKE_CXX_LINK_FLAGS}" CACHE STRING "LDFLAGS" )
 
Quoted 7 lines

meta/classes/cmake.bbclass set( CMAKE_CXX_LINK_FLAGS "${OECMAKE_CXX_LINK_FLAGS}" CACHE STRING "LDFLAGS" ) · line 64

Quoted 4 lines
meta/classes/cmake.bbclass +1 -1
 # only search in the paths provided so cmake doesnt pick
 # up libraries and tools from the native build machine
-set( CMAKE_FIND_ROOT_PATH ${STAGING_DIR_HOST} ${STAGING_DIR_NATIVE} ${CROSS_DIR} ${OECMAKE_PERLNATIVE_DIR} ${OECMAKE_EXTRA_ROOT_PATH} ${EXTERNAL_TOOLCHAIN})
+set( CMAKE_FIND_ROOT_PATH ${STAGING_DIR_HOST} ${CROSS_DIR} ${OECMAKE_PERLNATIVE_DIR} ${OECMAKE_EXTRA_ROOT_PATH} ${EXTERNAL_TOOLCHAIN})

^ Are you sure this doesn't break native builds? I am a bit scared: In meta-qt5-extra I have lot's of native builds for build-helpers. KDE guys seem to prefer this over shell scripts...

Quoted 2 lines

It hasnt broken anything for my world builds thus far. I dont use meta-qt5-extras though. So testing help is welcome.

I'll give it a meta-qt5-extra world build and let you know

Andreas

#4 lore raw
Quoted 54 lines · Andreas Müller
Quoted 53 lines · Khem Raj
Quoted 30 lines · Andreas Müller
Quoted 29 lines · Khem Raj

This has been cause of issue where we were getting both usr/include dirs ( from target as well as native sysroot) added to compiler flags.

CXX_INCLUDES in final flags.cmake would include -I<target-sysroot>/usr/include -I<native-sysroot>/usr/include most of the time it would work since headers are mostly common but netflix package failed to compile since one of the headers was including curl headers which it could not find in target sysroot and it went to next include path and found it in native sysroot which is not what we want when doing cross compile.

As per https://cmake.org/Wiki/CMake_Cross_Compiling
never search for programs in target sysroot but search for packages,libs,includes only.

---
 meta/classes/cmake.bbclass | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta/classes/cmake.bbclass +0 -0
index 3e762de..3e8df37 100644
@@ -25,6 +25,7 @@ OECMAKE_PERLNATIVE_DIR ??= ""
 OECMAKE_EXTRA_ROOT_PATH ?= ""
 
Quoted 4 lines

meta/classes/cmake.bbclass OECMAKE_PERLNATIVE_DIR ??= "" · line 28

Quoted 2 lines
meta/classes/cmake.bbclass +1 -0
 OECMAKE_FIND_ROOT_PATH_MODE_PROGRAM = "ONLY"
+OECMAKE_FIND_ROOT_PATH_MODE_PROGRAM_class-target = "NEVER"

^ Split this into a second patch please you are changing two more or less unrelated settings in one patch.

These changes are related and should stay together in same patch otherwise it will break.

Quoted 12 lines

meta/classes/cmake.bbclass set( CMAKE_CXX_LINK_FLAGS "${OECMAKE_CXX_LINK_FLAGS}" CACHE STRING "LDFLAGS" ) · line 64

Quoted 9 lines
meta/classes/cmake.bbclass +1 -1
 OECMAKE_FIND_ROOT_PATH_MODE_PROGRAM_class-native = "BOTH"
 
 EXTRA_OECMAKE_append = " ${PACKAGECONFIG_CONFARGS}"
@@ -60,7 +61,7 @@ set( CMAKE_CXX_LINK_FLAGS "${OECMAKE_CXX_LINK_FLAGS}" CACHE STRING "LDFLAGS" )
 
 # only search in the paths provided so cmake doesnt pick
 # up libraries and tools from the native build machine
-set( CMAKE_FIND_ROOT_PATH ${STAGING_DIR_HOST} ${STAGING_DIR_NATIVE} ${CROSS_DIR} ${OECMAKE_PERLNATIVE_DIR} ${OECMAKE_EXTRA_ROOT_PATH} ${EXTERNAL_TOOLCHAIN})
+set( CMAKE_FIND_ROOT_PATH ${STAGING_DIR_HOST} ${CROSS_DIR} ${OECMAKE_PERLNATIVE_DIR} ${OECMAKE_EXTRA_ROOT_PATH} ${EXTERNAL_TOOLCHAIN})

^ Are you sure this doesn't break native builds? I am a bit scared: In meta-qt5-extra I have lot's of native builds for build-helpers. KDE guys seem to prefer this over shell scripts...

Quoted 4 lines
Quoted 2 lines

It hasnt broken anything for my world builds thus far. I dont use meta-qt5-extras though. So testing help is welcome.

I'll give it a meta-qt5-extra world build and let you know

Huge fallout:

/home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/karchive/karchive.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier2/kdoctools/kdoctools-native.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/kwindowsystem/kwindowsystem.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/kcodecs/kcodecs.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/kconfig/kconfig.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/kguiaddons/kguiaddons.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/kdbusaddons/kdbusaddons.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/kitemviews/kitemviews.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/attica/attica.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/sonnet/sonnet.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/kcoreaddons/kcoreaddons-native.bb:do_compile /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/kidletime/kidletime.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/kwayland/kwayland.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-lxqt/libqtxdg/libqtxdg_git.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/threadweaver/threadweaver.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/networkmanager-qt/networkmanager-qt.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/kdnssd/kdnssd.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/modemmanager-qt/modemmanager-qt.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-misc/recipes-multimedia/projectm/projectm_git.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/kplotting/kplotting.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/breeze-icons/breeze-icons.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-lxqt/compton-conf/compton-conf_git.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-lxqt/qterminal/qterminal_git.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-lxqt/obconf-qt/obconf-qt_git.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-misc/recipes-multimedia/mixxx/mixxx_git.bb:do_compile

so please don't apply this one

Andreas

author
#5 lore raw
Quoted 93 lines · Andreas Müller
Quoted 54 lines · Andreas Müller
Quoted 53 lines · Khem Raj
Quoted 30 lines · Andreas Müller
Quoted 29 lines · Khem Raj

This has been cause of issue where we were getting both usr/include dirs ( from target as well as native sysroot) added to compiler flags.

CXX_INCLUDES in final flags.cmake would include -I<target-sysroot>/usr/include -I<native-sysroot>/usr/include most of the time it would work since headers are mostly common but netflix package failed to compile since one of the headers was including curl headers which it could not find in target sysroot and it went to next include path and found it in native sysroot which is not what we want when doing cross compile.

As per https://cmake.org/Wiki/CMake_Cross_Compiling
never search for programs in target sysroot but search for packages,libs,includes only.

---
meta/classes/cmake.bbclass | 3 ++-

1 file changed, 2 insertions(+), 1 deletion(-)
meta/classes/cmake.bbclass +0 -0
index 3e762de..3e8df37 100644
@@ -25,6 +25,7 @@ OECMAKE_PERLNATIVE_DIR ??= ""

OECMAKE_EXTRA_ROOT_PATH ?= ""

Quoted 4 lines
Quoted 2 lines

OECMAKE_FIND_ROOT_PATH_MODE_PROGRAM = "ONLY" +OECMAKE_FIND_ROOT_PATH_MODE_PROGRAM_class-target = "NEVER"

^ Split this into a second patch please you are changing two more or less unrelated settings in one patch.

These changes are related and should stay together in same patch otherwise it will break.

Quoted 12 lines

meta/classes/cmake.bbclass set( CMAKE_CXX_LINK_FLAGS "${OECMAKE_CXX_LINK_FLAGS}" CACHE STRING "LDFLAGS" ) · line 64

Quoted 9 lines

OECMAKE_FIND_ROOT_PATH_MODE_PROGRAM_class-native = "BOTH"

EXTRA_OECMAKE_append = " ${PACKAGECONFIG_CONFARGS}"

meta/classes/cmake.bbclass +1 -1
@@ -60,7 +61,7 @@ set( CMAKE_CXX_LINK_FLAGS "${OECMAKE_CXX_LINK_FLAGS}" CACHE STRING "LDFLAGS" )
 
 # only search in the paths provided so cmake doesnt pick
 # up libraries and tools from the native build machine
-set( CMAKE_FIND_ROOT_PATH ${STAGING_DIR_HOST} ${STAGING_DIR_NATIVE} ${CROSS_DIR} ${OECMAKE_PERLNATIVE_DIR} ${OECMAKE_EXTRA_ROOT_PATH} ${EXTERNAL_TOOLCHAIN})
+set( CMAKE_FIND_ROOT_PATH ${STAGING_DIR_HOST} ${CROSS_DIR} ${OECMAKE_PERLNATIVE_DIR} ${OECMAKE_EXTRA_ROOT_PATH} ${EXTERNAL_TOOLCHAIN})

^ Are you sure this doesn't break native builds? I am a bit scared: In meta-qt5-extra I have lot's of native builds for build-helpers. KDE guys seem to prefer this over shell scripts...

Quoted 4 lines
Quoted 2 lines

It hasnt broken anything for my world builds thus far. I dont use meta-qt5-extras though. So testing help is welcome.

I'll give it a meta-qt5-extra world build and let you know

Huge fallout:

/home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/karchive/karchive.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier2/kdoctools/kdoctools-native.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/kwindowsystem/kwindowsystem.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/kcodecs/kcodecs.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/kconfig/kconfig.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/kguiaddons/kguiaddons.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/kdbusaddons/kdbusaddons.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/kitemviews/kitemviews.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/attica/attica.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/sonnet/sonnet.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/kcoreaddons/kcoreaddons-native.bb:do_compile /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/kidletime/kidletime.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/kwayland/kwayland.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-lxqt/libqtxdg/libqtxdg_git.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/threadweaver/threadweaver.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/networkmanager-qt/networkmanager-qt.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/kdnssd/kdnssd.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/modemmanager-qt/modemmanager-qt.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-misc/recipes-multimedia/projectm/projectm_git.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/kplotting/kplotting.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/breeze-icons/breeze-icons.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-lxqt/compton-conf/compton-conf_git.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-lxqt/qterminal/qterminal_git.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-lxqt/obconf-qt/obconf-qt_git.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-misc/recipes-multimedia/mixxx/mixxx_git.bb:do_compile

Quoted 1 line

so please don't apply this one

Not yet, but specify both native includedir and target includedir while building something is broken at core that must be fixed in anycase. May be these fallouts are just latent issues that were papered over in past. Can you upload the logs somewhere ?

Quoted 2 lines

Andreas

#6 lore raw
Quoted 93 lines · Khem Raj
Quoted 93 lines · Andreas Müller
Quoted 54 lines · Andreas Müller
Quoted 53 lines · Khem Raj
Quoted 30 lines · Andreas Müller
Quoted 29 lines · Khem Raj

This has been cause of issue where we were getting both usr/include dirs ( from target as well as native sysroot) added to compiler flags.

CXX_INCLUDES in final flags.cmake would include -I<target-sysroot>/usr/include -I<native-sysroot>/usr/include most of the time it would work since headers are mostly common but netflix package failed to compile since one of the headers was including curl headers which it could not find in target sysroot and it went to next include path and found it in native sysroot which is not what we want when doing cross compile.

As per https://cmake.org/Wiki/CMake_Cross_Compiling
never search for programs in target sysroot but search for packages,libs,includes only.

---
meta/classes/cmake.bbclass | 3 ++-

1 file changed, 2 insertions(+), 1 deletion(-)
meta/classes/cmake.bbclass +0 -0
index 3e762de..3e8df37 100644
@@ -25,6 +25,7 @@ OECMAKE_PERLNATIVE_DIR ??= ""

OECMAKE_EXTRA_ROOT_PATH ?= ""

Quoted 4 lines
Quoted 2 lines

OECMAKE_FIND_ROOT_PATH_MODE_PROGRAM = "ONLY" +OECMAKE_FIND_ROOT_PATH_MODE_PROGRAM_class-target = "NEVER"

^ Split this into a second patch please you are changing two more or less unrelated settings in one patch.

These changes are related and should stay together in same patch otherwise it will break.

Quoted 12 lines

meta/classes/cmake.bbclass set( CMAKE_CXX_LINK_FLAGS "${OECMAKE_CXX_LINK_FLAGS}" CACHE STRING "LDFLAGS" ) · line 64

Quoted 9 lines

OECMAKE_FIND_ROOT_PATH_MODE_PROGRAM_class-native = "BOTH"

EXTRA_OECMAKE_append = " ${PACKAGECONFIG_CONFARGS}"

meta/classes/cmake.bbclass +1 -1
@@ -60,7 +61,7 @@ set( CMAKE_CXX_LINK_FLAGS "${OECMAKE_CXX_LINK_FLAGS}" CACHE STRING "LDFLAGS" )
 
 # only search in the paths provided so cmake doesnt pick
 # up libraries and tools from the native build machine
-set( CMAKE_FIND_ROOT_PATH ${STAGING_DIR_HOST} ${STAGING_DIR_NATIVE} ${CROSS_DIR} ${OECMAKE_PERLNATIVE_DIR} ${OECMAKE_EXTRA_ROOT_PATH} ${EXTERNAL_TOOLCHAIN})
+set( CMAKE_FIND_ROOT_PATH ${STAGING_DIR_HOST} ${CROSS_DIR} ${OECMAKE_PERLNATIVE_DIR} ${OECMAKE_EXTRA_ROOT_PATH} ${EXTERNAL_TOOLCHAIN})

^ Are you sure this doesn't break native builds? I am a bit scared: In meta-qt5-extra I have lot's of native builds for build-helpers. KDE guys seem to prefer this over shell scripts...

Quoted 4 lines
Quoted 2 lines

It hasnt broken anything for my world builds thus far. I dont use meta-qt5-extras though. So testing help is welcome.

I'll give it a meta-qt5-extra world build and let you know

Huge fallout:

/home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/karchive/karchive.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier2/kdoctools/kdoctools-native.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/kwindowsystem/kwindowsystem.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/kcodecs/kcodecs.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/kconfig/kconfig.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/kguiaddons/kguiaddons.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/kdbusaddons/kdbusaddons.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/kitemviews/kitemviews.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/attica/attica.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/sonnet/sonnet.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/kcoreaddons/kcoreaddons-native.bb:do_compile /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/kidletime/kidletime.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/kwayland/kwayland.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-lxqt/libqtxdg/libqtxdg_git.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/threadweaver/threadweaver.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/networkmanager-qt/networkmanager-qt.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/kdnssd/kdnssd.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/modemmanager-qt/modemmanager-qt.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-misc/recipes-multimedia/projectm/projectm_git.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/kplotting/kplotting.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/breeze-icons/breeze-icons.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-lxqt/compton-conf/compton-conf_git.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-lxqt/qterminal/qterminal_git.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-lxqt/obconf-qt/obconf-qt_git.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-misc/recipes-multimedia/mixxx/mixxx_git.bb:do_compile

Quoted 6 lines
Quoted 1 line

so please don't apply this one

Not yet, but specify both native includedir and target includedir while building something is broken at core that must be fixed in anycase. May be these fallouts are just latent issues that were papered over in past. Can you upload the logs somewhere ?

Sorry I killed them - my harddisk is not able to keep much more than 2 tmpdirs and I lost 1 day for this test already. I think the problem is that you want to kill references to includedir but you kill all references even those to native binaries addressed and required by cmake. These native binaries cannot be addressed anymore without searching in native sysroot and there is nothing wrong about it.

Andreas

#7 lore raw
Quoted 100 lines · Andreas Müller
Quoted 93 lines · Khem Raj
Quoted 93 lines · Andreas Müller
Quoted 54 lines · Andreas Müller
Quoted 53 lines · Khem Raj
Quoted 30 lines · Andreas Müller
Quoted 29 lines · Khem Raj

This has been cause of issue where we were getting both usr/include dirs ( from target as well as native sysroot) added to compiler flags.

CXX_INCLUDES in final flags.cmake would include -I<target-sysroot>/usr/include -I<native-sysroot>/usr/include most of the time it would work since headers are mostly common but netflix package failed to compile since one of the headers was including curl headers which it could not find in target sysroot and it went to next include path and found it in native sysroot which is not what we want when doing cross compile.

As per https://cmake.org/Wiki/CMake_Cross_Compiling
never search for programs in target sysroot but search for packages,libs,includes only.

---
meta/classes/cmake.bbclass | 3 ++-

1 file changed, 2 insertions(+), 1 deletion(-)
meta/classes/cmake.bbclass +0 -0
index 3e762de..3e8df37 100644
@@ -25,6 +25,7 @@ OECMAKE_PERLNATIVE_DIR ??= ""

OECMAKE_EXTRA_ROOT_PATH ?= ""

Quoted 4 lines
Quoted 2 lines

OECMAKE_FIND_ROOT_PATH_MODE_PROGRAM = "ONLY" +OECMAKE_FIND_ROOT_PATH_MODE_PROGRAM_class-target = "NEVER"

^ Split this into a second patch please you are changing two more or less unrelated settings in one patch.

These changes are related and should stay together in same patch otherwise it will break.

Quoted 12 lines

meta/classes/cmake.bbclass set( CMAKE_CXX_LINK_FLAGS "${OECMAKE_CXX_LINK_FLAGS}" CACHE STRING "LDFLAGS" ) · line 64

Quoted 9 lines

OECMAKE_FIND_ROOT_PATH_MODE_PROGRAM_class-native = "BOTH"

EXTRA_OECMAKE_append = " ${PACKAGECONFIG_CONFARGS}"

meta/classes/cmake.bbclass +1 -1
@@ -60,7 +61,7 @@ set( CMAKE_CXX_LINK_FLAGS "${OECMAKE_CXX_LINK_FLAGS}" CACHE STRING "LDFLAGS" )
 
 # only search in the paths provided so cmake doesnt pick
 # up libraries and tools from the native build machine
-set( CMAKE_FIND_ROOT_PATH ${STAGING_DIR_HOST} ${STAGING_DIR_NATIVE} ${CROSS_DIR} ${OECMAKE_PERLNATIVE_DIR} ${OECMAKE_EXTRA_ROOT_PATH} ${EXTERNAL_TOOLCHAIN})
+set( CMAKE_FIND_ROOT_PATH ${STAGING_DIR_HOST} ${CROSS_DIR} ${OECMAKE_PERLNATIVE_DIR} ${OECMAKE_EXTRA_ROOT_PATH} ${EXTERNAL_TOOLCHAIN})

^ Are you sure this doesn't break native builds? I am a bit scared: In meta-qt5-extra I have lot's of native builds for build-helpers. KDE guys seem to prefer this over shell scripts...

Quoted 4 lines
Quoted 2 lines

It hasnt broken anything for my world builds thus far. I dont use meta-qt5-extras though. So testing help is welcome.

I'll give it a meta-qt5-extra world build and let you know

Huge fallout:

/home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/karchive/karchive.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier2/kdoctools/kdoctools-native.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/kwindowsystem/kwindowsystem.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/kcodecs/kcodecs.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/kconfig/kconfig.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/kguiaddons/kguiaddons.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/kdbusaddons/kdbusaddons.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/kitemviews/kitemviews.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/attica/attica.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/sonnet/sonnet.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/kcoreaddons/kcoreaddons-native.bb:do_compile /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/kidletime/kidletime.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/kwayland/kwayland.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-lxqt/libqtxdg/libqtxdg_git.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/threadweaver/threadweaver.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/networkmanager-qt/networkmanager-qt.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/kdnssd/kdnssd.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/modemmanager-qt/modemmanager-qt.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-misc/recipes-multimedia/projectm/projectm_git.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/kplotting/kplotting.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-kde/kf5/tier1/breeze-icons/breeze-icons.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-lxqt/compton-conf/compton-conf_git.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-lxqt/qterminal/qterminal_git.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-lxqt/obconf-qt/obconf-qt_git.bb:do_configure /home/superandy/data/oe-core/sources/meta-qt5-extra/recipes-misc/recipes-multimedia/mixxx/mixxx_git.bb:do_compile

Quoted 6 lines
Quoted 1 line

so please don't apply this one

Not yet, but specify both native includedir and target includedir while building something is broken at core that must be fixed in anycase. May be these fallouts are just latent issues that were papered over in past. Can you upload the logs somewhere ?

Quoted 6 lines

Sorry I killed them - my harddisk is not able to keep much more than 2 tmpdirs and I lost 1 day for this test already. I think the problem is that you want to kill references to includedir but you kill all references even those to native binaries addressed and required by cmake. These native binaries cannot be addressed anymore without searching in native sysroot and there is nothing wrong about it.

I was not precise enough: replace native binaries by native executables.

Andreas

#8 lore raw
In reply to Khem Raj
Quoted 27 lines · Khem Raj

This has been cause of issue where we were getting both usr/include dirs ( from target as well as native sysroot) added to compiler flags.

CXX_INCLUDES in final flags.cmake would include -I<target-sysroot>/usr/include -I<native-sysroot>/usr/include most of the time it would work since headers are mostly common but netflix package failed to compile since one of the headers was including curl headers which it could not find in target sysroot and it went to next include path and found it in native sysroot which is not what we want when doing cross compile.

As per https://cmake.org/Wiki/CMake_Cross_Compiling
never search for programs in target sysroot but search for packages,libs,includes only.

---
 meta/classes/cmake.bbclass | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta/classes/cmake.bbclass +0 -0
index 3e762de..3e8df37 100644

meta/classes/cmake.bbclass OECMAKE_PERLNATIVE_DIR ??= "" · line 28

Quoted 4 lines
meta/classes/cmake.bbclass +1 -0
@@ -25,6 +25,7 @@ OECMAKE_PERLNATIVE_DIR ??= ""
 OECMAKE_EXTRA_ROOT_PATH ?= ""
 
 OECMAKE_FIND_ROOT_PATH_MODE_PROGRAM = "ONLY"
+OECMAKE_FIND_ROOT_PATH_MODE_PROGRAM_class-target = "NEVER"

Using the _class-target over-ride looks odd. Perhaps making "NEVER" the default and adding over-rides for the classes which need "ONLY" (if there are any?) would make this clearer?

Quoted 20 lines
meta/classes/cmake.bbclass +1 -2
 OECMAKE_FIND_ROOT_PATH_MODE_PROGRAM_class-native = "BOTH"
 
 EXTRA_OECMAKE_append = " ${PACKAGECONFIG_CONFARGS}"
@@ -60,7 +61,7 @@ set( CMAKE_CXX_LINK_FLAGS "${OECMAKE_CXX_LINK_FLAGS}" CACHE STRING "LDFLAGS" )
 
 # only search in the paths provided so cmake doesnt pick
 # up libraries and tools from the native build machine
-set( CMAKE_FIND_ROOT_PATH ${STAGING_DIR_HOST} ${STAGING_DIR_NATIVE} ${CROSS_DIR} ${OECMAKE_PERLNATIVE_DIR} ${OECMAKE_EXTRA_ROOT_PATH} ${EXTERNAL_TOOLCHAIN})
+set( CMAKE_FIND_ROOT_PATH ${STAGING_DIR_HOST} ${CROSS_DIR} ${OECMAKE_PERLNATIVE_DIR} ${OECMAKE_EXTRA_ROOT_PATH} ${EXTERNAL_TOOLCHAIN})
 set( CMAKE_FIND_ROOT_PATH_MODE_PACKAGE ONLY )
 set( CMAKE_FIND_ROOT_PATH_MODE_PROGRAM ${OECMAKE_FIND_ROOT_PATH_MODE_PROGRAM} )
 set( CMAKE_FIND_ROOT_PATH_MODE_LIBRARY ONLY )
--

2.10.1

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

author
#9 lore raw
Quoted 31 lines · Andre McCurdy
Quoted 29 lines · Khem Raj

This has been cause of issue where we were getting both usr/include dirs ( from target as well as native sysroot) added to compiler flags.

CXX_INCLUDES in final flags.cmake would include -I<target-sysroot>/usr/include -I<native-sysroot>/usr/include most of the time it would work since headers are mostly common but netflix package failed to compile since one of the headers was including curl headers which it could not find in target sysroot and it went to next include path and found it in native sysroot which is not what we want when doing cross compile.

As per https://cmake.org/Wiki/CMake_Cross_Compiling
never search for programs in target sysroot but search for packages,libs,includes only.

---
 meta/classes/cmake.bbclass | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta/classes/cmake.bbclass +0 -0
index 3e762de..3e8df37 100644
@@ -25,6 +25,7 @@ OECMAKE_PERLNATIVE_DIR ??= ""
 OECMAKE_EXTRA_ROOT_PATH ?= ""
 
Quoted 7 lines

meta/classes/cmake.bbclass OECMAKE_PERLNATIVE_DIR ??= "" · line 28

Quoted 2 lines
meta/classes/cmake.bbclass +1 -0
 OECMAKE_FIND_ROOT_PATH_MODE_PROGRAM = "ONLY"
+OECMAKE_FIND_ROOT_PATH_MODE_PROGRAM_class-target = "NEVER"

Using the _class-target over-ride looks odd. Perhaps making "NEVER" the default and adding over-rides for the classes which need "ONLY" (if there are any?) would make this clearer?

Yeah I plan to rework this a bit in that direction

Quoted 4 lines

meta/classes/cmake.bbclass set( CMAKE_CXX_LINK_FLAGS "${OECMAKE_CXX_LINK_FLAGS}"

Quoted 4 lines
meta/classes/cmake.bbclass +0 -0
 OECMAKE_FIND_ROOT_PATH_MODE_PROGRAM_class-native = "BOTH"
 
 EXTRA_OECMAKE_append = " ${PACKAGECONFIG_CONFARGS}"
@@ -60,7 +61,7 @@ set( CMAKE_CXX_LINK_FLAGS "${OECMAKE_CXX_LINK_FLAGS}"

CACHE STRING "LDFLAGS" )

Quoted 4 lines

meta/classes/cmake.bbclass set( CMAKE_CXX_LINK_FLAGS "${OECMAKE_CXX_LINK_FLAGS}" CACHE STRING "LDFLAGS" )

Quoted 4 lines
meta/classes/cmake.bbclass +0 -1
 # only search in the paths provided so cmake doesnt pick
 # up libraries and tools from the native build machine
-set( CMAKE_FIND_ROOT_PATH ${STAGING_DIR_HOST} ${STAGING_DIR_NATIVE}

${CROSS_DIR} ${OECMAKE_PERLNATIVE_DIR} ${OECMAKE_EXTRA_ROOT_PATH} ${EXTERNAL_TOOLCHAIN})

Quoted 1 line

meta/classes/cmake.bbclass set( CMAKE_CXX_LINK_FLAGS "${OECMAKE_CXX_LINK_FLAGS}" · line 63

Quoted 1 line
meta/classes/cmake.bbclass +1 -0
+set( CMAKE_FIND_ROOT_PATH ${STAGING_DIR_HOST} ${CROSS_DIR}

${OECMAKE_PERLNATIVE_DIR} ${OECMAKE_EXTRA_ROOT_PATH} ${EXTERNAL_TOOLCHAIN})

Quoted 2 lines

meta/classes/cmake.bbclass set( CMAKE_CXX_LINK_FLAGS "${OECMAKE_CXX_LINK_FLAGS}" · line 65

Quoted 2 lines
meta/classes/cmake.bbclass +0 -0
 set( CMAKE_FIND_ROOT_PATH_MODE_PACKAGE ONLY )
 set( CMAKE_FIND_ROOT_PATH_MODE_PROGRAM

${OECMAKE_FIND_ROOT_PATH_MODE_PROGRAM} )

Quoted 9 lines
Quoted 9 lines
meta/classes/cmake.bbclass +0 -1
 set( CMAKE_FIND_ROOT_PATH_MODE_LIBRARY ONLY )
--

2.10.1

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

author
#10 lore raw
Quoted 42 lines · Khem Raj
Quoted 2 lines · On Nov 1, 2016 11:28 AM, "Andre McCurdy" <[email protected]…

On Sat, Oct 29, 2016 at 1:47 AM, Khem Raj <[email protected]

Quoted 29 lines · <mailto:[email protected]>> wrote:
Quoted 29 lines

This has been cause of issue where we were getting both usr/include dirs ( from target as well as native sysroot) added to compiler flags.

CXX_INCLUDES in final flags.cmake would include -I<target-sysroot>/usr/include -I<native-sysroot>/usr/include most of the time it would work since headers are mostly common but netflix package failed to compile since one of the headers was including curl headers which it could not find in target sysroot and it went to next include path and found it in native sysroot which is not what we want when doing cross compile.

As per https://cmake.org/Wiki/CMake_Cross_Compiling
never search for programs in target sysroot but search for packages,libs,includes only.

Signed-off-by Khem Raj <[email protected] <mailto:[email protected]>>
---
 meta/classes/cmake.bbclass | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta/classes/cmake.bbclass +0 -0
index 3e762de..3e8df37 100644
@@ -25,6 +25,7 @@ OECMAKE_PERLNATIVE_DIR ??= ""
 OECMAKE_EXTRA_ROOT_PATH ?= ""
 
Quoted 7 lines

meta/classes/cmake.bbclass OECMAKE_PERLNATIVE_DIR ??= "" · line 28

Quoted 2 lines
meta/classes/cmake.bbclass +1 -0
 OECMAKE_FIND_ROOT_PATH_MODE_PROGRAM = "ONLY"
+OECMAKE_FIND_ROOT_PATH_MODE_PROGRAM_class-target = "NEVER"

Using the _class-target over-ride looks odd. Perhaps making "NEVER" the default and adding over-rides for the classes which need "ONLY" (if there are any?) would make this clearer?

Quoted 1 line

Yeah I plan to rework this a bit in that direction

thinking a bit more about this problem. It doesn't seem to be solvable with the current limitations that we have for cross compiling with cmake in OE environment.

What we want is

1. When compiling target packages that we should be able to use binaries and programs from native sysroot but not libraries, packages and includes

This is not possible since for this we have to add both native and target sysroots to CMAKE_FIND_ROOT_PATH, but there is no fine grained selection method for expressive the requirement 1 above. We only have options ONLY - Look for files only in paths specified in CMAKE_FIND_ROOT_PATH BOTH - Along with above also look into build hosts root dir NEVER - Only look for files in build hosts root dir

so we can not set CMAKE_FIND_ROOT_PATH dynamically according to MODE variables and hence the problem persists.

cmake does not cater to OE usecase where we have native sysroot along with host to complement native packages. It only assumes there is build host and the target sysroot.

Quoted 27 lines
Quoted 4 lines

meta/classes/cmake.bbclass set( CMAKE_CXX_LINK_FLAGS "${OECMAKE_CXX_LINK_FLAGS}"

Quoted 4 lines
meta/classes/cmake.bbclass +0 -0
 OECMAKE_FIND_ROOT_PATH_MODE_PROGRAM_class-native = "BOTH"
 
 EXTRA_OECMAKE_append = " ${PACKAGECONFIG_CONFARGS}"
@@ -60,7 +61,7 @@ set( CMAKE_CXX_LINK_FLAGS "${OECMAKE_CXX_LINK_FLAGS}"

CACHE STRING "LDFLAGS" )

Quoted 4 lines

meta/classes/cmake.bbclass set( CMAKE_CXX_LINK_FLAGS "${OECMAKE_CXX_LINK_FLAGS}" CACHE STRING "LDFLAGS" )

Quoted 4 lines
meta/classes/cmake.bbclass +0 -1
 # only search in the paths provided so cmake doesnt pick
 # up libraries and tools from the native build machine
-set( CMAKE_FIND_ROOT_PATH ${STAGING_DIR_HOST} ${STAGING_DIR_NATIVE}

${CROSS_DIR} ${OECMAKE_PERLNATIVE_DIR} ${OECMAKE_EXTRA_ROOT_PATH} ${EXTERNAL_TOOLCHAIN})

Quoted 1 line

meta/classes/cmake.bbclass set( CMAKE_CXX_LINK_FLAGS "${OECMAKE_CXX_LINK_FLAGS}" · line 63

Quoted 1 line
meta/classes/cmake.bbclass +1 -0
+set( CMAKE_FIND_ROOT_PATH ${STAGING_DIR_HOST} ${CROSS_DIR}

${OECMAKE_PERLNATIVE_DIR} ${OECMAKE_EXTRA_ROOT_PATH} ${EXTERNAL_TOOLCHAIN})

Quoted 2 lines

meta/classes/cmake.bbclass set( CMAKE_CXX_LINK_FLAGS "${OECMAKE_CXX_LINK_FLAGS}" · line 65

Quoted 2 lines
meta/classes/cmake.bbclass +0 -0
 set( CMAKE_FIND_ROOT_PATH_MODE_PACKAGE ONLY )
 set( CMAKE_FIND_ROOT_PATH_MODE_PROGRAM

${OECMAKE_FIND_ROOT_PATH_MODE_PROGRAM} )

Quoted 8 lines
Quoted 8 lines
meta/classes/cmake.bbclass +0 -1
 set( CMAKE_FIND_ROOT_PATH_MODE_LIBRARY ONLY )
--

2.10.1

--
_______________________________________________
Openembedded-core mailing list
[email protected]

<mailto:[email protected]>

Quoted 1 line
Quoted 1 line

http://lists.openembedded.org/mailman/listinfo/openembedded-core