proc: kmalloc struct pde_opener

PATCH New Alexey Dobriyan 1 participant 1 message Oct 29, 2016 Proc filesystem

lore

Share & tools

lore

Alexey Dobriyan

author

2016-10-29 13:58 UTC #0 lore raw

PATCH 3/4 proc: kmalloc struct pde_opener

kzalloc is too much, half of the fields will be reinitialized anyway.

If proc file doesn't have ->release hook (some still do not), clearing is unnecessary because it will be freed immediately.

Signed-off-by Alexey Dobriyan <[email protected]>

---

 fs/proc/inode.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

fs/proc/inode.c +3 -1

@@ -321,7 +321,7 @@ static int proc_reg_open(struct inode *inode, struct file *file)
 	 * by hand in remove_proc_entry(). For this, save opener's credentials
 	 * for later.
 	 */
-	pdeo = kzalloc(sizeof(struct pde_opener), GFP_KERNEL);
+	pdeo = kmalloc(sizeof(struct pde_opener), GFP_KERNEL);
 	if (!pdeo)
 		return -ENOMEM;

@@ -338,6 +338,8 @@ static int proc_reg_open(struct inode *inode, struct file *file)
 	if (rv == 0 && release) {
 		/* To know what to release. */
 		pdeo->file = file;
+		pdeo->closing = false;
+		pdeo->c = NULL;
 		/* Strictly for "too late" ->release in proc_reg_release(). */
 		spin_lock(&pde->pde_unload_lock);
 		list_add(&pdeo->lh, &pde->pde_openers);