Skip to contentSkip to conversation

parisc: Use LINUX_GATEWAY_ADDR define instead of hardcoded value value

PATCH In review Helge Deller 3 participants 5 messages Oct 29, 2016 – Nov 2, 2016 PA-RISC architecture

lore
Share & tools
lore

Helge Deller

author maintainer
#0 lore raw

PATCH 1/1 parisc: Use LINUX_GATEWAY_ADDR define instead of hardcoded value value

LINUX_GATEWAY_ADDR is defined in unistd.h. Let's use it.

Signed-off-by Helge Deller <[email protected]>
arch/parisc/kernel/syscall.S +1 -1
index d03422e..d3407cf 100644
@@ -100,7 +100,7 @@ set_thread_pointer:
 	.endr
 
 /* This address must remain fixed at 0x100 for glibc's syscalls to work */
-	.align 256
+	.align LINUX_GATEWAY_ADDR
 linux_gateway_entry:
 	gate	.+8, %r0			/* become privileged */
 	mtsp	%r0,%sr4			/* get kernel space into sr4 */
#1 lore raw
Quoted 1 line · Helge Deller

LINUX_GATEWAY_ADDR is defined in unistd.h. Let's use it.

value value?

author maintainer
#2 lore raw
Quoted 5 lines · Rolf Eike Beer
Quoted 1 line · Helge Deller

LINUX_GATEWAY_ADDR is defined in unistd.h. Let's use it.

value value?

I do see huge value in being able to see where this value is being used. A new developer who uses grep will find the relevant assembler code as well.

Helge

#3 lore raw
Quoted 10 lines · On Mon, 31 Oct 2016 10:26:37 +0100 Helge Deller <[email protected]> wrote:
Quoted 5 lines · Rolf Eike Beer
Quoted 1 line · Helge Deller

LINUX_GATEWAY_ADDR is defined in unistd.h. Let's use it.

value value?

I do see huge value in being able to see where this value is being used. A new developer who uses grep will find the relevant assembler code as well.

Yes, but "value value"! ;-)

Regards,
jer

author maintainer
#4 lore raw
Quoted 8 lines · Jeroen Roovers
Quoted 5 lines · On Mon, 31 Oct 2016 10:26:37 +0100 Helge Deller <[email protected]> wrote:
Quoted 4 lines · Rolf Eike Beer
Quoted 1 line · Helge Deller

LINUX_GATEWAY_ADDR is defined in unistd.h. Let's use it.

Quoted 7 lines
Quoted 5 lines
Quoted 1 line

value value?

I do see huge value in being able to see where this value is being used. A new developer who uses grep will find the relevant assembler code as well.

Yes, but "value value"! ;-)

Yes, I'm blind :-)
It took me quite some time (and one additional off-list reminder from Rolf Eike) to understand that you both meant the commit title :-) I'll fix it before I send upstream.
Thanks!

Helge