Skip to contentSkip to conversation

u-boot: mkimage: Fix build of u-boot-mkimage

PATCH In review Marek Vasut 4 participants 6 messages Nov 2, 2016 – Nov 4, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 u-boot: mkimage: Fix build of u-boot-mkimage

The build failed on qemux86-64 because it couldn't execute tools/bin2header on a host due to it being compiled with target toolchain. Drop the incorrect EXTRA_OEMAKE and just use the one from u-boot-common*.inc . Moreover, since U-Boot buildsystem already strips the tools, add INSANE_SKIP = "already-stripped" .

---
 meta/recipes-bsp/u-boot/u-boot-mkimage_2016.09.01.bb | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
meta/recipes-bsp/u-boot/u-boot-mkimage_2016.09.01.bb +1 -2
index 5025961..76b303e 100644
@@ -3,8 +3,6 @@ require u-boot-common_${PV}.inc
 SUMMARY = "U-Boot bootloader image creation tool"
 DEPENDS = "openssl"
 
-EXTRA_OEMAKE = 'CROSS_COMPILE="${TARGET_PREFIX}" CC="${CC} ${CFLAGS} ${LDFLAGS}" STRIP=true V=1'
-
 do_compile () {
 	oe_runmake sandbox_defconfig
 	oe_runmake cross_tools NO_SDL=1
@@ -17,3 +15,4 @@ do_install () {
 }
 
 BBCLASSEXTEND = "native nativesdk"
+INSANE_SKIP_${PN} = "already-stripped"
Signature · 1 line
2.9.3
#1 lore raw
Quoted 18 lines · Marek Vasut

The build failed on qemux86-64 because it couldn't execute tools/bin2header on a host due to it being compiled with target toolchain. Drop the incorrect EXTRA_OEMAKE and just use the one from u-boot-common*.inc . Moreover, since U-Boot buildsystem already strips the tools, add INSANE_SKIP = "already-stripped" .

---
 meta/recipes-bsp/u-boot/u-boot-mkimage_2016.09.01.bb | 3 +--

 1 file changed, 1 insertion(+), 2 deletions(-)
meta/recipes-bsp/u-boot/u-boot-mkimage_2016.09.01.bb +0 -0
index 5025961..76b303e 100644
@@ -3,8 +3,6 @@ require u-boot-common_${PV}.inc
Quoted 5 lines

 SUMMARY = "U-Boot bootloader image creation tool"
 DEPENDS = "openssl"

-EXTRA_OEMAKE = 'CROSS_COMPILE="${TARGET_PREFIX}" CC="${CC} ${CFLAGS} ${LDFLAGS}" STRIP=true V=1'

Can we keep V=1, please? (Unless it's default anyway).

Cheers,
Andre'

Quoted 12 lines

-
 do_compile () {
  oe_runmake sandbox_defconfig
  oe_runmake cross_tools NO_SDL=1

meta/recipes-bsp/u-boot/u-boot-mkimage_2016.09.01.bb +0 -0
@@ -17,3 +15,4 @@ do_install () {
  }


 BBCLASSEXTEND = "native nativesdk"
+INSANE_SKIP_${PN} = "already-stripped"
--
2.9.3

#2 lore raw
In reply to Marek Vasut
Quoted 4 lines · Marek Vasut

Drop the incorrect EXTRA_OEMAKE and just use the one from u-boot-common*.inc . Moreover, since U-Boot buildsystem already strips the tools, add INSANE_SKIP = "already-stripped" .

But u-boot-common doesn't set EXTRA_OEMAKE...

Ross

#3 lore raw
Quoted 10 lines · Ross

On 2 November 2016 at 12:07, Marek Vasut <[email protected] <mailto:[email protected]>> wrote:

Drop the incorrect EXTRA_OEMAKE and just use the one from u-boot-common*.inc . Moreover, since U-Boot buildsystem already strips the tools, add INSANE_SKIP = "already-stripped" .

But u-boot-common doesn't set EXTRA_OEMAKE...

Should be u-boot.inc , sorry.

Signature · 2 lines
Best regards,
Marek Vasut
#4 lore raw
Quoted 4 lines · Marek Vasut
Quoted 1 line

But u-boot-common doesn't set EXTRA_OEMAKE...

Should be u-boot.inc , sorry.

Yes, but u-book-mkimage doesn't include that file. :)

Ross

#5 lore raw
Quoted 10 lines · Ross
Quoted 4 lines · Marek Vasut
Quoted 1 line

But u-boot-common doesn't set EXTRA_OEMAKE...

Should be u-boot.inc , sorry.

Yes, but u-book-mkimage doesn't include that file. :)

Ross

I am seeing a different problem, but I guess my solution would fix this case here, too. So I am sending it as a new thread. I hope it helps the case and I get some discussion about the solution.

Regards, Stefan