Clean up indirect SQ register accessors for gfx7/8
Subsystems (2)
Denumberify the two indirect accessors to make the code cleaner.
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
PATCH 1/2 drm/amd/amdgpu: Clean up wave gfx7 helper
In reply to a message not in the archiveDe-numberify indirect register access for gfx v7.
--- drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c +5 -1
@@ -4353,7 +4353,11 @@ static void gfx_v7_0_ring_emit_gds_switch(struct amdgpu_ring *ring,static uint32_t wave_read_ind (struct amdgpu_device *adev,uint32_t simd,uint32_t wave,uint32_t address) { -WREG32 (mmSQ_IND_INDEX, (wave &0xF ) | ((simd &0x3 ) <<4 ) | (address <<16 ) | (1 <<13 )); +WREG32 (mmSQ_IND_INDEX, + (wave <<SQ_IND_INDEX__WAVE_ID__SHIFT ) | + (simd <<SQ_IND_INDEX__SIMD_ID__SHIFT ) | + (address <<SQ_IND_INDEX__INDEX__SHIFT ) | + (SQ_IND_INDEX__FORCE_READ_MASK ));return RREG32 (mmSQ_IND_DATA); }
Signature · 6 lines
2.10.0 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
PATCH 2/2 drm/amd/amdgpu: Clean up wave gfx8 helper
In reply to a message not in the archiveDe-numberify indirect register access for gfx v8.
--- drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c +5 -1
@@ -5443,7 +5443,11 @@ static void gfx_v8_0_ring_emit_gds_switch(struct amdgpu_ring *ring,static uint32_t wave_read_ind (struct amdgpu_device *adev,uint32_t simd,uint32_t wave,uint32_t address) { -WREG32 (mmSQ_IND_INDEX, (wave &0xF ) | ((simd &0x3 ) <<4 ) | (address <<16 ) | (1 <<13 )); +WREG32 (mmSQ_IND_INDEX, + (wave <<SQ_IND_INDEX__WAVE_ID__SHIFT ) | + (simd <<SQ_IND_INDEX__SIMD_ID__SHIFT ) | + (address <<SQ_IND_INDEX__INDEX__SHIFT ) | + (SQ_IND_INDEX__FORCE_READ_MASK ));return RREG32 (mmSQ_IND_DATA); }
Signature · 6 lines
2.10.0 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Deucher, Alexander
Reviewed-by Alex DeucherFor the series:
Quoted 7 lines
-----Original Message-----
From: amd-gfx [mailto:[email protected]] On Behalf Of Tom St Denis
Sent: Monday, November 07, 2016 10:36 AM
To: [email protected]
Subject: Clean up indirect SQ register accessors for gfx7/8
Quoted 6 lines
Denumberify the two indirect accessors to make the code cleaner.
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx