drm/amdgpu/powerplay/smu7: fix unintialized data usage
Subsystems (2)
PATCH 1/1 drm/amdgpu/powerplay/smu7: fix unintialized data usage
A recent bugfix replaced an out-of-bounds access with direct use of unintialized data:
drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c: In function 'smu7_patch_limits_vddc':drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c:2033:6: error: 'vddc' may be used uninitialized in this function [-Werror=maybe-uninitialized] drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c:2146:11: note: 'vddc' was declared here drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c:2033:6: error: 'vddci' may be used uninitialized in this function [-Werror=maybe-uninitialized] drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c:2146:17: note: 'vddci' was declared here
uint32_t vddc, vddci;
This initializes the data as before using the correct type.
--- drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c +2 -0
@@ -2147,9 +2147,11 @@ static int smu7_patch_limits_vddc(struct pp_hwmgr *hwmgr,struct smu7_hwmgr *data = (struct smu7_hwmgr *)(hwmgr->backend);if (tab) { + vddc = tab->vddc;smu7_patch_ppt_v0_with_vdd_leakage (hwmgr, &vddc, &data->vddc_leakage); tab->vddc = vddc; + vddci = tab->vddci;smu7_patch_ppt_v0_with_vdd_leakage (hwmgr, &vddci, &data->vddci_leakage); tab->vddci = vddci;
Signature · 6 lines
2.9.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Alex Deucher
AppliedQuoted 10 lines · Arnd Bergmann
A recent bugfix replaced an out-of-bounds access with direct use of unintialized data:
drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c: In function 'smu7_patch_limits_vddc':drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c:2033:6: error: 'vddc' may be used uninitialized in this function [-Werror=maybe-uninitialized]drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c:2146:11: note: 'vddc' was declared heredrivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c:2033:6: error: 'vddci' may be used uninitialized in this function [-Werror=maybe-uninitialized]drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c:2146:17: note: 'vddci' was declared here
uint32_tvddc, vddci;
Quoted 4 lines
This initializes the data as before using the correct type.
Fixes 77f7f71f5be1 ("drm/amdgpu/powerplay/smu7: fix static checker warning")Signed-off-by Arnd Bergmann <[email protected]>
Applied. thanks!
Alex
Quoted 23 lines
--- drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 2 ++ 1 file changed, 2 insertions(+)drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c +2
-1@@ -2147,9 +2147,11 @@ static int smu7_patch_limits_vddc(struct pp_hwmgr *hwmgr,struct smu7_hwmgr *data = (struct smu7_hwmgr *)(hwmgr->backend);if (tab) { + vddc = tab->vddc;smu7_patch_ppt_v0_with_vdd_leakage (hwmgr, &vddc, &data->vddc_leakage); tab->vddc = vddc; + vddci = tab->vddci;smu7_patch_ppt_v0_with_vdd_leakage (hwmgr, &vddci, &data->vddci_leakage); tab->vddci = vddci; --2.9.0
Quoted 4 lines
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel