genetlink: fix error return code in genl_register_family()
Subsystems (3)
Hello Wei Yongjun,
The patch 22ca904ad70a: "genetlink: fix error return code in genl_register_family()" from Nov 1, 2016, leads to the following static checker warning:
net/netlink/genetlink.c:365 genl_register_family() warn: unsigned 'family->id' is never less than zero.
net/netlink/genetlink.c
362
363 family->id = idr_alloc(&genl_fam_idr, family,
364 start, end + 1, GFP_KERNEL);
365 if (family->id < 0) {
^^^^^^^^^^^^^^Doesn't work for unsigned int.
366 err = family->id; 367 goto errout_free; 368 } 369
regards,
dan carpenter
Cc'ing netdev
Quoted 9 lines · Dan Carpenter
Hello Wei Yongjun,
The patch
22ca904ad70a: "genetlink: fix error return code ingenl_register_family()" from Nov 1, 2016, leads to the following static checker warning:net/netlink/genetlink.c:365 genl_register_family() warn: unsigned 'family->id' is never less than zero.
Quoted 7 lines
net/netlink/genetlink.c
362
363family->id= idr_alloc(&genl_fam_idr, family,364 start, end + 1, GFP_KERNEL); 365 if (family->id < 0) { ^^^^^^^^^^^^^^Doesn't work for unsigned int.
family->id should be signed int.