Skip to contentSkip to conversation

usb: ehci-omap: don't complain on -EPROBE_DEFER when no PHY found

PATCH In review Ladislav Michl 2 participants 2 messages Nov 9, 2016 1 message not in the archive

Subsystems (3)
USB USB ehci driver OMAP USB support
lore
Share & tools
lore

Ladislav Michl

author
#0 lore raw

PATCH 1/1 usb: ehci-omap: don't complain on -EPROBE_DEFER when no PHY found

Don't complain on -EPROBE_DEFER when when no PHY found, the driver probe will be retried later.

Signed-off-by Ladislav Michl <ladis-6z/[email protected]>
---
 drivers/usb/host/ehci-omap.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/usb/host/ehci-omap.c +3 -2
index 94ea9ff..44945eb 100644
@@ -181,8 +181,9 @@ static int ehci_hcd_omap_probe(struct platform_device *pdev)
 				continue;
 
 			ret = PTR_ERR(phy);
-			dev_err(dev, "Can't get PHY device for port %d: %d\n",
-					i, ret);
+			if (ret != -EPROBE_DEFER)
+				dev_err(dev, "Can't get PHY device for port "
+					"%d: %d\n", i, ret);
 			goto err_phy;
 		}
Signature · 6 lines
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 20161109140247.GC20859-bi+AKbBUZKY6gyzm1THtWbp2dZbC/[email protected]

Acked-by
#2 lore raw
Quoted 2 lines · Ladislav Michl

Don't complain on -EPROBE_DEFER when when no PHY found, the driver probe will be retried later.

Please send this directly to Alan and Greg:

Acked-by Tony Lindgren <[email protected]>
Quoted 24 lines
Signed-off-by Ladislav Michl <ladis-6z/[email protected]>
---
 drivers/usb/host/ehci-omap.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/usb/host/ehci-omap.c +3 -2
index 94ea9ff..44945eb 100644
@@ -181,8 +181,9 @@ static int ehci_hcd_omap_probe(struct platform_device *pdev)
 				continue;
 
 			ret = PTR_ERR(phy);
-			dev_err(dev, "Can't get PHY device for port %d: %d\n",
-					i, ret);
+			if (ret != -EPROBE_DEFER)
+				dev_err(dev, "Can't get PHY device for port "
+					"%d: %d\n", i, ret);
 			goto err_phy;
 		}
Signature · 1 line
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html