mfd: intel-lpss: Try to enable Memory-Write-Invalidate
Andy Shevchenko
reviewerPATCH 1/1 mfd: intel-lpss: Try to enable Memory-Write-Invalidate
Enable MWI mechanism if PCI bus master supports it.
--- drivers/mfd/intel-lpss-pci.c | 1 + 1 file changed, 1 insertion(+)
drivers/mfd/intel-lpss-pci.c +1 -0
@@ -41,6 +41,7 @@ static int intel_lpss_pci_probe(struct pci_dev *pdev,/* Probably it is enough to set this for iDMA capable devices only */ pci_set_master (pdev); +pci_try_set_mwi (pdev); ret =intel_lpss_probe (&pdev->dev, info);if (ret)
Signature · 1 line
2.9.3
Quoted 1 line · Andy Shevchenko
Enable MWI mechanism if PCI bus master supports it.
Why?
Andy Shevchenko
reviewerQuoted 4 lines · Mika Westerberg
Quoted 1 line · Andy Shevchenko
Enable MWI mechanism if PCI bus master supports it.
Why?
It might be potential benefit in some cases. Documentation says that standard Memory Write might supply more current data than in the CPU modified cache line and "trashing a line in the cache may trash some data that is more current that in the memory line". This allows to avoid potential retries and other performance degradation issues on the bus. Though, I dunno how to measure it.
Would be enough to extend commit message by this paragraph?
Signature · 2 lines
Andy Shevchenko <[email protected]> Intel Finland Oy
Quoted 6 lines · Andy Shevchenko
Quoted 4 lines · Mika Westerberg
Quoted 1 line · Andy Shevchenko
Enable MWI mechanism if PCI bus master supports it.
Why?
Quoted 8 lines
It might be potential benefit in some cases. Documentation says that standard Memory Write might supply more current data than in the CPU modified cache line and "trashing a line in the cache may trash some data that is more current that in the memory line". This allows to avoid potential retries and other performance degradation issues on the bus. Though, I dunno how to measure it.
Would be enough to extend commit message by this paragraph?
That's better, yes.