Skip to contentSkip to conversation

fs: Constify path_is_under()'s arguments

PATCH New Mickaël Salaün 1 participant 1 message Nov 14, 2016 VFS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fs: Constify path_is_under()'s arguments

The function path_is_under() doesn't modify the paths pointed by its arguments but only browse them. Constifying this pointers make a cleaner interface to be used by (future) code which may only have access to const struct path pointers (e.g. LSM hooks).

---
 fs/namespace.c     | 2 +-
 include/linux/fs.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
fs/namespace.c +1 -1
index e6c234b1a645..4d80a5066a1f 100644
@@ -2997,7 +2997,7 @@ bool is_path_reachable(struct mount *mnt, struct dentry *dentry,
 	return &mnt->mnt == root->mnt && is_subdir(dentry, root->dentry);
 }
 
-bool path_is_under(struct path *path1, struct path *path2)
+bool path_is_under(const struct path *path1, const struct path *path2)
 {
 	bool res;
 	read_seqlock_excl(&mount_lock);
include/linux/fs.h +1 -1
index dc0478c07b2a..f96501b51c49 100644
@@ -2709,7 +2709,7 @@ extern struct file * open_exec(const char *);
  
 /* fs/dcache.c -- generic fs support functions */
 extern bool is_subdir(struct dentry *, struct dentry *);
-extern bool path_is_under(struct path *, struct path *);
+extern bool path_is_under(const struct path *, const struct path *);
 
 extern char *file_path(struct file *, char *, int);
 
Signature · 1 line
2.10.2