ixgbe: fix AER error handling
Subsystems (2)
PATCH 1/1 ixgbe: fix AER error handling
Make sure that we free the IRQs in ixgbe_io_error_detected() when responding to an PCIe AER error and also restore them when the interface recovers from it.
Previously it was possible to trigger BUG_ON() check in free_msix_irqs() in the case where we call ixgbe_remove() after a failed recovery from AER error because the inerrupts were not freed.
--- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c +4 -2
@@ -10078,7 +10078,7 @@ static pci_ers_result_t ixgbe_io_error_detected(struct pci_dev *pdev, }if (netif_running (netdev)) -ixgbe_down (adapter); +ixgbe_close_suspend (adapter);if (!test_and_set_bit (__IXGBE_DISABLED, &adapter->state))pci_disable_device (pdev);
@@ -10148,10 +10148,12 @@ static void ixgbe_io_resume(struct pci_dev *pdev) }#endif +rtnl_lock ();if (netif_running (netdev)) -ixgbe_up (adapter); +ixgbe_open (netdev);netif_device_attach (netdev); +rtnl_unlock (); } static const struct pci_error_handlers ixgbe_err_handler = {
Bowers
PATCH 1/1 ixgbe: fix AER error handling
Quoted 11 lines
-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On Behalf Of Emil Tantilov
Sent: Wednesday, November 16, 2016 9:48 AM
To: intel-wired-lan at lists.osuosl.org
Subject: [Intel-wired-lan] [PATCH] ixgbe: fix AER error handlingMake sure that we free the IRQs in
ixgbe_io_error_detected()when responding to an PCIe AER error and also restore them when the interface recovers from it.
Quoted 8 lines
Previously it was possible to trigger
BUG_ON()check infree_msix_irqs()in the case where we callixgbe_remove()after a failed recovery from AER error because the inerrupts were not freed.Signed-off-by Emil Tantilov <[email protected]>--- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)