Skip to contentSkip to conversation

isci: Add a missing call to pci_unmap_biosrom

PATCH Applied Quentin Lambert 2 participants 2 messages Nov 19, 2016 – Nov 29, 2016

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 isci: Add a missing call to pci_unmap_biosrom

Most error branches following the call to pci_map_biosrom contain a call to pci_unmap_biosrom. This patch add these calls where they are missing.

This issue was found with Hector.

---
 drivers/scsi/isci/probe_roms.c |    1 +
 1 file changed, 1 insertion(+)
drivers/scsi/isci/probe_roms.c +1 -0
@@ -54,6 +54,7 @@ struct isci_orom *isci_request_oprom(str
 	len = pci_biosrom_size(pdev);
 	rom = devm_kzalloc(&pdev->dev, sizeof(*rom), GFP_KERNEL);
 	if (!rom) {
+		pci_unmap_biosrom(oprom);
 		dev_warn(&pdev->dev,
 			 "Unable to allocate memory for orom\n");
 		return NULL;
#1 lore raw
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Quentin" = Quentin Lambert <[email protected]> writes:

Quentin> Most error branches following the call to pci_map_biosrom Quentin> contain a call to pci_unmap_biosrom. This patch add these calls Quentin> where they are missing.

Applied to 4.10/scsi-queue.

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering