Skip to contentSkip to conversation

Enable glamor by default with >= R600 and Xorg >= 1.18.3

PATCH In review Michel Dänzer 2 participants 2 messages Nov 21, 2016 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Enable glamor by default with >= R600 and Xorg >= 1.18.3

From: Michel Dänzer <[email protected]>

glamor should now perform at least as well as EXA in general, and this allows DRI3 to be enabled by default for >= R600.

---
 man/radeon.man      |  2 +-
 src/radeon_glamor.c | 11 +++++++++--
 2 files changed, 10 insertions(+), 3 deletions(-)
man/radeon.man +1 -1
index 6af7a92..8990ae2 100644
@@ -293,7 +293,7 @@ Chooses between available acceleration architectures.  Valid values are
 .B glamor
 (for R300 or higher). The default is
 .B glamor
-as of TAHITI, otherwise
+with R600 or newer (with Xorg >= 1.18.3, otherwise with TAHITI or newer), otherwise
 .B EXA.
 
 .PP
src/radeon_glamor.c +9 -2
index b66848f..590c9f0 100644
@@ -84,8 +84,15 @@ radeon_glamor_pre_init(ScrnInfoPtr scrn)
 		return FALSE;
 
 	s = xf86GetOptValString(info->Options, OPTION_ACCELMETHOD);
-	if (s == NULL && info->ChipFamily < CHIP_FAMILY_TAHITI)
-		return FALSE;
+	if (!s) {
+		if (xorgGetVersion() >= XORG_VERSION_NUMERIC(1,18,3,0,0)) {
+			if (info->ChipFamily < CHIP_FAMILY_R600)
+				return FALSE;
+		} else {
+			if (info->ChipFamily < CHIP_FAMILY_TAHITI)
+				return FALSE;
+		}
+	}
 
 	if (s && strcasecmp(s, "glamor") != 0) {
 		if (info->ChipFamily >= CHIP_FAMILY_TAHITI)
Signature · 6 lines
2.10.2

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 20161121091731.13260-1-michel-otUistvHUpPR7s880joybQ@public.gmane.org

Reviewed-by
#2 lore raw
Quoted 6 lines · Michel Dänzer

From: Michel Dänzer <[email protected]>

glamor should now perform at least as well as EXA in general, and this allows DRI3 to be enabled by default for >= R600.

Quoted 43 lines
---
 man/radeon.man      |  2 +-
 src/radeon_glamor.c | 11 +++++++++--
 2 files changed, 10 insertions(+), 3 deletions(-)
man/radeon.man +1 -1
index 6af7a92..8990ae2 100644
@@ -293,7 +293,7 @@ Chooses between available acceleration architectures.  Valid values are
 .B glamor
 (for R300 or higher). The default is
 .B glamor
-as of TAHITI, otherwise
+with R600 or newer (with Xorg >= 1.18.3, otherwise with TAHITI or newer), otherwise
 .B EXA.
 
 .PP
src/radeon_glamor.c +9 -3
index b66848f..590c9f0 100644
@@ -84,8 +84,15 @@ radeon_glamor_pre_init(ScrnInfoPtr scrn)
                return FALSE;
 
        s = xf86GetOptValString(info->Options, OPTION_ACCELMETHOD);
-       if (s == NULL && info->ChipFamily < CHIP_FAMILY_TAHITI)
-               return FALSE;
+       if (!s) {
+               if (xorgGetVersion() >= XORG_VERSION_NUMERIC(1,18,3,0,0)) {
+                       if (info->ChipFamily < CHIP_FAMILY_R600)
+                               return FALSE;
+               } else {
+                       if (info->ChipFamily < CHIP_FAMILY_TAHITI)
+                               return FALSE;
+               }
+       }
 
        if (s && strcasecmp(s, "glamor") != 0) {
                if (info->ChipFamily >= CHIP_FAMILY_TAHITI)
--

2.10.2

Quoted 4 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx