Don't install Flush/EventCallback for GPU screens
PATCH 1/1 Don't install Flush/EventCallback for GPU screens
From: Michel Dänzer <[email protected]>
Their purpose is to flush GPU rendering commands corresponding to damage events, but there can be no damage events corresponding to GPU screen rendering operations.
--- src/radeon_kms.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
src/radeon_kms.c +2 -2
@@ -302,7 +302,7 @@ radeon_flush_callback(CallbackListPtr *list,static Bool RADEONCreateScreenResources_KMS (ScreenPtr pScreen) { -ExtensionEntry *damage_ext =CheckExtension ("DAMAGE" ); +ExtensionEntry *damage_ext;ScrnInfoPtr pScrn =xf86ScreenToScrn (pScreen);RADEONInfoPtr info =RADEONPTR (pScrn);PixmapPtr pixmap;
@@ -360,7 +360,7 @@ static Bool RADEONCreateScreenResources_KMS(ScreenPtr pScreen)radeon_glamor_create_screen_resources (pScreen); info->callback_event_type =-1 ; -if (damage_ext) { +if (!pScreen->isGPU && (damage_ext =CheckExtension ("DAMAGE" ))) { info->callback_event_type = damage_ext->eventBase + XDamageNotify;if (!AddCallback (&FlushCallback, radeon_flush_callback, pScrn))
Signature · 6 lines
2.10.2 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 20161121092736.13651-1-michel-otUistvHUpPR7s880joybQ@public.gmane.org
Alex Deucher
Reviewed-byQuoted 7 lines · Michel Dänzer
From: Michel Dänzer <[email protected]>
Their purpose is to flush GPU rendering commands corresponding to damage events, but there can be no damage events corresponding to GPU screen rendering operations.
Signed-off-by Michel Dänzer <[email protected]>
Quoted 29 lines
--- src/radeon_kms.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)src/radeon_kms.c +2
-3@@ -302,7 +302,7 @@ radeon_flush_callback(CallbackListPtr *list,static Bool RADEONCreateScreenResources_KMS (ScreenPtr pScreen) { -ExtensionEntry *damage_ext =CheckExtension ("DAMAGE" ); +ExtensionEntry *damage_ext;ScrnInfoPtr pScrn =xf86ScreenToScrn (pScreen);RADEONInfoPtr info =RADEONPTR (pScrn);PixmapPtr pixmap;@@ -360,7 +360,7 @@ static Bool RADEONCreateScreenResources_KMS(ScreenPtr pScreen)radeon_glamor_create_screen_resources (pScreen); info->callback_event_type =-1 ; -if (damage_ext) { +if (!pScreen->isGPU && (damage_ext =CheckExtension ("DAMAGE" ))) { info->callback_event_type = damage_ext->eventBase + XDamageNotify;if (!AddCallback (&FlushCallback, radeon_flush_callback, pScrn)) --2.10.2
Quoted 4 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx