OvmfPkg/build.sh: Use GCC49 toolchain with GCC 6.*
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH RESEND 1/1 OvmfPkg/build.sh: Use GCC49 toolchain with GCC 6.*
Without this I cannot build it under Fedora Core 25.
Contributed-under: TianoCore Contribution Agreement 1.0
--- OvmfPkg/build.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
OvmfPkg/build.sh +1 -1
@@ -95,7 +95,7 @@ case `uname` in 4.8.*) TARGET_TOOLS=GCC48 ;; - 4.9.*|4.1[0-9].*|5.*.*) + 4.9.*|4.1[0-9].*|5.*.*|6.*.*) TARGET_TOOLS=GCC49 ;; *)
Signature · 7 lines
2.9.3 _______________________________________________ Xen-devel mailing list [email protected] https://lists.xen.org/xen-devel
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 13 lines · Konrad Rzeszutek Wilk
Without this I cannot build it under Fedora Core 25.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by Konrad Rzeszutek Wilk <[email protected]>--- OvmfPkg/build.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)OvmfPkg/build.sh +0
-0
OvmfPkg/build.sh case `uname` in · line 101
Quoted 8 lines
OvmfPkg/build.sh +1
-1@@ -95,7 +95,7 @@ case `uname` in 4.8.*) TARGET_TOOLS=GCC48 ;; - 4.9.*|4.1[0-9].*|5.*.*) + 4.9.*|4.1[0-9].*|5.*.*|6.*.*) TARGET_TOOLS=GCC49 ;; *)
I think it may be time to start using GCC5 for 5.x and later
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xen.org/xen-devel
A message that is not in the archive (sent off-list or not yet received): CAKv+Gu8+p-fKbaDMJPs4KqQkZTErJT3bXVo3dZ9RDsPhGwEvsQ@mail.gmail.com
Quoted 9 lines · Ard Biesheuvel
Quoted 8 lines · Konrad Rzeszutek Wilk
Without this I cannot build it under Fedora Core 25.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by Konrad Rzeszutek Wilk <[email protected]>--- OvmfPkg/build.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 15 lines
OvmfPkg/build.sh case `uname` in · line 101
Quoted 13 lines
OvmfPkg/build.sh +1
-1@@ -95,7 +95,7 @@ case `uname` in 4.8.*) TARGET_TOOLS=GCC48 ;; - 4.9.*|4.1[0-9].*|5.*.*) + 4.9.*|4.1[0-9].*|5.*.*|6.*.*) TARGET_TOOLS=GCC49 ;; *)I think it may be time to start using GCC5 for 5.x and later
This did the trick as well.
I don't have GCC 5.*.* so I could not confirm.
OvmfPkg/build.sh +4 -1
@@ -95,9 +95,12 @@ case `uname` in 4.8.*) TARGET_TOOLS=GCC48 ;; - 4.9.*|4.1[0-9].*|5.*.*|6.*.*) + 4.9.*|4.1[0-9].*|5.*.*) TARGET_TOOLS=GCC49 ;; + 6.*.*) + TARGET_TOOLS=GCC5 + ;; *) TARGET_TOOLS=GCC44 ;;
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xen.org/xen-devel
Quoted 9 lines · Ard Biesheuvel
Quoted 8 lines · Konrad Rzeszutek Wilk
Without this I cannot build it under Fedora Core 25.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by Konrad Rzeszutek Wilk <[email protected]>--- OvmfPkg/build.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 15 lines
OvmfPkg/build.sh case `uname` in · line 101
Quoted 13 lines
OvmfPkg/build.sh +1
-1@@ -95,7 +95,7 @@ case `uname` in 4.8.*) TARGET_TOOLS=GCC48 ;; - 4.9.*|4.1[0-9].*|5.*.*) + 4.9.*|4.1[0-9].*|5.*.*|6.*.*) TARGET_TOOLS=GCC49 ;; *)I think it may be time to start using GCC5 for 5.x and later
I agree.
We have an open BZ for this:
https://bugzilla.tianocore.org/show_bug.cgi?id=62
Olaf Hering submitted a patch around June, but the formalities on those patches weren't right, and Olaf decided not to submit further versions of the patch.
Here's the idea:
- change the catch-all (*) to GCC5, from GCC44
- remove the (5.*.*) pattern from GCC49
- add a branch (with multiple patterns if necessary) for gcc-4.3 and earlier to exit with an error message / failure (those compiler versions are unsupported)
Konrad, can you please submit a v2 with this? If so, please add the tag
Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=62
as well, just before the "Contributed-under:" tag.
(Side note: we haven't been ignoring BZ#62. It's just that after reviewing Olaf's original patch, implementing the change -- which is very simple and cannot really be done in different ways -- in his stead would have practically consisted of replacing Olaf's signoff with someone elses, and we couldn't do that.)
Thank you,
Laszlo
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xen.org/xen-devel