Skip to contentSkip to conversation

mac80211: Remove unused 'struct rate_control_ref' variable

PATCH Applied Kirtika Ruchandani 2 participants 2 messages Nov 22, 2016 1 message not in the archive

Subsystems (3)
Networking Network drivers mac80211
lore
Share & tools
lore

Kirtika Ruchandani

author
#0 lore raw

PATCH 1/1 mac80211: Remove unused 'struct rate_control_ref' variable

Commit 3b17fbf87d5d introduced sta_get_expected_throughput() leaving variable 'struct rate_control_ref* ref' set but unused. Compiling with W=1 gives the following warning, fix it.

net/mac80211/sta_info.c: In function ‘sta_set_sinfo’:
net/mac80211/sta_info.c:2052:27: warning: variable ‘ref’ set but not used [-Wunused-but-set-variable]

Fixes 3b17fbf87d5d ("mac80211: mesh: Add support for HW RC implementation")
Cc Johannes Berg <[email protected]>
Cc Maxim Altshul <[email protected]>
Signed-off-by Kirtika Ruchandani <[email protected]>
---
 net/mac80211/sta_info.c | 4 ----
 1 file changed, 4 deletions(-)
net/mac80211/sta_info.c +0 -4
index 1711bae..4ab75a9 100644
@@ -2049,16 +2049,12 @@ void sta_set_sinfo(struct sta_info *sta, struct station_info *sinfo)
 {
 	struct ieee80211_sub_if_data *sdata = sta->sdata;
 	struct ieee80211_local *local = sdata->local;
-	struct rate_control_ref *ref = NULL;
 	u32 thr = 0;
 	int i, ac, cpu;
 	struct ieee80211_sta_rx_stats *last_rxstats;
 
 	last_rxstats = sta_get_last_rx_stats(sta);
 
-	if (test_sta_flag(sta, WLAN_STA_RATE_CONTROL))
-		ref = local->rate_ctrl;
-
 	sinfo->generation = sdata->local->sta_generation;
 
 	/* do before driver, so beacon filtering drivers have a

--
2.8.0.rc3.226.g39d4020

A message that is not in the archive (sent off-list or not yet received): [email protected]

Applied
#2 lore raw
Quoted 7 lines · Kirtika Ruchandani

Commit 3b17fbf87d5d introduced sta_get_expected_throughput() leaving variable 'struct rate_control_ref* ref' set but unused. Compiling with W=1 gives the following warning, fix it.

net/mac80211/sta_info.c: In function ‘sta_set_sinfo’:
net/mac80211/sta_info.c:2052:27: warning: variable ‘ref’ set but not used [-Wunused-but-set-variable]

Applied all three of these, thanks Kirtika.

johannes