auxdisplay: ht16k33: select CONFIG_FB_SYS_FOPS
PATCH 1/1 auxdisplay: ht16k33: select CONFIG_FB_SYS_FOPS
The new driver caused a rare randconfig failure:
drivers/auxdisplay/ht16k33.o:(.data.ht16k33_fb_ops+0xc): undefined reference to fb_sys_read' drivers/auxdisplay/ht16k33.o:(.data.ht16k33_fb_ops+0x10): undefined reference to fb_sys_write'
This selects the respective helper module, like all other such drivers do.
--- drivers/auxdisplay/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/auxdisplay/Kconfig +1 -0
@@ -131,6 +131,7 @@ config IMG_ASCII_LCD config HT16K33 tristate "Holtek Ht16K33 LED controller with keyscan" depends on FB && OF && I2C && INPUT + select FB_SYS_FOPS select INPUT_MATRIXKMAP select FB_BACKLIGHT help
Signature · 1 line
2.9.0
Hi Arnd,
Quoted 7 lines · On Wed, 23 Nov 2016 14:06:49 +0100 Arnd Bergmann <[email protected]> wrote:
The new driver caused a rare randconfig failure:
drivers/auxdisplay/ht16k33.o:(.data.ht16k33_fb_ops+0xc): undefined reference to
fb_sys_read' drivers/auxdisplay/ht16k33.o:(.data.ht16k33_fb_ops+0x10): undefined reference tofb_sys_write'This selects the respective helper module, like all other such drivers do.
Thanks for reporting this. You are right about the missing helper. However, the fb_ops struct uses several helpers which are all missing.
static struct fb_ops ht16k33_fb_ops = {
.owner = THIS_MODULE,
.fb_read = fb_sys_read,
.fb_write = fb_sys_write,
.fb_fillrect = sys_fillrect,
.fb_copyarea = sys_copyarea,
.fb_imageblit = sys_imageblit,
.fb_mmap = ht16k33_mmap,
};
HT16K33 should also select:FB_CFB_FILLRECTFB_CFB_COPYAREAFB_CFB_IMAGEBLIT
Quoted 12 lines
Fixes 8992da44c680 ("auxdisplay: ht16k33: Driver for LED controller")Signed-off-by Arnd Bergmann <[email protected]>--- drivers/auxdisplay/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/auxdisplay/Kconfig +0
-0
drivers/auxdisplay/Kconfig config IMG_ASCII_LCD · line 137
Quoted 7 lines
drivers/auxdisplay/Kconfig +1
-0@@ -131,6 +131,7 @@ config IMG_ASCII_LCD config HT16K33 tristate "Holtek Ht16K33 LED controller with keyscan" depends on FB && OF && I2C && INPUT + select FB_SYS_FOPS select INPUT_MATRIXKMAP select FB_BACKLIGHT help
Regards,
Robin
Quoted 14 lines · CET Robin van der Gracht
Thanks for reporting this. You are right about the missing helper. However, the
fb_opsstruct uses several helpers which are all missing.static struct
fb_opsht16k33_fb_ops= {
.owner =THIS_MODULE,
.fb_read =fb_sys_read,
.fb_write =fb_sys_write,
.fb_fillrect =sys_fillrect,
.fb_copyarea =sys_copyarea,
.fb_imageblit =sys_imageblit,
.fb_mmap =ht16k33_mmap,
};
Quoted 5 lines
HT16K33 should also select:
FB_CFB_FILLRECTFB_CFB_COPYAREAFB_CFB_IMAGEBLIT
Ah right. I had not run into those so far during randconfig testing, probably because there is usually at least one other framebuffer enabled that selects them.
Can you submit a patch to add all those?
Arnd