Skip to contentSkip to conversation

USB: ohci: da8xx: Resume the entire host controller

PATCH New Axel Haslam 1 participant 1 message Nov 24, 2016

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 USB: ohci: da8xx: Resume the entire host controller

The da8xx ohci controller is not working after suspend and resume.

This is because only the root hub is being resumed.

Balance the ohci_suspend of the suspend path with an ohci_resume in the resume path so that we resume the entire controller, and not just the root hub.

Also, while we are here, remove setting device power_state, as this is no longer needed and scheduled for removal

---
Changes v1->v2
* reword commit message (Alan Stern)

 drivers/usb/host/ohci-da8xx.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/usb/host/ohci-da8xx.c +1 -2
index 9e336f4..05da2cb 100644
@@ -528,8 +528,7 @@ static int ohci_da8xx_resume(struct platform_device *dev)
 	if (ret)
 		return ret;
 
-	dev->dev.power.power_state = PMSG_ON;
-	usb_hcd_resume_root_hub(hcd);
+	ohci_resume(hcd, false);
 
 	return 0;
 }
Signature · 1 line
2.9.3