net/mlx5: remove a duplicate condition

PATCH Applied Dan Carpenter 3 participants 3 messages Nov 24, 2016 – Nov 26, 2016

Subsystems (5)

Networking Network drivers Kernel janitors InfiniBand +1 more subsystems

lore

Share & tools

lore

Dan Carpenter

author

2016-11-24 11:03 UTC #0 lore raw

PATCH 1/1 net/mlx5: remove a duplicate condition

We verified that MLX5_FLOW_CONTEXT_ACTION_COUNT was set on the first line of the function so we don't need to check again here.

Signed-off-by Dan Carpenter <[email protected]>

---
Not a bugfix so it would go into -next

drivers/net/ethernet/mellanox/mlx5/core/fs_core.c +1 -2

index 68ec4ea..a263d89 100644
@@ -1307,8 +1307,7 @@ static bool counter_is_valid(struct mlx5_fc *counter, u32 action)
 		return false;
 
 	return (action & (MLX5_FLOW_CONTEXT_ACTION_DROP |
-			  MLX5_FLOW_CONTEXT_ACTION_FWD_DEST)) &&
-		(action & MLX5_FLOW_CONTEXT_ACTION_COUNT);
+			  MLX5_FLOW_CONTEXT_ACTION_FWD_DEST));
 }
 
 static bool dest_is_valid(struct mlx5_flow_destination *dest,

Saeed Mahameed

Acked-by on v1 1/1

2016-11-24 15:30 UTC #1 lore raw

Quoted 4 lines · Dan Carpenter

We verified that MLX5_FLOW_CONTEXT_ACTION_COUNT was set on the first line of the function so we don't need to check again here.
Signed-off-by Dan Carpenter <[email protected]>

Acked-by Saeed Mahameed <[email protected]>

David Miller

maintainer Applied

2016-11-26 01:30 UTC #2 lore raw

In reply to Dan Carpenter

From: Dan Carpenter <[email protected]>
Date: Thu, 24 Nov 2016 14:03:45 +0300

Quoted 4 lines

We verified that MLX5_FLOW_CONTEXT_ACTION_COUNT was set on the first line of the function so we don't need to check again here.
Signed-off-by Dan Carpenter <[email protected]>

Applied.