Skip to contentSkip to conversation

perf/x86/intel: Enable C-state residency events for Knights Mill

PATCH Superseded Piotr Luc 3 participants 5 messages Nov 30, 2016 – Dec 6, 2016

Subsystems (2)
lore
Share & tools
lore

Piotr Luc

author
#0 lore raw

PATCH 1/1 perf/x86/intel: Enable C-state residency events for Knights Mill

The Knights Mill is enough close to Knights Landing so the path reuses C-state residency support of the latter.

Cc Thomas Gleixner <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc "H. Peter Anvin" <[email protected]>
---
 arch/x86/events/intel/cstate.c | 1 +
 1 file changed, 1 insertion(+)
arch/x86/events/intel/cstate.c +1 -0
index 4f5ac72..da51e5a 100644
@@ -540,6 +540,7 @@ static const struct x86_cpu_id intel_cstates_match[] __initconst = {
 	X86_CSTATES_MODEL(INTEL_FAM6_SKYLAKE_DESKTOP, snb_cstates),
 
 	X86_CSTATES_MODEL(INTEL_FAM6_XEON_PHI_KNL, knl_cstates),
+	X86_CSTATES_MODEL(INTEL_FAM6_XEON_PHI_KNM, knl_cstates),
 	{ },
 };
 MODULE_DEVICE_TABLE(x86cpu, intel_cstates_match);
Signature · 1 line
2.10.1
author
#2 lore raw
Quoted 14 lines · Thomas Gleixner
Quoted 11 lines · Piotr Luc

The Knights Mill is enough close to Knights Landing so the path reuses
C-state residency support of the latter.

Cc Thomas Gleixner <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc "H. Peter Anvin" <[email protected]>
Quoted 6 lines

Please consult MAINTAINERS to figure out who should be on the CC list.

Thanks,

tglx

Thanks for picking this up.
I counted on get_maintainers.pl script, but it seems it used the generic rule instead the specific one. I will correct CC list right now.

Thanks
Piotr

author
#3 lore raw

PATCH RESEND 1/1 perf/x86/intel: Enable C-state residency events for Knights Mill

In reply to Piotr Luc

The Knights Mill is enough close to Knights Landing so the path reuses C-state residency support of the latter.

Cc Peter Zijlstra <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc Arnaldo Carvalho de Melo <[email protected]>
Cc Alexander Shishkin <[email protected]>
---
 arch/x86/events/intel/cstate.c | 1 +
 1 file changed, 1 insertion(+)
arch/x86/events/intel/cstate.c +1 -0
index 4f5ac72..da51e5a 100644
@@ -540,6 +540,7 @@ static const struct x86_cpu_id intel_cstates_match[] __initconst = {
 	X86_CSTATES_MODEL(INTEL_FAM6_SKYLAKE_DESKTOP, snb_cstates),
 
 	X86_CSTATES_MODEL(INTEL_FAM6_XEON_PHI_KNL, knl_cstates),
+	X86_CSTATES_MODEL(INTEL_FAM6_XEON_PHI_KNM, knl_cstates),
 	{ },
 };
 MODULE_DEVICE_TABLE(x86cpu, intel_cstates_match);
Signature · 9 lines
2.10.1

Fixed CC list.

+ Cc: Peter Zijlstra <[email protected]>
+ Cc: Arnaldo Carvalho de Melo <[email protected]>
+ Cc: Alexander Shishkin <[email protected]>
- Cc: Thomas Gleixner <[email protected]>
- Cc: "H. Peter Anvin" <[email protected]>
#4 lore raw
perf/x86/intel: Enable C-state residency events for Knights Mill
Commit-ID:  1dba23b12f49d7cf3d4504171c62541122b55141
Gitweb:     http://git.kernel.org/tip/1dba23b12f49d7cf3d4504171c62541122b55141
Author:     Piotr Luc <[email protected]>
AuthorDate: Thu, 1 Dec 2016 01:08:53 +0100
Committer:  Ingo Molnar <[email protected]>
CommitDate: Tue, 6 Dec 2016 09:44:27 +0100

perf/x86/intel: Enable C-state residency events for Knights Mill

The Knights Mill is enough close to Knights Landing so the path reuses C-state residency support of the latter.

Cc Alexander Shishkin <[email protected]>
Cc Arnaldo Carvalho de Melo <[email protected]>
Cc Arnaldo Carvalho de Melo <[email protected]>
Cc Jiri Olsa <[email protected]>
Cc Linus Torvalds <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Stephane Eranian <[email protected]>
Cc Thomas Gleixner <[email protected]>
Cc Vince Weaver <[email protected]>
---
 arch/x86/events/intel/cstate.c | 1 +
 1 file changed, 1 insertion(+)
arch/x86/events/intel/cstate.c +1 -0
index 4f5ac72..da51e5a 100644
@@ -540,6 +540,7 @@ static const struct x86_cpu_id intel_cstates_match[] __initconst = {
 	X86_CSTATES_MODEL(INTEL_FAM6_SKYLAKE_DESKTOP, snb_cstates),
 
 	X86_CSTATES_MODEL(INTEL_FAM6_XEON_PHI_KNL, knl_cstates),
+	X86_CSTATES_MODEL(INTEL_FAM6_XEON_PHI_KNM, knl_cstates),
 	{ },
 };
 MODULE_DEVICE_TABLE(x86cpu, intel_cstates_match);