net: phy: dp83848: Support ethernet pause frames
Subsystems (3)
PATCH 1/1 net: phy: dp83848: Support ethernet pause frames
According to the documentation, the PHYs supported by this driver can also support pause frames. Announce this to be so. Tested with a TI83822I.
--- drivers/net/phy/dp83848.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/phy/dp83848.c +2 -1
@@ -88,7 +88,8 @@ MODULE_DEVICE_TABLE(mdio, dp83848_tbl); .phy_id = _id, \ .phy_id_mask = 0xfffffff0, \ .name = _name, \ - .features = PHY_BASIC_FEATURES, \ + .features = (PHY_BASIC_FEATURES | \ + SUPPORTED_Pause | SUPPORTED_Asym_Pause),\ .flags = PHY_HAS_INTERRUPT, \ \ .soft_reset = genphy_soft_reset, \
Signature · 6 lines
2.1.4
/^JN - Jesper Nilsson
--
Jesper Nilsson -- [email protected]Quoted 4 lines · Jesper Nilsson
According to the documentation, the PHYs supported by this driver can also support pause frames. Announce this to be so. Tested with a TI83822I.
Looks like all PHYs supported by this driver do, so:
Quoted 10 lines
Signed-off-by Jesper Nilsson <[email protected]>--- drivers/net/phy/dp83848.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/net/phy/dp83848.c +0
-0
drivers/net/phy/dp83848.c MODULE_DEVICE_TABLE(mdio, dp83848_tbl); · line 92
Quoted 6 lines
drivers/net/phy/dp83848.c +2
-1@@ -88,7 +88,8 @@ MODULE_DEVICE_TABLE(mdio, dp83848_tbl); .phy_id = _id, \ .phy_id_mask = 0xfffffff0, \ .name = _name, \ - .features = PHY_BASIC_FEATURES, \ + .features = (PHY_BASIC_FEATURES | \ + SUPPORTED_Pause | SUPPORTED_Asym_Pause),\
Aligning these may look nicer though.
Quoted 4 lines
drivers/net/phy/dp83848.c +0
-0.flags = PHY_HAS_INTERRUPT, \ \ .soft_reset = genphy_soft_reset, \
Quoted 15 lines · Andrew F. Davis
Quoted 4 lines · Jesper Nilsson
According to the documentation, the PHYs supported by this driver can also support pause frames. Announce this to be so. Tested with a TI83822I.
Looks like all PHYs supported by this driver do, so:
Acked-by Andrew F. Davis <[email protected]>Quoted 5 lines
Signed-off-by Jesper Nilsson <[email protected]>--- drivers/net/phy/dp83848.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Quoted 13 lines
drivers/net/phy/dp83848.c MODULE_DEVICE_TABLE(mdio, dp83848_tbl); · line 92
Quoted 11 lines
drivers/net/phy/dp83848.c +2
-1@@ -88,7 +88,8 @@ MODULE_DEVICE_TABLE(mdio, dp83848_tbl); .phy_id = _id, \ .phy_id_mask = 0xfffffff0, \ .name = _name, \ - .features = PHY_BASIC_FEATURES, \ + .features = (PHY_BASIC_FEATURES | \ + SUPPORTED_Pause | SUPPORTED_Asym_Pause),\Aligning these may look nicer though.
Agreed, will send a v2.
Quoted 4 lines
drivers/net/phy/dp83848.c MODULE_DEVICE_TABLE(mdio, dp83848_tbl); · line 95
Quoted 4 lines
drivers/net/phy/dp83848.c +0
-0.flags = PHY_HAS_INTERRUPT, \ \ .soft_reset = genphy_soft_reset, \
/^JN - Jesper Nilsson
Signature · 1 line
Jesper Nilsson -- [email protected]
PATCH v2 1/1 net: phy: dp83848: Support ethernet pause frames
In reply to Jesper NilssonAccording to the documentation, the PHYs supported by this driver can also support pause frames. Announce this to be so. Tested with a TI83822I.
--- drivers/net/phy/dp83848.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/net/phy/dp83848.c +3 -1
@@ -88,7 +88,9 @@ MODULE_DEVICE_TABLE(mdio, dp83848_tbl); .phy_id = _id, \ .phy_id_mask = 0xfffffff0, \ .name = _name, \ - .features = PHY_BASIC_FEATURES, \ + .features = (PHY_BASIC_FEATURES | \ + SUPPORTED_Pause | \ + SUPPORTED_Asym_Pause), \ .flags = PHY_HAS_INTERRUPT, \ \ .soft_reset = genphy_soft_reset, \
Signature · 6 lines
2.1.4
/^JN - Jesper Nilsson
--
Jesper Nilsson -- [email protected]From: Jesper Nilsson <[email protected]>
Date: Fri, 2 Dec 2016 15:57:49 +0100
Quoted 6 lines
According to the documentation, the PHYs supported by this driver can also support pause frames. Announce this to be so. Tested with a TI83822I.
Acked-by Andrew F. Davis <[email protected]>Signed-off-by Jesper Nilsson <[email protected]>
Applied to net-next, thanks.