fpga: fix sparse warnings in fpga-mgr and fpga-bridge
PATCH 1/1 fpga: fix sparse warnings in fpga-mgr and fpga-bridge
Fix up these sparse warnings:
drivers/fpga/fpga-mgr.c:189:21: warning: symbol '__fpga_mgr_get' was not declared. Should it be static? drivers/fpga/fpga-bridge.c:30:12: warning: symbol 'bridge_list_lock' was not declared. Should it be static?
--- drivers/fpga/fpga-bridge.c | 2 +- drivers/fpga/fpga-mgr.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/fpga/fpga-bridge.c +1 -1
@@ -27,7 +27,7 @@ static DEFINE_IDA(fpga_bridge_ida);static struct class *fpga_bridge_class;/* Lock for adding/removing bridges to linked lists*/ -spinlock_t bridge_list_lock; +static spinlock_t bridge_list_lock;static int fpga_bridge_of_node_match (struct device *dev,const void *data) {
drivers/fpga/fpga-mgr.c +1 -1
@@ -186,7 +186,7 @@ static struct attribute *fpga_mgr_attrs[] = { };ATTRIBUTE_GROUPS (fpga_mgr); -struct fpga_manager *__fpga_mgr_get (struct device *dev) +static struct fpga_manager *__fpga_mgr_get (struct device *dev) {struct fpga_manager *mgr;int ret = -ENODEV ;
Signature · 1 line
2.8.3
Quoted 8 lines · Dinh Nguyen
Fix up these sparse warnings:
drivers/fpga/fpga-mgr.c:189:21: warning: symbol '__fpga_mgr_get' was not declared. Should it be static?drivers/fpga/fpga-bridge.c:30:12: warning: symbol 'bridge_list_lock' was not declared. Should it be static?Signed-off-by Dinh Nguyen <[email protected]>
Quoted 32 lines
--- drivers/fpga/fpga-bridge.c | 2 +- drivers/fpga/fpga-mgr.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)drivers/fpga/fpga-bridge.c +1
-1@@ -27,7 +27,7 @@ static DEFINE_IDA(fpga_bridge_ida);static struct class *fpga_bridge_class;/* Lock for adding/removing bridges to linked lists*/ -spinlock_t bridge_list_lock; +static spinlock_t bridge_list_lock;static int fpga_bridge_of_node_match (struct device *dev,const void *data) {drivers/fpga/fpga-mgr.c +1
-2@@ -186,7 +186,7 @@ static struct attribute *fpga_mgr_attrs[] = { };ATTRIBUTE_GROUPS (fpga_mgr); -struct fpga_manager *__fpga_mgr_get (struct device *dev) +static struct fpga_manager *__fpga_mgr_get (struct device *dev) {struct fpga_manager *mgr;int ret = -ENODEV ; --
Quoted 2 lines
2.8.3
Thanks,
Moritz
atull
Acked-byQuoted 10 lines · Moritz Fischer
Quoted 8 lines · Dinh Nguyen
Fix up these sparse warnings:
drivers/fpga/fpga-mgr.c:189:21: warning: symbol '__fpga_mgr_get' was not declared. Should it be static?drivers/fpga/fpga-bridge.c:30:12: warning: symbol 'bridge_list_lock' was not declared. Should it be static?Signed-off-by Dinh Nguyen <[email protected]>Acked-by Moritz Fischer <[email protected]>
Quoted 39 lines
Quoted 33 lines
--- drivers/fpga/fpga-bridge.c | 2 +- drivers/fpga/fpga-mgr.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)drivers/fpga/fpga-bridge.c +1
-1@@ -27,7 +27,7 @@ static DEFINE_IDA(fpga_bridge_ida);static struct class *fpga_bridge_class;/* Lock for adding/removing bridges to linked lists*/ -spinlock_t bridge_list_lock; +static spinlock_t bridge_list_lock;static int fpga_bridge_of_node_match (struct device *dev,const void *data) {drivers/fpga/fpga-mgr.c +1
-2@@ -186,7 +186,7 @@ static struct attribute *fpga_mgr_attrs[] = { };ATTRIBUTE_GROUPS (fpga_mgr); -struct fpga_manager *__fpga_mgr_get (struct device *dev) +static struct fpga_manager *__fpga_mgr_get (struct device *dev) {struct fpga_manager *mgr;int ret = -ENODEV ; --Quoted 2 lines
2.8.3
Thanks,
Moritz