Skip to contentSkip to conversation

alsactl: Fix potential NULL dereferences in daemon mode

PATCH New Takashi Iwai 1 participant 1 message Dec 9, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 alsactl: Fix potential NULL dereferences in daemon mode

The code releasing the each card object may access to NULL when a bogus count is given. Add a NULL check just to make sure.

---

Something I forgot to merge, casually found in the working directory...

 alsactl/daemon.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
alsactl/daemon.c +5 -3
index 127701efaf0f..4f0a935a3987 100644
@@ -451,8 +451,10 @@ save:
 out:
 	free(pfd);
 	remove(pidfile);
-	for (i = 0; i < count; i++)
-		card_free(&cards[i]);
-	free(cards);
+	if (cards) {
+		for (i = 0; i < count; i++)
+			card_free(&cards[i]);
+		free(cards);
+	}
 	return 0;
 }
Signature · 1 line
2.11.0